public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: sched-ext@lists.linux.dev,
	open list <linux-kernel@vger.kernel.org>,
	lkft-triage@lists.linaro.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Tejun Heo <tj@kernel.org>,
	void@manifault.com, arighi@nvidia.com, changwoo@igalia.com
Subject: Re: Boot regression: arm64: WARNING: kernel/sched/core.c:10851 at sched_change_end
Date: Wed, 17 Dec 2025 12:04:07 +0000	[thread overview]
Message-ID: <aUKcN9jKInzxM8tB@J2N7QTR9R3> (raw)
In-Reply-To: <CA+G9fYv-h1ONWq232S0BxpdWy52ysPs1VPzKV6ZypSV6B_VSpQ@mail.gmail.com>

On Wed, Dec 17, 2025 at 12:41:39AM +0530, Naresh Kamboju wrote:
> Hi Mark,

Hi Naresh,

Sorry for the prior reply being a little blunt, and thanks for the good
natured reply; I've tried to provide some more constructive notes below.
:)

> On Tue, 16 Dec 2025 at 22:53, Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > On Tue, Dec 16, 2025 at 05:09:52PM +0530, Naresh Kamboju wrote:
> > > The following boot warning is noticed on qemu-arm64 devices booting
> > > Linux next-20251215 on wards.

> > > - New regression? yes
> > > - Reproducibility? yes
> > >
> > > First seen on next-20251215
> > > Bad:  next-20251215 and next-20251216
> > > Good: next-20251212
> > >
> > > Boot regression: arm64: WARNING: kernel/sched/core.c:10851 at sched_change_end

> > The warning you quote should be the *FIRST* line after you mention "The
> > following boot warning".
> >
> > That should be quoted *exactly* as the kernel logged it, without being
> > prefixed by "Boot regression: arm64:", which the kernel didn't log, and
> > which is redundant given the title and surrounding context.
> 
> The additional prefixes were introduced for internal statistics
> tracking and report classification purposes. However, I acknowledge
> that they reduced clarity in this case.

That's fair enough. My key complaint here is just that the initial
message had:

| The following boot warning is noticed on qemu-arm64 devices booting
| Linux next-20251215 onwards.
|
| [ several lines that are not the warning ]
|
| Boot regression: arm64: WARNING: kernel/sched/core.c:10851 at sched_change_end

... where a reader has to skim through all the irrelevant lines, and
then it's not clear that the line beginning with "Boot regression:
arm64:" was the actual warning.

Whereas if that were formatted something like:

| The following boot warning is noticed on qemu-arm64 devices booting
| Linux next-20251215 onwards:
|
|   WARNING: kernel/sched/core.c:10851 at sched_change_end
|
| Note: full splat at the end of this mail.
|
| The testing system has characterized this as follows:
|
| - Architecture: arm64
| - Failure: Boot regression
| - New regression? yes
| - Reproducible? yes
| - First seen on next-20251215
| - Bad:  next-20251215 and next-20251216
| - Good: next-20251212
| - Some other attribute: foo
| - Yet another attribute: bar

... it'd be much easier for a reviewer to spot the exact warning, since
it's up-front, where they'd expect it, and exactly matching what the
kernel output, without any additional notes.

All the metadata being grouped together after that makes it easier for
someone to skip over it when they don't need it.

[...]

> > > [   14.696414] ------------[ cut here ]------------
> > > [   14.696418] WARNING: kernel/sched/core.c:10851 at sched_change_end+0x168/0x188, CPU#12: ktimers/12/117
> > > [   14.729321] Modules linked in: cppc_cpufreq(+) arm_dsu_pmu(+) fuse drm backlight
> > > [   14.736718] CPU: 12 UID: 0 PID: 117 Comm: ktimers/12 Not tainted 6.19.0-rc1-next-20251216 #1 PREEMPT_RT
> > > [   14.746190] Hardware name: WIWYNN Mt.Jade Server System B81.030Z1.0010/Mt.Jade Motherboard, BIOS 2.10.20250506-1P (SCP: 2.10.20250506) 2025/05/06
> >
> > This doesn't look like a "qemu-arm64 device" to me. Are you *sure* this
> > wasn't bare-metal on a "WIWYNN Mt.Jade Server System"?
> >
> > If not, why is QEMU passing that gunk to the guest!?
> 
> Apologies for the confusion regarding the platform identification.
> This warning was reproduced on both qemu-arm64 and Mt. Jade.
> The log is from the Mt. Jade system.

Cool; thanks for confirming!

Mark.

      reply	other threads:[~2025-12-17 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 11:39 Boot regression: arm64: WARNING: kernel/sched/core.c:10851 at sched_change_end Naresh Kamboju
2025-12-16 12:21 ` Peter Zijlstra
2025-12-16 17:23 ` Mark Rutland
2025-12-16 19:11   ` Naresh Kamboju
2025-12-17 12:04     ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUKcN9jKInzxM8tB@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox