From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D1453093A8 for ; Wed, 17 Dec 2025 21:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766006900; cv=none; b=Ei4Oz8OdEM0z4Y0j0kex98JuQ+c8czxpIpKFnP+zbHrGZ1IPd4XZzb51CFZrzDikSDGFEyEUuV+IXA+YsWaYJE/LoacWL5dCBE1COqZGUomhFfBNdK7/kfwvbnlwyemblUOZ1U0I1BGoTHKJ60ebrLHwNOd1yhAzRwBOE8UQGgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766006900; c=relaxed/simple; bh=Xyu8zUJSd+HIGqmgafU7morYh3mmKD9Qgz3LcoaZziE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T0kxSthwduu5uDSrZcS6YeqCWoLzmNykujColqrdr98lSeuwO/yhByznm8kvjLID3BQFP6VjqkVY7ShqHdL4amrqeEriQWwuq8yM3HkVTDhmFJepLFJG5hTNhuarlo/bJ3QoU5eFFZuNXzuHJ5exfM4sjP1GgIGbC7iaqrDeEW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=Wzti7MCH; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="Wzti7MCH" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4f1b147eaa9so48942831cf.3 for ; Wed, 17 Dec 2025 13:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1766006896; x=1766611696; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Kd2WcobjQdnwsk8zN1EwNDl7xZ4zvUhbh6TmBYqAKCA=; b=Wzti7MCHNMT5DWTyyV12gRAZC61Tr9UVtOXJ6v6yjezlEIfzY+tBiqRsgLKN19Q0Dc cWxcioZzaTJUHk+kEq8E9Zez7IYSXONQpPcqB1aInUe85ykEvCLZae7HXvlwBfYmOyil sZ21fsxFm8AFYHYluG9MWxRZ5bkEgJ8KBzrazuQ1tzkg8eRP94+DyKI8Cgtu8d8NVSdP +NrIoWeUwzKZC4+zmtAf8sElKagR8B4sc0R6JNrJYkEKMl3qSV2sZPKGojlLFyj/mWms sbhNPKs05FybfLy6Mh9n85TifeZDNw8LkIs5g9GxO6GUW8AzFamSEhJVNw7NnB8l3Q+R ShIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766006896; x=1766611696; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kd2WcobjQdnwsk8zN1EwNDl7xZ4zvUhbh6TmBYqAKCA=; b=YeFyLfYO+1gUkrLjPt7Kf8OmEtVC6KcVuV9K+28ByciwHsSgEU3zLSpDgwNNIeDeXp 17S/O74yxjMmeRmWcGk8HXy1wRmFsfEj27UMG5ZyYEvNg+51yOYDfRrDQMD11Nav8p8h mpeNmrlnMyvOSTdTBLb4LPwZ92H5UW7cx8EHQjCggyI6qbEmAKpkV1bSxPfp+8ymEGyY QO/B3g3Cvu43eWS3zyUpOU2jYGfINHKazy/CXg8CQesj4D4a3swDRNvUZcB7Usj2Fs0Z /V9lrEjTxAaMCWr8t9hLh8CpsSYF6Wr19hy0BYHTRynXn5QQPQPNzTzXD9gwK47jMPtJ REaA== X-Forwarded-Encrypted: i=1; AJvYcCUM4acNe8SIkVy8TQsDIxHkSYopIn4Ck0f6H8VznWLey5DTxL1XjH7up4q50OTDjOhhrGYYLp3Kuq/lzLU=@vger.kernel.org X-Gm-Message-State: AOJu0YzVNHaIoEWVUJRpzpVbtocemlKkzZukOdlwIetWVbBnqodmgT8T Kn9ABKN7xQ8TRsJP7wR09xwZpAObzj+Z5bmIJBVtsz6ZJwLtW9gTBE9dHYnrG/u5jFYRsKO71jS Dvr9q X-Gm-Gg: AY/fxX7jmBLocF527x5l1XsOo57lYfp6lusJDcB7fgFOhhE9FAv+flj5uZDaQzrjwA5 ZChj24DF6OVZfwzAEf4zIcgLKUnjcGlN4CbF4p97PwAvWeZPHtfPm0Tqkty0eWmG2U/rpDdYwP2 s1Ae/6D8MSLZsOMiTemjIj5FLVkCLAMG6MZTbKh+H3eRbiUE6Ed153CnCon903LoEsZPWz4BOld 83d70HiZrjiwdWmVP4QOetY9tfbc3f6p5BxznTwlaWwg8cPc/AdvseCRVxTCjuNBdEnNvgUItRs FMInIpys0PoTkS1TlP5YA7lVyqFXR3RbJY61EtU5thUaXYeIGJgodQWEulRKA5lDkPROQ/mWH+Q 2Gc84Y2N31zaHE06YI/lcLAVjX1aiOVK2SdAt3kEdCPGoIajsh65Y2tGtynI5cOVNeEfczEeCMO NSg2YVievZ1Q== X-Google-Smtp-Source: AGHT+IHK1mtmutqg6y/0hzjFEZWVKJiT38oIxOrMBicUN/5fclSvNdPVw1dIIFG4MX76NHiSFnTZwA== X-Received: by 2002:ac8:664a:0:b0:4f1:e8d2:6335 with SMTP id d75a77b69052e-4f1e8d268ebmr148928131cf.77.1766006895940; Wed, 17 Dec 2025 13:28:15 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:929a:4aff:fe16:c778]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f360751619sm1247261cf.12.2025.12.17.13.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 13:28:15 -0800 (PST) Date: Wed, 17 Dec 2025 16:28:14 -0500 From: Johannes Weiner To: Qi Zheng Cc: hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng Subject: Re: [PATCH v2 07/28] mm: memcontrol: return root object cgroup for root memory cgroup Message-ID: References: <3e454b151f3926dbd67d5df6dc2b129edd927101.1765956025.git.zhengqi.arch@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e454b151f3926dbd67d5df6dc2b129edd927101.1765956025.git.zhengqi.arch@bytedance.com> On Wed, Dec 17, 2025 at 03:27:31PM +0800, Qi Zheng wrote: > From: Muchun Song > > Memory cgroup functions such as get_mem_cgroup_from_folio() and > get_mem_cgroup_from_mm() return a valid memory cgroup pointer, > even for the root memory cgroup. In contrast, the situation for > object cgroups has been different. > > Previously, the root object cgroup couldn't be returned because > it didn't exist. Now that a valid root object cgroup exists, for > the sake of consistency, it's necessary to align the behavior of > object-cgroup-related operations with that of memory cgroup APIs. > > Signed-off-by: Muchun Song > Signed-off-by: Qi Zheng Acked-by: Johannes Weiner