From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8433128D7 for ; Wed, 17 Dec 2025 22:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766010660; cv=none; b=aAk3YvfC0EwJUpymBVWfhfVdsI/SiopvjtGXo+l2aYCtd8Db18ILvr4M3M4EzFFpCHWNBxVmKpAOekjdrF3gIjK5yPOMbqBwFzh9zZNdpbgTpiDB7rbXnHnekwWCX2PsrExrzKMCO22jUd4Ft2bozHYAnWV5xECNttiU47DXzbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766010660; c=relaxed/simple; bh=bEAIDLIFBMAsViOKX/fAZKIXIXjPLidUeI/NDp3Vpew=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dv6agPCUKf72Wh41EWistIXE4QemGCHGO8y5TimNB1y0X28CjI/NTk0KyoMSL+rCZ2z6fHOaLY++ETF9FsM+8C1wS6mQBH6C3+xKT0FptpihO3AO2vMj0pn9GgLNBbGi9TOIUzegd25bjJLRW3JuW/+sJpEBI+S315dh4mr1wzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=Xegrnsra; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="Xegrnsra" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-88a3b9ddd40so88696d6.1 for ; Wed, 17 Dec 2025 14:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1766010658; x=1766615458; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jN/djI7PKvnyyAXbKKGr0jMJdVuI4zAsGj0vnDi1JaA=; b=XegrnsraHTxH7g05OwVuBLeJFS4wIrFb/hYOCchUmr39uochWF9cesAkFdorr+xnoO VJCl6NrdC7fq7/apahpZOpfn/pWbovTMq8KO0ebq4UUzB0sCjoJ1WSfANOvV8Kk81Va6 lGYaGS4pKRg6Y38kIm/3ougzdLFGuEgAONB5HR5ZSomJ5185g5xXt2XKJgTY8dPf4Lz1 zBAYmkVUzVYP9o1laKnEKlA4o7Y3i3WYti2ThEHcR6jnWI3Y9FipAGcU9D0cFn0QkVSn 6EIR0ybkoKAaMK5UGpyrfxGWxqCJvQXbaO/i3r6yyHyzTX6eQUiyhV28dkOeauCzlMNm BXmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766010658; x=1766615458; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jN/djI7PKvnyyAXbKKGr0jMJdVuI4zAsGj0vnDi1JaA=; b=tO2Di3ZhOJBw9BozorGoEl49lYJhBa60hFPwPhy+BdtM610h8zod4/3UUc/duBve69 uTuVupx7BCYN+K0P1lNUmc7OvAgfOucFjiN+zj2ZVQLDDZwMyUhaFzhyXuT7O9rimm3s Ms+66nC67ngx6LqmML9Ati0jrvFgjxLisKqYpSiSre4BHjtBgxQV9MWOSqXYTRM60SKM YlnBd3qHV/zW71Nzhx9IG2vMziRDFtNMyQVDk5fWRR6HeTutsMV5b/lonvEyTonMjdyo kq6Yw66yVhfN1kkawe2PlE9nte5e61N1KA4rzWrlRr2eoKcVSFnBy/2OvnAZCqu2FAEu A4hA== X-Forwarded-Encrypted: i=1; AJvYcCUPO38KVU47DGRppMoho3lKJFjh2Vlo+l+EDVT4Pr+IPELgDUqlMgSzKIVYdT25tb5nBgD0GHpuzHGo50E=@vger.kernel.org X-Gm-Message-State: AOJu0YzJlnbGdO8z7ko+3cotVqtonOA1ejmbU3Vl1NBvjXXcnZHYD5cE 20AyhJLYjqhZkxKzeIROeYi9Rn4MIAnaKdFmfHDC1jYXfbYgBluoLhTvG0+2pOc8EjU= X-Gm-Gg: AY/fxX4LJ1VPvypJhZARcyBfrhH2DE9nYeh2R50ekc4EZFhes8gsNSidL7+88rtv3w2 d7STEWBMfMuGE+8efkT/BcqWAEXdjXF1sFsslvWBWpAPHvvdLTcwc0LZYlmF4cHirD6ZxKrNwq6 7csCv+w5mKRmVbwqf2vF4kyr/bscuEuMz4T1mIWweHmb/aa2Aoy7gZsHafxB0o3A8XMM36WsL9S jXq/XShcaOxmgQWkd5Go9hdv60ogcgLGENKorDIvhyAMPKIHaC3/qSuFQqLcvg685RmjCZQyjmk 88iJy2EFXiwkyahdkg2v4mtnSO8UBkS+ExTkpZ6dnjqKN8KCuDOouW40jq7lmtoFL2IBXEEHj/I cAEKREcN16CdAgq3cHC9S9WU2NoUj8Si/BWH0teBPkI4t3bpWvHlEduuXSZC2/Bd/iloO/yB+9Z oNfsNIxhc/BCHN6DSvxmEc X-Google-Smtp-Source: AGHT+IEM1wpyl7hzMfn/vufMseel5JojAcvDcHhdXICuQpH+dbIyJ3X9YcY+bavocYvdz16v3ln15w== X-Received: by 2002:a05:6214:568e:b0:880:5851:3c5a with SMTP id 6a1803df08f44-8887e44e9d4mr292735096d6.31.1766010657686; Wed, 17 Dec 2025 14:30:57 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:929a:4aff:fe16:c778]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88c5db7ab76sm4653466d6.7.2025.12.17.14.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 14:30:57 -0800 (PST) Date: Wed, 17 Dec 2025 17:30:56 -0500 From: Johannes Weiner To: Qi Zheng Cc: hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng Subject: Re: [PATCH v2 19/28] mm: workingset: prevent lruvec release in workingset_refault() Message-ID: References: <1b6ad26b5199b8134de37506b669ad4e3c0b6356.1765956026.git.zhengqi.arch@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b6ad26b5199b8134de37506b669ad4e3c0b6356.1765956026.git.zhengqi.arch@bytedance.com> On Wed, Dec 17, 2025 at 03:27:43PM +0800, Qi Zheng wrote: > From: Muchun Song > > In the near future, a folio will no longer pin its corresponding > memory cgroup. So an lruvec returned by folio_lruvec() could be > released without the rcu read lock or a reference to its memory > cgroup. > > In the current patch, the rcu read lock is employed to safeguard > against the release of the lruvec in workingset_refault(). > > This serves as a preparatory measure for the reparenting of the > LRU pages. > > Signed-off-by: Muchun Song > Signed-off-by: Qi Zheng > Reviewed-by: Harry Yoo > --- > mm/workingset.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/workingset.c b/mm/workingset.c > index 445fc634196d8..427ca1a5625e8 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -560,11 +560,12 @@ void workingset_refault(struct folio *folio, void *shadow) > * locked to guarantee folio_memcg() stability throughout. > */ > nr = folio_nr_pages(folio); > + rcu_read_lock(); > lruvec = folio_lruvec(folio); > mod_lruvec_state(lruvec, WORKINGSET_REFAULT_BASE + file, nr); > > if (!workingset_test_recent(shadow, file, &workingset, true)) This might sleep. You have to get a reference here and unlock RCU.