From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0239C332919 for ; Thu, 18 Dec 2025 10:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766052385; cv=none; b=MW2S1YWuyWvlkv+a2prlFxodcvsSQy/1QsGGLP6qVBmaKWuiBesb2Zn8pyzvsOEFknVvtBz+fBNLtTpk+3DXdcDBW8CIlaOmN4k+k8WaXrjPVm1TfTzZXulVkCXhBi2uYMW/I7kXdh/cZE9GcelmQkJ2ZanNKOUUxM+17NXUGsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766052385; c=relaxed/simple; bh=00v3kzAV4duY2v2/dB54DflNOIbH5D4CPWqrg3MyJZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pfL8zLss+P/7NAHhc47pqNmGTy9RuG3GTSSpzCWusU+/77C4pN/VVehsK9IhoCi/u5xF6cpQBHdRQJCE9TTEUwYVXSF/PZdgI08HhoTkw4hghMTjY/rF+VMSGIKNThb6cxYnB3pwmVar20F1nxtUNlUvE7NAWYvCP9GFzgoU3+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vh8DhXGI; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vh8DhXGI" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6499159273dso498496a12.3 for ; Thu, 18 Dec 2025 02:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766052382; x=1766657182; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eMH8wF/DkKC3kkFwo7pbjYWtxpqsSiixfrTZUtPLmDs=; b=vh8DhXGIpbMLGAmpNGkUa7l6mHdGkn8ZsVxvEd36/X86Y2beLx949ux1oGWOJe8GXU URjI2s/ClwZbTIfZlPP/vFWf7SpVch8hP6d1XLItq+kTOfW/bbhSY4gFGCR+g6szQP4Q rTtQ+fXe09cEn5ilYaQcoLcMogJ2TsXSupfCVktcH/LuhkognN+ClT0vtMA9TgTfEQ3S TIkBH1rliLYIDUS394VepaJOkx2y/l8H0zWAoMWIvzdQqO0z4nJ2JeoYduieWlsDjwbL 3norY9qTI8w43dcP0XUz6r6XV34Ll/mhPsCnnEE0fZkyz5qlIGKx6pFLoVF1/jWu7Rl5 juyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766052382; x=1766657182; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eMH8wF/DkKC3kkFwo7pbjYWtxpqsSiixfrTZUtPLmDs=; b=aWobqnckdSaL5Pqk16ubsE8tY6QLNYEoh9VLdd8J51UgpnG/mRX23XtXdEJi9OeTEJ E/Vwq8Cn8AM/GfLdP3E8EoFWAd06QNsrWFizL5M94Z/o0F3BXrBuhSuzmQ2ZFFvtYGBT ZGB2CH7NmiWV//ZVOdWP+ZNGMjchoVGCfVb31pYsFP95SOPrvU4tjdUFrk9wbgloBGbO zXDUXLrKnf61gchYU/gX68wtFoH39HICtBy+HcjhuHhGBD5o7Y9VQ1g17q7YdbB6FSJJ 0JwSrSPsc425aQdiWu1L6nfU6DdP1du0BC7yOk3KH7EaTgfl9ZWKvqxFitWPcqV2wRyr Qt6g== X-Forwarded-Encrypted: i=1; AJvYcCUktofpbcSJDXfD87jFwR0y4JehHnUkGKDqlxNuPV1vFZzUP1YoiO9uotpEMc0Js2789b0DpOUG6WzNqaU=@vger.kernel.org X-Gm-Message-State: AOJu0YwsUoirzlaasuEUCXGSNzMoMIjK9LZDS2+CZI1h/j0+YyB48wWF rKMITuCsQbdXzq4Wlz8ejByhXYI3aJgY180MySkU+GfFMWlFI0xSiEGLDJ9gU26E6h4= X-Gm-Gg: AY/fxX6nghsyOQC9BcgUNrveXhOzrefpnV6Aj6bTOQuVlR+f3Od0BfS4PvhkzdquFif CnkBuzHmVXHmA+8TguJUlkPmlt/E0Lu52MJ6SNEGj/K5bLeIt1CRtusrxlmFlti3t4aWKaRn0Kc ix8icPi5UAntEI/kJ1FYeEnz5Zfx1e6jDJxrOtqe+wXYSXrqyEWCP4sG31aQGazcQ+rLQq9lkr3 Y02/p6xttS7OxuzKfBNsP4Kbn1f0npWS7jjVtLOEwReeWqDbx1msTYh3Bwk6iLQ1iAQk/AFnCGS QRGT2X9sGfg8oj3867cf+hLZQwDEnbXJDvNwR9Dl1bDO3bCX4mGsFHkCUG+HeqOagH6pEkwcwSy YB1PMX1AJ7bdsLGiwim4r/ms852bJ5WzpJrDxI/IYC00wZV69LL2KdRnhm10pfSVM8X+5nxUtYQ 1akOThAiYbpDJdGrGmI5LRmh4= X-Google-Smtp-Source: AGHT+IFA6SS4YOPlrBDtk9PjM8zZe1pqVrSvNV8OpH8V3h+3nAk0ughsiQ0KfmvcLkZxgEp6dOM4bQ== X-Received: by 2002:a17:907:7ea5:b0:b7c:e3ad:cd17 with SMTP id a640c23a62f3a-b7d237756edmr2384134066b.32.1766052382145; Thu, 18 Dec 2025 02:06:22 -0800 (PST) Received: from linaro.org ([2a02:2454:ff23:4410:1c2c:7aff:fe45:362e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8022f93e8esm185717366b.11.2025.12.18.02.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 02:06:21 -0800 (PST) Date: Thu, 18 Dec 2025 11:06:08 +0100 From: Stephan Gerhold To: Abel Vesa Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rajendra Nayak , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1-el2: Add the APSS watchdog Message-ID: References: <20251214-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-v1-0-94ee80b8cbe7@oss.qualcomm.com> <20251214-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-v1-2-94ee80b8cbe7@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251214-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-v1-2-94ee80b8cbe7@oss.qualcomm.com> On Sun, Dec 14, 2025 at 10:49:59PM +0200, Abel Vesa wrote: > The watchdog support in EL1 is SBSA compliant, handled by Gunyah > hypervisor, but in EL2. the watchdog is an instance of the APSS WDT HW > block, same as older platforms. So describe the APSS WDT node in the EL2 > overlay. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/x1-el2.dtso | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1-el2.dtso b/arch/arm64/boot/dts/qcom/x1-el2.dtso > index 2d1c9151cf1b..404174a15659 100644 > --- a/arch/arm64/boot/dts/qcom/x1-el2.dtso > +++ b/arch/arm64/boot/dts/qcom/x1-el2.dtso > @@ -7,6 +7,8 @@ > /dts-v1/; > /plugin/; > > +#include > + > /* We can't and don't need to use zap shader in EL2 as linux can zap the gpu on it's own. */ > &gpu_zap_shader { > status = "disabled"; > @@ -55,3 +57,17 @@ &pcie_smmu { > &sbsa_watchdog { > status = "disabled"; > }; > + > +&soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + /* The APSS watchdog is only accessible in EL2 */ > + watchdog@17410000 { > + compatible = "qcom,apss-wdt-x1e80100", "qcom,kpss-wdt"; > + reg = <0x0 0x17410000 0x0 0x1000>; > + clocks = <&sleep_clk>; > + interrupts = ; > + interrupt-parent = <&intc>; > + }; For consistency with &pcie_smmu, I think it would be cleaner to put this into hamoa.dtsi, mark it as status = "reserved"; and then enable it here in the overlay. That way, we have a full hardware description in hamoa.dtsi. You should also be able to drop the interrupt-parent if you move it there. Thanks, Stephan