From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 946D6313538 for ; Thu, 18 Dec 2025 11:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766057402; cv=none; b=kikKzaHWXLWmxFCcr13Uy++aJhMqdi+eedUkc1KMbiGm8RFMRtFH1kcj6vaDlJUlWYP+264tzGiPBNRrBLIFP34K9GduZoFXaWbWn0NVoLlbloNprmE6RqvTZR9BoFTBL2DDyzCqQRB8dIqcDp4rkhBvssJ8+16df1dZr5wNHrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766057402; c=relaxed/simple; bh=hUfmi2ECE/oVEBC9Q6N/MIdSuqeuk5I2A9Xsh97Pfvw=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O1bWFuWSi/ZkNFfcqwdzE1l1u/eI6N2e+YymkZ7k8lgyFRqvNLXqpB3PV+Og8xfcR1TITrvIq84PdN8DNt0R6KnJ5b2ser4Q88pY2Yl80yWL2HxOxtqCjQEQ8T3IDKKpTpmz+i4VQtKxjj3xAt7PQ30repABjgRvcdFI/nG4dFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cGn7EWSa; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cGn7EWSa" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-59a10df8027so649871e87.0 for ; Thu, 18 Dec 2025 03:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766057398; x=1766662198; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=9UwTmTndjxNkRU+xQueVbhSu5CbtS/JqDANe5YwnyGY=; b=cGn7EWSaJv8apGKs0XIKIjBZueVd9XQ3l6sCLI/uJTBkb0YL4pO2wMuCpURqfZYIOC DSOYHimSwOLqNhtln4xGnv/GkbjwwadwMkkBnjg1pR+09ULZX4yOIxRW5W6SCk3H5r+/ DSM+l//2iSX4fxwJWzcZpNKD3HihX0Z/adTa94jQNYfqMh7W6VOYYNYTT651JxtWZk/s J9THSSBbiIoU+8coP7vg6dezvLO2cMCCY5rPz53STjh+saik7lQgvu7H4JTJCUMRCEOv dafcnvvRQClKFq3UwlzQL9vDwrnPn+b4r83y200jKVtk3jshbpwrjz8gRwsNzknKVf12 hlhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766057398; x=1766662198; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9UwTmTndjxNkRU+xQueVbhSu5CbtS/JqDANe5YwnyGY=; b=OqIMukKW8VhjnLadVs95ldyzq1EcB1rbfiIG85vaHuMd/7MflaTYoEYGPlO9hjA420 /lPAqUnMa+RNHOl9CFqzgQJpXY1N2ZJeRqPzfIEr14Kvufc5YwibWWFE4IJ4X2u286Rh AeDW2gTcUp5zup92XHNirH7CoHVauqBFd6139XptlpQs/Eh00nbG2vh/7KCM2gIsEXVk Lz24Cob0NJqUGvENAw4kqKBEiu4VhkQDgpO8mgJx44EPhTog0bawJj2gXNb3dE5fKygD 255wWcuREnkxZNkx11sLG1gnJVdyt4cZTtL47R0TAK5gJ8z1k4ct0Oowe2iLxmFVDM3G 9/6A== X-Forwarded-Encrypted: i=1; AJvYcCXt76EgvkiImpGEEwD14AchZuPysLnuLMFumka+tFEF639HUiUsJdq2Qy7BJxL0GIPbmonFCV8EguX9QHM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxupfae0IgTqO6z5hkeBdL6m4dzas5Vjj9gXJxHKjpSyrexqrKl m0egwkHxkbBJjZ9dPN7muZJ1iQUUEo13FSaHafS434w2J2F4nzFC+FSR X-Gm-Gg: AY/fxX6O8WaKtdzmr8HtXcSToJ8ULjCQQJjiyrM7oSp3ht+p9Rssf57XjX5kp4TgkZ8 nVbXQHgqQ0EZGtd/CV+ol2oQKCrgOe8B6b26QRETawQX82KekZwXoXfycuLfdJDReo5sx03FgLK 2xNVadoNJXWUhB+VqdCnk9c/A9S8q5kjCK5xmtAPluh0CcaorPP6tJ+UEvoCScwqKqKT07CAO9+ nLKPMqX3P5s32w3kKPHoaUR4u1TavoWQNru5TSUYTpthCAgOFRJ5eG0z4eSQZ2VvVc8+snNfZrJ oV+WFhfq/OGDhfzkwap2/s5hgGhihY6HdAaQVYsk3KGhXIDaoDck/grqTVvcMryR2MPamAAmWuH SqqLCQBcETg4yhWqmFR7mXR+jiJS/2GfeouIVw3yICQVDg2k8qo2M X-Google-Smtp-Source: AGHT+IGAcvXAxC1K1JbJVoEe3yEvZVZGQ4eGCpaeh9EQIqjv95XqmV+JDnbpGIIgvUkK6AnnC9Uxsg== X-Received: by 2002:a05:6512:1191:b0:59a:10df:3599 with SMTP id 2adb3069b0e04-59a10df3775mr1346403e87.6.1766057397481; Thu, 18 Dec 2025 03:29:57 -0800 (PST) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a13405dd7sm1039432e87.66.2025.12.18.03.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 03:29:56 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 18 Dec 2025 12:29:55 +0100 To: Ryan Roberts Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , Vishal Moola , Dev Jain , Baoquan He , LKML Subject: Re: [PATCH 2/2] mm/vmalloc: Add attempt_larger_order_alloc parameter Message-ID: References: <20251216211921.1401147-1-urezki@gmail.com> <20251216211921.1401147-2-urezki@gmail.com> <6ca6e796-cded-4221-b1f8-92176a80513e@arm.com> <0f69442d-b44e-4b30-b11e-793511db9f1e@arm.com> <4a66f13d-318b-4cdb-b168-0c993ff8a309@arm.com> <026b42f6-2f83-448a-9b45-cc8740dd8d50@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <026b42f6-2f83-448a-9b45-cc8740dd8d50@arm.com> > On 17/12/2025 20:08, Uladzislau Rezki wrote: > >> > >> What do you think? > >> > > I think with such big improvement we do not need a configuration knob. > > Your change will fully complete Vishal's work, i.e an idea to allocate > > using high-order pages. > > Yes agreed. How do you want to proceed? I'll tidy up my patch and post it > properly if you like? (likely won't be until Tuesday though). Or if you prefer > to work on it, that's fine by me too. > I think it is worth you proceed with the change. Also i forgot to mention that allocation path is improved also. If you have a look at the perf figures you will see that a pressure on the buddy really has been reduced. I think it is because the state of the buddy is much more healthy now. > Personally I think we should aim to get the fix into 6.19 to avoid the > performance regression (even if we think the allocation pattern of those > benchmarks is not the common case). > Personally, i do not mind, let's see how it goes and what Andrew says. Thank you and i am looking forward the patches! -- Uladzislau Rezki