From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C31E3A1E64 for ; Thu, 18 Dec 2025 21:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766094761; cv=none; b=Gyhh9sEe8/PppJb7fVkDX6O3ALOBJMvSpDAvrfSo26GWTD6a6B593U+2bIf8EGnZAisDQsFId3pqe9MhEl1oWYhWlJsIyTLye2I65lbz1ALmFLvjk6uK3YF058mGQr9k8qHGZhyldjeTPwD7Q0l1FMNTh6Jhc3EK/31gx2Edyos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766094761; c=relaxed/simple; bh=mGtlij2/iYm1d5MX385M+xU+wnJkJBWO9HbGKDrEkE8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sHHCwAj1J2trq1xZxW0T4P6o6+yPJSpQTWSko7kcbLAZsRNKZEkCkFxjWQgVayYF5wjyJ6c8C+2ynotA0VKTxeN7dtzJciNo6Ostuavqn26UANmFcrZJ/JgZDXDUD/RCrc/FLJFvIuQswMo/qjtbroENpGeDBMR4WD3KWuYRl10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kuPkucn2; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kuPkucn2" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a0bb2f093aso11574305ad.3 for ; Thu, 18 Dec 2025 13:52:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1766094760; x=1766699560; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=AjRqsNftQptD2ov1Zp7v1ca2w9sKYnv/JOVqJhe7zzg=; b=kuPkucn2m4UFhkOfClmPdH7og5DjKB+oBhL+RLvLKVIR+Z2fpdHeCbJ+WXCgZNe8GA vJH4WjRleF0shvaBNOn5CXrp9HNWFheLYOV3nFevnCWF/X9ZQ9C9bLLDLj2y7g3UHcsU 4L3pQdcHpDMAl1tz9YTzQTJBqAV2fsMvf2qzHxtV+HkZx8QKgQ/XbBGYVQ1JArub7Oiw 5AEUkpz7p2QvCcSpU0eqi1ao0lvlpAkHh9aTZEfrJ7ptgQtpLi5bY62FUoPVQRirXihK GLFXtukS9NE31BCd1XjX0eeVYetn+lBw3Og/BWishhnstWTUcNAmmmrcy4Aq5SGwLEnh gHJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766094760; x=1766699560; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AjRqsNftQptD2ov1Zp7v1ca2w9sKYnv/JOVqJhe7zzg=; b=KxFj30ClWcGnyXr483l4mg69ndmGYkJSn7WVI/w6EsjonkcwCxlwmXi4NkZjn9YGDb z7dVmu1srVofztzKeCD+SSrKRLdhyi21A5TVR1VXDv6WGIOFQlHuhUpP7iD0UfJ0d/NF AndBo8DF7HTf32KXcYY6zoNxsAdIzxWoixIauS13NizAi4U5KhQAe/s7JxgT2/YgDVyX ijkCVgQgGc5nMJgnhFNYJqWXWJQIZVmX0DhGtYVi+fgJinz7BGy4zmJPS2Kn/wa3S3sJ 1v0kww2R1NerJJc8GLRYSUQUdSLLcWYfZV4n6cEXNX2bBeVCqdSLm0PMJQnCWuzulLrB w4XA== X-Forwarded-Encrypted: i=1; AJvYcCVKsWploOkLfhg2G06Y7jJE1rpOJJgVEkN3rcDObu5cRt3a72DSI84Pqi2fvYTkf7gl/f7GcqOAzkS65ZM=@vger.kernel.org X-Gm-Message-State: AOJu0YzRBbL1VjZwqLM5veNyQmlLwhAP3oQ/AfAeu2UrcxZZXZB5FLgH 75cvlLTlbgBX1O7xZQS+R7QyrS6ZjwQVU6vCRpQQTLMZk/BM+Lan8vCOqwrtC9MM0A== X-Gm-Gg: AY/fxX6gydkx7vAApT8GDHwLz+XkMR31kBPdHOr15VLv4obvkEAFz+ze9w51z0q0IS5 au+QnEz4prNUvoIK42zKvPXfBmjsyrvzaVvER66qbskWRQqQeKTCra8j8yBrkjQ1R87Jkkj6uLE gX05lGF76CVKR7r1QM4TMGxuQPcdvlehsXoeINQfnqDbCyh5KFuMBmHdCHW3sZVecFJvWw1O9Du XSL+sm1nBoCseS4UMBRBteHkXKLJWBE3cb196UdsZY8lt4qElUcb5GGuYZL0/L8fZU0byVVlJum 6lb/0ANy0GBNkO4rkltvImMXxQQQJlYl1IHb0oDVjOMqn8uxA8DbNmXfHp+Iojvhwk2y1tDTVgK Az10mD/tLWZ4dAPGRhLHXRw3nrOfqZ2JOC9fygv2BS37Vyfh2rQOh2GGKWj+OMEd6EpjlUDMbIv q70izisIvlJ/d6HSNaB8+Xq1gKg36fParkERHg+ptKtn+xN2wmGg== X-Google-Smtp-Source: AGHT+IHd75Y3nY2mwEx4VMJQDvHFm2oL1rtkoLgF2d2IhG1E+whdfxRsteBYNCDCOvQtcanbdIptzA== X-Received: by 2002:a17:902:d2c5:b0:2a1:4c31:333 with SMTP id d9443c01a7336-2a2f2222cf4mr6941545ad.19.1766094759576; Thu, 18 Dec 2025 13:52:39 -0800 (PST) Received: from google.com (161.206.82.34.bc.googleusercontent.com. [34.82.206.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4d2bbsm2447475ad.55.2025.12.18.13.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 13:52:38 -0800 (PST) Date: Thu, 18 Dec 2025 21:52:33 +0000 From: David Matlack To: Raghavendra Rao Ananta Cc: Alex Williamson , Alex Williamson , Josh Hilke , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] vfio: selftests: Introduce a sysfs lib Message-ID: References: <20251210181417.3677674-1-rananta@google.com> <20251210181417.3677674-3-rananta@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2025-12-12 10:27 AM, Raghavendra Rao Ananta wrote: > On Wed, Dec 10, 2025 at 10:14 AM Raghavendra Rao Ananta > wrote: > > + > > +static int sysfs_get_device_val(const char *bdf, const char *file) > > +{ > > + sysfs_get_val("devices", bdf, file); > This should be 'return sysfs_get_val("devices", bdf, file);' . I'll > fix it in v3. Can you add a patch to add -Wall and -Werror to tools/testing/selftests/vfio/Makefile in the next version? That would have caught both this bug and the unused ret variable in the other patch.