From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF001E7C34 for ; Thu, 18 Dec 2025 23:49:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766101753; cv=none; b=CVXgiXK5ogBPCEE+wOmTidE86r1gTTAfxScntRbqIVvOaqJlE3ZdClu80VX/F3HFHFC22NP1Md61sCe8dKJXgzEOTZus80oHiLdJqMmsxhOgRUp4OqZHKAgch8RFy3IpxWbzvP3E+N3pF3W7h6PjUfQ7r1tcY3nMXsrngbRGmbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766101753; c=relaxed/simple; bh=VtuFtOxmYb/PpORgLs2pYY7m0pfwysUEfZQjWZDbffU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gZ8Qt7ZIL9AATsrK1mfaybICOEkd5SRotXsoPLVy9GJdJSVesLFDgywpeBaU0urfLChWyjoXu2/bVALXMjAe8fQ75M1YGDL1k89fREYhZLI2xMTy8mWQCFkSIZhFDdiBdPIoCm5KREhlLsyQszHueyyDXeiwM5BGxIRVzvnk1tM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TOpZU7/b; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TOpZU7/b" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4ed82ee9e57so15721511cf.0 for ; Thu, 18 Dec 2025 15:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766101750; x=1766706550; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IloyOMMd5ylI5AueuaVNDNa1yiVVaCMzgGfBgxrjjCE=; b=TOpZU7/bOz35JIuep55icfk6jzpAs+IpFoQFcoM1HRN3YLAb9A3KhgQ7EcL1vjlBaG JSZCnNYj22ahVwb+s7a3r7r215HD2St2wDplRCoNP5k09VzVcmpzCua+0Ex3kG5rchtZ 6LZ897Aq3Adw3TtSnKbVd+qafN1BCjLil71UQ8Oo4/jZR/WbPFPgfljdxOniayxXq2cP nCwXILnt1YALy4pYNmzq100h1xPoadEgiGCI69Fc5Ecn6wT9cLL+spBtVSNpzCNXXhas TS1Rsqa08IDPHq7dgBO7vDpmeaEpd2zX8CTNpQer+fsEZpmqndhTfmk+mo09FAZ/dhfI iC7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766101750; x=1766706550; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IloyOMMd5ylI5AueuaVNDNa1yiVVaCMzgGfBgxrjjCE=; b=xFbsxl0zfI6UjaRTUJcsPWLEKDun4m2fjWVMT8THHZD6vATgO9xt0OIPFsElDBxnVF Fwt0109p+L1CY9buLybQofsd9w6upWCCJG83O07PHCIqNqVhg6UJ89lWfwWoDA/mFffq PImwlbbz12JgtUD5FNr/PNfmIc2n77sHwIEqUSMgj6eI4JSYIOSI1cuRieRh01rWx5gk fEH2RKOmpTKzgT+6YalB2DZGYghnYEzFNrbczSQ6yCOGN9az9Md3gk5JRE+VdU/2PrNY A9pXqQg82PkWlbi+zIs3hjItEKldaXocM2dt7RXcOBhk5atE6nyaNB6HyJjnez9AluAt 3/+w== X-Gm-Message-State: AOJu0YwUZJFlTZlVEqQV7VdgEsyyf/agNMxamuOGY4zUvsR0AAwMb212 qSC2ca1IWVriv3R/HeyjJZODzLG0txDL9gAxpYPH93eAnWexBOjh0hq7ADFbYw== X-Gm-Gg: AY/fxX4f7tUrE16wDFevAancRPB6T5trh/j1UQKz1/UySxXRfdk+nvJhayT848k1Oo2 Mr15No/UJ/SfJj9M3aplTTRbjS1UpkWBWQLKCdUbM2lCCoC2qQc0ZZjWw66OKPWm+AVjKmTA7Nv lBe2xDbUgCI3v32H3yllZ4ZrspxBUpOFJxqSpVUCzVsjk7kSIX/N875SurZ1jasTJIYUV/C/cU9 Hc9wHlRsw6IUF3M2UKRB8f3Vy8PtiDjBtt3ZwaBKj2Cr7KQGGlo3OrqgDlT3ERsHZRY8lqVjKOu +p2sGyfYt+we5t1IZ7fayr/U3LWFSuZux3sNfyU8htqSjKEJ21vHyrnzL9kP2n51jHikBMsXWF2 2JwoeKA+wJybAPfkM5nNt/bDilm7E7qs8ISLxS//bdS6Le0USQYxwGL+wyWrMhwp5ElUzfIvNYw IRFGTtM/rLRanwQAGY X-Google-Smtp-Source: AGHT+IEuCqAiz7tKoEs7EuK/X/tMhWVEAkhspAQbq2aT86kftRRnc2o+VQJryW1KpVrUd0c8qF7fgw== X-Received: by 2002:a53:bdcb:0:b0:645:5b1f:4ca6 with SMTP id 956f58d0204a3-6466a8a56e5mr521141d50.8.1766095012737; Thu, 18 Dec 2025 13:56:52 -0800 (PST) Received: from localhost ([2601:346:0:79bd:c44b:debe:992d:e6a]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78fb43b298asm2433287b3.19.2025.12.18.13.56.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 13:56:52 -0800 (PST) Date: Thu, 18 Dec 2025 16:56:52 -0500 From: Yury Norov To: Steven Rostedt Cc: LKML , Linux Trace Kernel , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap Subject: Re: [PATCH] tracing: Remove size parameter in __trace_puts() Message-ID: References: <20251218163739.5605f9ea@gandalf.local.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218163739.5605f9ea@gandalf.local.home> On Thu, Dec 18, 2025 at 04:37:39PM -0500, Steven Rostedt wrote: > From: Steven Rostedt > > The __trace_puts() function takes a string pointer and the size of the > string itself. All users currently simply pass in the strlen() of the > string it is also passing in. There's no reason to pass in the size. > Instead have the __trace_puts() function do the strlen() within the > function itself. > > This fixes a header recursion issue where using strlen() in the macro > calling __trace_puts() requires adding #include in order > to use strlen(). Removing the use of strlen() from the header fixes the > recursion issue. > > Link: https://lore.kernel.org/all/aUN8Hm377C5A0ILX@yury/ > > Signed-off-by: Steven Rostedt (Google) Thanks, Steven. I'll take it with v4 of the above. Thanks, Yury