From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416D3199949 for ; Fri, 19 Dec 2025 08:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766133673; cv=none; b=EsMn+/wjVrcmRBCPupfRNM/tHQOSICTlFShbkk8milqyMiuRU3pYryCwDnL/1a9nQYhvk9QfWV9XKXNviwUKMXuFuv2i/Nyshae0Wj2FXEWOBqc1WzW4z8e8y9gGbNf3/beGRXs1wQ2X/xX1Z5jy/pxmMmltUXdbb/XrfxxZAok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766133673; c=relaxed/simple; bh=sKDaesyjGDQSEEMHHHbV/A5dX1vuXejghpBFVKU6UKo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d6MABEiCgg6VcIZ5alUQ8ifBOyv2sqJowhJdRQNmTIn1ZVmrYyNvV/3oaqvno405cPxCx3CWmwLOwcUbRSGqGSvARJCS5leAWFXgaG9R8rkbFfzGklDNMb5/NK+tGwxtHeWYYCh+WlXyVwAkPZrxp8Ey2AygKprNto/jqwCrYGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=b91czsm3; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="b91czsm3" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so11325075e9.1 for ; Fri, 19 Dec 2025 00:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1766133669; x=1766738469; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sUHONLbC5JmfhuQtv7hxDSLeRlsmZ7DLJDoyFpcnmnw=; b=b91czsm368ybrr8MCmgYnfXkgRewsIjuxcGaz0o7FVaR0DCcR/Oqz/5Rzs3CMPrJIp EsUb5qrj66BlWvJQLmvzd49SkWo0H1daKb+x1vQ/Fsx/JlZfm/xZQlapJaGpTKO8M4YW MERh0S3M9l8sNj0+WdyfhLoyRWLFJK897276oAxsVykaHPodp5Yxxp7yDG+uc0Jv7zEm 0GuduhX88HPJ2g3QM68RIToCy3XxKmwzYPkJDVWuvrTiI19wO7+Fw4h3otO02B6d26lb O2sEYjvdWiyxTaMZ1/p5PIAk/pHoIFbP78f+oWIE2ccHGd/JJKuiKjsy7qPRL2mDNUsi SogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766133669; x=1766738469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sUHONLbC5JmfhuQtv7hxDSLeRlsmZ7DLJDoyFpcnmnw=; b=X+kpnd+US6ZE4muYJ94FkJE1QXlPJd7SJ08hOaUomBPYaznxRw+YVuNvqkIbeNRAY1 GLCQNevw2wsT5H9EBliD1fuIAKnXXEDg+nX1xvnc4wrCfEDLJI9odnfq9LwY9fPHsaTz B+T9TqzmhXIaMPUCIM10GBEj/I+4S6DFF2uDV2S83VS21FznFuVdS4tlxkB9ip0dJ3IK FTUnicgUrpPJlyCMIwb97Baxq5WMXK2URiYpi0CbDa4kicIw5NO6awDKncAzPlsPuCJ1 MUsa2W5Z9VpEFLVLXn28TACaMxei3LZaSDcgdOXQNpE6yb1wsolFRh7RG+jlwUc8a9M5 e/sw== X-Forwarded-Encrypted: i=1; AJvYcCXII5jo3UvJHrjH/ld0ez1KOi19YOQ14qqj4qP4E/OXZOFeB8xfqi6o8/+n7QDlPWHdLKSMpQTDGDmrHSM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6NPl1BCXoyg8DNdNKKVLBHzfMelgkTyv4L1oBMlFuYdM1krh3 V2mKhHXAa5hQ0iESMuwzCP/9c+IqabEiqTia7KOE5Hy1RoDjenDoM6nwndXRfum1lbE= X-Gm-Gg: AY/fxX4NeKv9wA1rTMzmf2tLRwQcblDFjsr3rY3zOhomG0MV/NccLYganxMRuWjf+Cc 2XRoYRiOas5Q19x4IrWCfYcQRkPP6iwH+uhhbnATjswYoNOca9fKl6i9FWKIfjQpm5C6LLCNVm7 211QMULm8x/ZFCfjuN7BHeN3A7wz+dYQPCg7LAbo31tpP/ErI1S4I4NBS/lN1drPW5tPnqpE3Q4 fr/wzABsqXp5/CFFCEcTuPusBZ4+Tp3xoAyzDDqPGgyiAmEChfHJL4DuX/+BZ9t+DswuwZxc0c6 WeTQM1HQAiETaDCzr7jY8qp+pDCWec2GklEezCU8u72EzfEbFX57rB/pulY0htnOYfZDebfgpBV 8UlDww6h6AjUIinbmqibq9nKrD2E/0PHmLMFkBxmUP3FKQbzKQ/e0Q706MXa2cIOXmaQot4VLka 4d5mh84eMlDw4Rb1xU07O3h8TQ4ElAA6g8VWY= X-Google-Smtp-Source: AGHT+IFcYKHJPYgcQllNij+gtuh3TUFyMdvjko5VxckTTrIpB5QdDmLRz7IVikid/Xpypc29wtbmXA== X-Received: by 2002:a05:600c:3146:b0:477:af8d:203a with SMTP id 5b1f17b1804b1-47d1959e697mr16323735e9.27.1766133669362; Fri, 19 Dec 2025 00:41:09 -0800 (PST) Received: from localhost (109-81-80-251.rct.o2.cz. [109.81.80.251]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346e48sm32499035e9.2.2025.12.19.00.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 00:41:09 -0800 (PST) Date: Fri, 19 Dec 2025 09:41:08 +0100 From: Michal Hocko To: ranxiaokai627@163.com Cc: akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, elver@google.com, andreyknvl@gmail.com, =osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn Subject: Re: [PATCH] mm/page_owner: fix memory leak in page_owner_stack_fops->release() Message-ID: References: <20251219074232.136482-1-ranxiaokai627@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251219074232.136482-1-ranxiaokai627@163.com> On Fri 19-12-25 07:42:32, ranxiaokai627@163.com wrote: > From: Ran Xiaokai > > The page_owner_stack_fops->open() callback invokes seq_open_private(), > therefore its corresponding ->release() callback must call seq_release_private(). > Otherwise it will cause a memory leak of struct stack_print_ctx. > > Fixes: 765973a098037 ("mm,page_owner: display all stacks and their count") > Signed-off-by: Ran Xiaokai Acked-by: Michal Hocko Thanks! > --- > mm/page_owner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 27d19f01009c..b6a394a130ec 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -952,7 +952,7 @@ static const struct file_operations page_owner_stack_fops = { > .open = page_owner_stack_open, > .read = seq_read, > .llseek = seq_lseek, > - .release = seq_release, > + .release = seq_release_private, > }; > > static int page_owner_threshold_get(void *data, u64 *val) > -- > 2.25.1 -- Michal Hocko SUSE Labs