From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7E322A1D4 for ; Fri, 19 Dec 2025 09:27:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766136458; cv=none; b=TfSjD6xRRSLTcqkIUgCPqTVKp3MDw7Xlt3fCHKdYHcSaAc5o2g1pLl1rMk6ye6JUB4nxU3L1kK+v0eXICBxzFckgqzRsG9hqMvVucfg2vI5KN59/snLGHst6OgotPje0mvqkevOx7Q06f73lbkW7llD6WV0mOiLtaLRLn2MXOBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766136458; c=relaxed/simple; bh=ncH0WX29PmKWXHkMb9W7MxVSClntPHuEcroF5q70h10=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rOOY9PHkwW5o7D3ONLoPvnzsSucENrJgLEPfYVq/ch5+MIDB5reclTlfOIIBmQQI3/lG8AEVY43ozjCMl4p6l4mvnzLTKoUUP33Sj1SWJaeSFwZ5WrRr2IaDYj0lMf/PnymZulWWiM3v0B7J9ypndD1FDDFl9cnVkK/98/36Gq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H+WcGS3v; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H+WcGS3v" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-430fbb6012bso1091163f8f.1 for ; Fri, 19 Dec 2025 01:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766136454; x=1766741254; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wW6xT6zKa/DbjWLXugE2SCCRWvLGUmWxnxjoprlKdVA=; b=H+WcGS3v77jbJnwUDd+ufnwpnCE2+JOwndJc72wRCz1TiTv7SbKQ+L0AL+9b2MdR0b yLitPq/QpQ/mA0uuB3ZVM2uhcCuEM+kVTU+ztcyLKj8FXsl+ZNysvtG0tZbv4ewOzlBL 5MO2hjatAJxRjfsSTTC488uTiSBYw/NnDCJ1YFnrnfG4pRuYi/BpDxW6ddZRwU7e+LsC p2laa4toWEalNK0JQAatQrDrwd6PTIjnb8Zf+kJgQiJlelYu4zFXZAts1mpT0KGTjFPU na8j7lbGWRBbkQcsWnHKpj7lx4xsfUfnzKPNxaBBekIoDZCesM4lfmXNul6KBlsBIsVM iI9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766136454; x=1766741254; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wW6xT6zKa/DbjWLXugE2SCCRWvLGUmWxnxjoprlKdVA=; b=NcBHnVa13bFin1ha3DPTvouw2ULnNUcvHmiiEaZu6xR8M1bgPjMeNu3XJyZzHfdQSW ZYt3oUrXsRIGIDHgUFSU1+Zc9Iv+pGC1ti8ZhkccXfOdgATPlrORsd0UJ7nHIxHhGgCh aV7JqQV2wTs0x1ZKs39haxi3OMn/searp967F/LBK4SKrbfxSov31lGJY69mg8zqXD+f 3de5onfRst6xNrc4+C+upaoh72B/j+itc2Bn3lBQw3HC5p0IwKM6OjBZzEGF9IBciwHG ZE8AaXm2+l+dWP+nhZgN6z1Ufb3GXWxmyD3qs5hBP00ZvWrNNf3ycZQqpmQJGT0VlCrR XQxQ== X-Forwarded-Encrypted: i=1; AJvYcCUy39LYV0YRfTHrwAPDYlTJrfrsZUEV3TS4xmQmggZrhM3QAWo/ZOq8O1gLAUn9oyRLA6E5MPdrfIGIcuk=@vger.kernel.org X-Gm-Message-State: AOJu0YypuXX+NctCUQ6hqNU2/dlQYTP4IWj338jpji8qxdX59nLbGbcu s7J1zDT9V8mYfWDJWsTP9/SWvh1vquOk1f+YgC23IOWiLW2tOxeR8fdE X-Gm-Gg: AY/fxX70275bE03yYVHc9Jjrnvx3ij/3M0/sMI4iyQuZdrrNHYzZ4aSythSIW50+svO KRB1Fm7UQeGRkIOiOuKNulkmKp6Oae3geZNbPfuu5ISvcVmJM8Pw9sdKj4wec8KFBJs3lhTLMYv lseCN/ny4AwG+fF8kSiRstpRJL/gl0bCArw47SA/L34ESgIU2WWd2XYdNjSTTovL+jGt70nNFqM W33UHpj16tM++u8TOAJ71C0O0NvhQWXNNvBz2u/wjmWonNvrivrQqtT8KYfIyDn2Kr/1+VHv7C0 zAXaINNb8qJ2wI0jQzl4CwOwivkze/dMavbYgrjqLWf2xYMVPIR+L3svYTaUFniQJOEkAfovsxq uhS8IPNOOs26/DKYFjkuozJlg82d8ytwpQJcCfjfrsKAeXCYRLete+m7TWD2t X-Google-Smtp-Source: AGHT+IGZerDxPd0b4gdsyGcPyDLXRMjKat7AKujtmwuJrtu/onCDnzbnfiuN8UDjCgD2FYBSHSQDtg== X-Received: by 2002:a05:6000:24c9:b0:430:fc0f:8fb3 with SMTP id ffacd0b85a97d-4324e506148mr2457124f8f.38.1766136453761; Fri, 19 Dec 2025 01:27:33 -0800 (PST) Received: from krava ([2a02:8308:a00c:e200::b44f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm4154643f8f.30.2025.12.19.01.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 01:27:33 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Fri, 19 Dec 2025 10:27:31 +0100 To: Steven Rostedt Cc: Florent Revest , Mark Rutland , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Menglong Dong , Song Liu Subject: Re: [PATCHv5 bpf-next 3/9] ftrace: Export some of hash related functions Message-ID: References: <20251215211402.353056-1-jolsa@kernel.org> <20251215211402.353056-4-jolsa@kernel.org> <20251217200712.606a9a7a@robin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251217200712.606a9a7a@robin> On Wed, Dec 17, 2025 at 08:07:12PM -0500, Steven Rostedt wrote: > On Mon, 15 Dec 2025 22:13:56 +0100 > Jiri Olsa wrote: > > > index 505b7d3f5641..c0a72fcae1f6 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -82,6 +82,7 @@ static inline void early_trace_init(void) { } > > > > struct module; > > struct ftrace_hash; > > +struct ftrace_func_entry; > > > > #if defined(CONFIG_FUNCTION_TRACER) && defined(CONFIG_MODULES) && \ > > defined(CONFIG_DYNAMIC_FTRACE) > > @@ -405,6 +406,14 @@ enum ftrace_ops_cmd { > > typedef int (*ftrace_ops_func_t)(struct ftrace_ops *op, enum ftrace_ops_cmd cmd); > > > > #ifdef CONFIG_DYNAMIC_FTRACE > > + > > +#define FTRACE_HASH_DEFAULT_BITS 10 > > + > > +struct ftrace_hash *alloc_ftrace_hash(int size_bits); > > +void free_ftrace_hash(struct ftrace_hash *hash); > > +struct ftrace_func_entry *add_hash_entry_direct(struct ftrace_hash *hash, > > As this is no longer static and is exported to other users within the > kernel, it should be renamed to: add_ftrace_hash_entry_direct() > to keep the namespace unique. ok, will change jirka > > -- Steve > > > + unsigned long ip, unsigned long direct); > > + > > /* The hash used to know what functions callbacks trace */ > > struct ftrace_ops_hash { > > struct ftrace_hash __rcu *notrace_hash;