From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10651361DB9 for ; Fri, 19 Dec 2025 15:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159620; cv=none; b=Eu+n3up3YpBHf7dHbXIYmjGhx2Lw1JNNKd0vMMMELvh9Aghfmr3SlCPJSBiF6+grfOOAzVJPa3+TPNZNqNMkE3EqA7zGXz77c9wWMiOVDVo8dJ0s5DShFGwbKQdyQ7xofR6tbuhQAtL1AbHl6TrLwHHFYMB4UeaDzTFL72u3ejc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159620; c=relaxed/simple; bh=HGu5ujBF26oUozqxf92lQiU8WCo4Uwymerm0mV/65Io=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ir/jtzzM+bKqd2F2MkMAPiFwxpmAKtHTpfqR9FIq00Wzt2GzRVtMMJBT2P1FD3frVdMKxNE5hbbBxqscX66ImGWGCco/mVSZkO1GKTevlM9tLCnjE+o5kvD54mVIIoWBWgSWeGKZibSGr/NzFbThuoKUQVx6lwnao0HOR+H6BnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gneErokJ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cYpuoG96; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gneErokJ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cYpuoG96" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766159618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L/jqv3cJiOiniBhqPGj3ePpHhUWqhzpVBGmNIJAgyrQ=; b=gneErokJXByMWX4yCMQksJ5byBifGuMd2/pfAhCrct3qLwo0AxdGgcHCee1snvT/khX/Em jFbq0W00xUciQ2PErmLWeqW8uHNrn/xvCnSPG2KOUO3PrB+0Hs/80SPZZaWaxtNTM353uV Xn0DtoSMRPyF2hY/83xd1+qXM5WtmZM= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-ScMjKgJ2NVmtp56jcViH0w-1; Fri, 19 Dec 2025 10:53:36 -0500 X-MC-Unique: ScMjKgJ2NVmtp56jcViH0w-1 X-Mimecast-MFC-AGG-ID: ScMjKgJ2NVmtp56jcViH0w_1766159615 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b245c49d0cso416213085a.3 for ; Fri, 19 Dec 2025 07:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766159615; x=1766764415; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L/jqv3cJiOiniBhqPGj3ePpHhUWqhzpVBGmNIJAgyrQ=; b=cYpuoG96qs5PIwY7b/UYWdPGN9Y0jHbd37uCxB3klz1jHElpqq5qONCbb9npaN6FjC m/W52CNTF6IiVjWXDdNcAbcFbd4FcnFT0My6iOHySTg4kuyC4s6Z1mhto0p4zkk7vyUa C+EkBVrSmNyOA5iZuqlFp9cePIFG4fo56zbeFY1HtyM0VkpSvYKrd8UdrewyJK6GIb6q oD1HsNYYF3AHnYJ5J5gMBO2l00BlvVRTBoZ2aPbVNeTUXdjeKqG2d9ptJ9yeV7Rw5jg4 xAsd+3ViR9s++51J8EHNeS6arCQtWouoMylHQzC9kozjmA5Ns/fBHOZVWfQJbOC4GB8q jY9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766159615; x=1766764415; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L/jqv3cJiOiniBhqPGj3ePpHhUWqhzpVBGmNIJAgyrQ=; b=JpXf8zcKAskFSJqzVskFPO37Z5McsGlbF+QLWABM6SJcJlkNWH8ax5WxNHlwhRgbP9 3CUQ3TK/ZOasL/N28m+A2Oc9lEGgacoKAKffDv8sr10UffFPh/tdC3RUquByM7R8510U KdD1wAk77oissDjPiv5RIVDysbfTkdd8bls2m9Jf5eDvc1a03rRebTpO0XxbX+oMdmqH +ca1LaCeNBfqBr9v7bS3tyY/CUQ+s4VvJ+QhLP6ipUNpfiAcQTkhuQzUwF+6Ws67Ca18 3cD9rfXLisk7LBRkK5YPMrYrCzJNJCmaArkFUxlJbtFrDdQkZyjkLC6uqn/n1N++pVs6 lMQw== X-Forwarded-Encrypted: i=1; AJvYcCU3k4utddVft1YJiUgO83A2MVcWOKYhoSC2Su7hwXoA+kevq7SK11yye+1x6l6fV+zIo2AHEQc42vuxrBE=@vger.kernel.org X-Gm-Message-State: AOJu0YwKURu+cF0vsZrfg+WzcGHJOx1/ClI+Y63LO1xEpkUp/hC3UW53 JwbHGcQkwiVr97fgH8CQZG4jm1Uc3gqC3m3GOvkPlcrvjxsOibeGAMtoahS99c6Zv1ASoyFgTsz X92s/8+4WA6PB+4W2wf0ZQHjZQgSnY/2+DOZj6gPYOqoakJ+PI+I/Q3ePXOyPtDTmKQ== X-Gm-Gg: AY/fxX7aKc1uz9yV6dTlMTTKSfnr9VVoaTdhtNHEZPZNNj3pFdgL35I3VYbyTKAV3b3 Fp9/WvN8W25qUvHFJWzeWcHiQVIWBgTNJO2O5n4y/IagLR7Kr2H4xz9cm4of28dtXVbnfFSal3a Gd5W3bDUkaF0ipRfjJka8vbD89sN7AoahZAZcwRdkrvIzFEO3ZD6rPUxzWdu3Tws11UReuq7TfW kpw/GaKj3z9ZT3VMF7SBTHd2QI1qN5NJR8rvGAcjuMPdYn93FkijLfrriAD+xOm7PirLuuZ6xOL tOmOFsD/daxpYU7FjmyzoL4zjS6yPdOjdVJXgHDFW0lC5u9ATMLpyjUx2M88wVa983F3Rnh2sWZ zXbk= X-Received: by 2002:a05:622a:613:b0:4ee:2423:d538 with SMTP id d75a77b69052e-4f4abcf11f4mr44817081cf.18.1766159615313; Fri, 19 Dec 2025 07:53:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFouxtlBTlJ/HrUU+MwNoFw+6sCgUDeVcjckP1nM19pQghsLhFECfIT9+YLku6qXfDkEDxFlQ== X-Received: by 2002:a05:622a:613:b0:4ee:2423:d538 with SMTP id d75a77b69052e-4f4abcf11f4mr44816581cf.18.1766159614863; Fri, 19 Dec 2025 07:53:34 -0800 (PST) Received: from x1.local ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d9623fdd8sm21404906d6.4.2025.12.19.07.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 07:53:34 -0800 (PST) Date: Fri, 19 Dec 2025 10:53:33 -0500 From: Peter Xu To: Jason Gunthorpe Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nico Pache , Zi Yan , Alex Mastro , David Hildenbrand , Alex Williamson , Zhi Wang , David Laight , Yi Liu , Ankit Agrawal , Kevin Tian , Andrew Morton Subject: Re: [PATCH v2 2/4] mm: Add file_operations.get_mapping_order() Message-ID: References: <20251216144427.GF6079@nvidia.com> <20251216171944.GG6079@nvidia.com> <20251216185850.GH6079@nvidia.com> <20251219145957.GD254720@nvidia.com> <20251219152030.GA371266@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251219152030.GA371266@nvidia.com> On Fri, Dec 19, 2025 at 11:20:30AM -0400, Jason Gunthorpe wrote: > On Fri, Dec 19, 2025 at 10:13:02AM -0500, Peter Xu wrote: > > On Fri, Dec 19, 2025 at 10:59:57AM -0400, Jason Gunthorpe wrote: > > > On Tue, Dec 16, 2025 at 02:44:29PM -0500, Peter Xu wrote: > > > > > > Or maybe I misunderstood what you're suggesting to document? If so, please > > > > > > let me know; some example would be greatly helpful. > > > > > > > > > > Just document the 'VA % order = pgoff % order' equation in the kdoc > > > > > for the new op. > > > > > > > > When it's "related to PTEs", it's talking about (2) above, so that's really > > > > what I want to avoid mentioning. > > > > > > You can't avoid it. Drivers must ensure that > > > > > > pgoff % order == physical % order > > > > > > And that is something only drivers can do by knowing about this > > > requirement. > > > > This is a current limitation that above must be guaranteed, there's not > > much the driver can do, IMHO. > > There is alot the driver can do! The driver decides on the pgoff > values it is using, it needs to keep the above in mind when it builds > its pgoff number space! Yeah, if so, it's reassuring. :) > > > If you could remember, that's the only reason why I used to suggest (while > > we were discussing this in v1) to make it *pgoff instead of pgoff, so that > > drivers can change *pgoff to make it relevant to HPA. > > What? That's nonsense. The pgoff space is assigned by the driver and > needs to remain a fixed relationship to the underlying phys the driver > is mapping in. It shouldn't be changing pgoff during mmap! I meant, return *pgoff as a hint, not changing the pgoff to be used.. Only changing the pgoff (as an integer) to be used in the VA calculations. Thanks for sharing above information to ease my mind, if drivers are all smart enough (I'll trust you more than myself on driver knowledges!) I think we're all good.. -- Peter Xu