* [PATCH RESEND] drm: xe: Replace sprintf() with sysfs_emit()
@ 2025-12-14 8:36 Madhur Kumar
2025-12-19 15:32 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Madhur Kumar @ 2025-12-14 8:36 UTC (permalink / raw)
To: lucas.demarchi, thomas.hellstrom, rodrigo.vivi
Cc: airlied, simona, intel-xe, dri-devel, linux-kernel, Madhur Kumar
Replace sprintf() calls with sysfs_emit() to follow current kernel
coding standards.
sysfs_emit() is the preferred method for formatting sysfs output as it
provides better bounds checking and is more secure.
Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
---
drivers/gpu/drm/xe/xe_pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_pmu.c b/drivers/gpu/drm/xe/xe_pmu.c
index cab51d826345..f016459c9904 100644
--- a/drivers/gpu/drm/xe/xe_pmu.c
+++ b/drivers/gpu/drm/xe/xe_pmu.c
@@ -425,7 +425,7 @@ static ssize_t event_attr_show(struct device *dev,
struct perf_pmu_events_attr *pmu_attr =
container_of(attr, struct perf_pmu_events_attr, attr);
- return sprintf(buf, "event=%#04llx\n", pmu_attr->id);
+ return sysfs_emit(buf, "event=%#04llx\n", pmu_attr->id);
}
#define XE_EVENT_ATTR(name_, v_, id_) \
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] drm: xe: Replace sprintf() with sysfs_emit()
2025-12-14 8:36 [PATCH RESEND] drm: xe: Replace sprintf() with sysfs_emit() Madhur Kumar
@ 2025-12-19 15:32 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2025-12-19 15:32 UTC (permalink / raw)
To: Madhur Kumar
Cc: lucas.demarchi, thomas.hellstrom, airlied, simona, intel-xe,
dri-devel, linux-kernel
On Sun, Dec 14, 2025 at 02:06:59PM +0530, Madhur Kumar wrote:
> Replace sprintf() calls with sysfs_emit() to follow current kernel
> coding standards.
>
> sysfs_emit() is the preferred method for formatting sysfs output as it
> provides better bounds checking and is more secure.
>
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
Thanks for the patch.
I just did a small adjustment in the patch subject while getting it
pushed to drm-xe-next.
[drm-xe-next af90706f0eec] drm/xe/pmu: Replace sprintf() with sysfs_emit()
> ---
> drivers/gpu/drm/xe/xe_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pmu.c b/drivers/gpu/drm/xe/xe_pmu.c
> index cab51d826345..f016459c9904 100644
> --- a/drivers/gpu/drm/xe/xe_pmu.c
> +++ b/drivers/gpu/drm/xe/xe_pmu.c
> @@ -425,7 +425,7 @@ static ssize_t event_attr_show(struct device *dev,
> struct perf_pmu_events_attr *pmu_attr =
> container_of(attr, struct perf_pmu_events_attr, attr);
>
> - return sprintf(buf, "event=%#04llx\n", pmu_attr->id);
> + return sysfs_emit(buf, "event=%#04llx\n", pmu_attr->id);
> }
>
> #define XE_EVENT_ATTR(name_, v_, id_) \
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-19 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-14 8:36 [PATCH RESEND] drm: xe: Replace sprintf() with sysfs_emit() Madhur Kumar
2025-12-19 15:32 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox