From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 482725477E for ; Mon, 22 Dec 2025 04:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766376764; cv=none; b=SbAUeeEmeFUBsRgXbUZHB9VfRBIB+Q62Q3hMuMBpXPb3v68r0TbPSlAxn8r7bO6nilaOIbSJsR0M+tZgoTX0Uuk7BPsojs5wds+GQ9otq/OcU/EMtlmCcbwV+7Y3g9t1oaCALjkRh/FkHzm/9QZ0GubdAW1EiQRh0IeZHnBM7eE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766376764; c=relaxed/simple; bh=uiGL6bI9E5xhV5thK+bUKPSVKRCLQkIzEcUzK7Tya30=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W7M8T0u25bvhET4kBEW2Xp/iugb31iYXN/B9B6FcyF1O8CZEfi6IX9rSqYzCVSk+LOsPMmAoOk65wdPbtrFW6nB25zSFoySyu+RPoxxo1CUBVlgotXcsQh+f4ENC8bh0LGWcENliI+w05wsb8C7ynPSGhs/WmPDdKfzfebq/Ejc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FSdVdvfX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gH0rTufT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FSdVdvfX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gH0rTufT" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BLNQw523866739 for ; Mon, 22 Dec 2025 04:12:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=io5VZPhhZrnfLxSbtVM4Pb6q V0WDFXxp11fXTfGXScM=; b=FSdVdvfXTUW09YZj4ydMRPmjqSDB0a3dt+/vRzfh v634P01uY0GEMWMZN4zP9NUx3YNuFjOBrDp+/xqQTMmU+fqCvvSacq8wVUN6bgAw FWZ/6UV0IeVeJrmRIbGNf1kC/UskdI8w5HSMHyMjXfOpcRX6L8K/7LFog80RXHTP aBkNUaMIudfH2szKmdXWegywxEIFg/ik11anJni/Ck0hubUXB9EjZi98oFiblIwr dlEXgmvBXBw9qGVCnK2QujhRok7k/JxZpYoOBFGuB8Iv3kULe+I0rI2Ud1cF8adF DbRtG6SBT9Z773DsrRlqqkU5r6uWZ5kdW5jWmRKKqwvDTg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b5mru3kcu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 04:12:42 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34c21341f56so10843522a91.2 for ; Sun, 21 Dec 2025 20:12:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766376762; x=1766981562; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=io5VZPhhZrnfLxSbtVM4Pb6qV0WDFXxp11fXTfGXScM=; b=gH0rTufToecYNjApsjFnM90Ilf3no917O2wfMEgrNCYIfSnq/VugSDiII6fFHOoqWB uUkqExykzyV3wEzUx5EL8uK+FA7WtP1+MRLs62GiFOUj0wewJgiCrDmGSpDXtl6C2HJf LsphnmTx81ZgR1sye3EB27ZuUpsJDrqxERHnBL9i386Oet9J2hLRd3etS5zpV6yk0ezQ gALHxNBSpL1ARQWS6eVBl0RlYfZatmom6GpsVcVURh5hvI8GmkIUssNKrPNImLpdZhSu sPTsJeznD4uEYRqb0Auklp4/i+QF/hrxX3KXcIHW0hi5yrMs6RezoVJgmi34yenJLFmb AqWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766376762; x=1766981562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=io5VZPhhZrnfLxSbtVM4Pb6qV0WDFXxp11fXTfGXScM=; b=TuswO5DwLZr+B7taY9u4q/4kzHWIb4gc50pfuUJ1x2QV2H5p0O5+CkFsjIA0PdC5R6 xlvulMF9eO3jhGOYSd/DZZ8KsZhLVVPpof5w87KHXBxOhjniZUpZJc+LJ/H5pqEWOZ5H Kg6l/8/pIRxIpTBlCW2hW52wkD9MldVRnUztGIYMB+V2pzo5NBDysjusU+M9mbBoFEyH c2+Bgpf9Zv9pSRNXA74qbeZ7E/u4Ru89pjsg32ZeM06r2UnoE1piGw92pjLaG25E13NN 7gIQU47JOELnqK1LU1u2vzXmaKKEE8zADRT4pAYZXxhKwMfAPwsdFX01PqoZEksypj2R h7qg== X-Forwarded-Encrypted: i=1; AJvYcCVcnpkn1OxhoMLNpInLFr0AKuDCkep0ur7gvO8cegmiShdpKQSSZGnS43TDqrFlozZF5PCiqfZbbGgEaW8=@vger.kernel.org X-Gm-Message-State: AOJu0YyWoFfWdLUjM8Yq69Ez1d/FEJsn+e5DOSSnmCpic6jww7cVLdQb dmzHQzd616BxCUW50CE9tQ5ctkYjOU9uip2ptvRFgCNc2yvZFzfpb+OdEh6MPkV/JvCyC5RZySg swxCgGWlFxzYxqumFJxeJNHK6KcgkIHnS3mJ1+whVytRAUyD07NSSVF2BvdV++wYQB1o= X-Gm-Gg: AY/fxX4YOGWvGCn3OzkMIt9H75Yqpv1dIamYZ2aERzGP/D9knCIIBQ0KiSrQdu8qrcQ 9aaSsBpfy9WZUv4d7MP4sh6UDlyHYBjn7sk2HNlxrF8wnzuQHa92gmMaT0jddY7WIRACfA+6tOj gl729OtSAOUaLIcsMb5iuK0sw1tuEYtGVJFoNrCwbxVD0yPNlj8KasVb2WZEvP3Czthqh9NTVKH oU7wTOvFz2DDfZ4RMCR7qCggHIdgOvMBiYZ0aavBLk7t7AwlPanD2EsI/Wi+rN6o9PvePC6PdrH /MWUhTeU4hBoaBjdPS301ASpMU37XvMLVWNMZ/1F/AvE8O+QPw0AgQ+Fhkphw2/rgWAw1bUZml9 rKHa4JbRn0nCriHh1/jt4perkmoIiOuVJjCH64m8vheVw4IiCcyVG/sC5uZzZFdgzZ7WnEfd5j4 hhgv5aTQdiTVrb9POT/OlJu17sH8KcDnwa7PIKvc8= X-Received: by 2002:a17:90b:33c9:b0:340:dd2c:a3f5 with SMTP id 98e67ed59e1d1-34e921235efmr8551028a91.3.1766376761752; Sun, 21 Dec 2025 20:12:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtjxZjxhbJ9a4spzMpfyauFiI1BR5fR5WYEOsvsf4JMslo4jt2FEXrVJMnaIe39yHda99Eew== X-Received: by 2002:a17:90b:33c9:b0:340:dd2c:a3f5 with SMTP id 98e67ed59e1d1-34e921235efmr8551010a91.3.1766376761193; Sun, 21 Dec 2025 20:12:41 -0800 (PST) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e76ce0b4csm4338155a91.1.2025.12.21.20.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 20:12:40 -0800 (PST) Date: Mon, 22 Dec 2025 09:42:34 +0530 From: Varadarajan Narayanan To: Krzysztof Kozlowski Cc: andersson@kernel.org, mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, quic_mmanikan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gokul Sriram Palanisamy , George Moussalem Subject: Re: [PATCH v8 2/6] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL Message-ID: References: <20251219031010.2919875-1-varadarajan.narayanan@oss.qualcomm.com> <20251219031010.2919875-3-varadarajan.narayanan@oss.qualcomm.com> <20251220-amphibian-nippy-firefly-d4fac0@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251220-amphibian-nippy-firefly-d4fac0@quoll> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDAzNCBTYWx0ZWRfX1F+n9L5K7Ehz BOZ2y5znQuPfRzKGU4NwN9KxdE7cKB81VhnWCUrcg+AtPCW+1kgZh9uucb+RkTC5oZ0/Jo4zK4O 9owt6X2amQyYRI/a1Onna2MyoNWMJ0LHXJznyKQq8OkNfocgyLadxRMzEB12AhmvFGkGSwRadTf UraNLVEZKGupkpzwq3MjUgXXd8o7R7WcUT8H7AgL9bAl4z+cbFSG5ADw1GapUIEXgmdbNsEz0Wu 7Iw63wW7JaPpDj+hfq3S03CcHH3/3/mS42N2laXm7i0hYl4jlw38ATurjaJk25a7t6vAImNBGUg 75FfFuwcdLaDrTjKVL5KYzss7JWYBXgTLzU5hTWkyX2GM2XkI9X1DzL/PDWD+QxS7mSNpN4AN8j TS6C37+6whOBJRCvCJHkFxUsH7fFQ4ZHYY8rz8myuPhdyRBCBo6/8NGPqdcRocGoYrutg+Pp60h 1hBHHIFjWmrqZBRuSgA== X-Authority-Analysis: v=2.4 cv=VMnQXtPX c=1 sm=1 tr=0 ts=6948c53a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=UqCG9HQmAAAA:8 a=gEfo2CItAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=A8Rii4P67zMKQ2kysyEA:9 a=CjuIK1q_8ugA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: cTFC4SUGd8QppAOvnJt8Y7-yBUWemTMN X-Proofpoint-GUID: cTFC4SUGd8QppAOvnJt8Y7-yBUWemTMN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220034 On Sat, Dec 20, 2025 at 09:39:54AM +0100, Krzysztof Kozlowski wrote: > On Fri, Dec 19, 2025 at 08:40:06AM +0530, Varadarajan Narayanan wrote: > > From: Manikanta Mylavarapu > > > > Add new binding document for hexagon based WCSS secure PIL remoteproc. > > IPQ5018, IPQ5332 and IPQ9574 follow secure PIL remoteproc. > > > > Signed-off-by: Manikanta Mylavarapu > > Signed-off-by: Gokul Sriram Palanisamy > > Signed-off-by: George Moussalem > > [ Dropped ipq5424 support ] > > Signed-off-by: Varadarajan Narayanan > > --- > > v8: Dropped Krzysztof's 'Reviewed-by' as the bindings file has changed significantly > > Drop ipq5424 support > > Update example to ipq9574 instead of ipq5424 > > Change 'mboxes' description > > I do not see any "significant" differences in the binding. You ONLY > dropped one compatible (no problem, why would we care?) and renamed one > description in mboxs. No other changes, nothing, so I do not understand > what was the significant difference here. > > Dropping reviews at v8 is really unexpected and to me it feels like you > rewrite everything, which should not happen at v8. Sorry about this. Was not sure if the changes introduced in v6 (https://lore.kernel.org/all/20251208-ipq5018-wifi-v6-2-d0ce2facaa5f@outlook.com/#t) had your approval. Hence wanted to seek your approval once again. > > --- > > .../remoteproc/qcom,wcss-sec-pil.yaml | 172 ++++++++++++++++++ > > 1 file changed, 172 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml > > new file mode 100644 > > index 000000000000..0fe04e0a4ca5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml > > > Well, since you ask for re-review and I really cannot find the > difference, then let's start nitpicking from scratch: > > Please use one of the compatibles, e.g. the oldest device, as filename. > > > @@ -0,0 +1,172 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/remoteproc/qcom,wcss-sec-pil.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm WCSS Secure Peripheral Image Loader > > + > > +maintainers: > > + - Manikanta Mylavarapu > > + > > +description: > > + Wireless Connectivity Subsystem (WCSS) Secure Peripheral Image Loader loads > > + firmware and power up QDSP6 remoteproc on the Qualcomm IPQ series SoC. > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,ipq5018-wcss-sec-pil > > + - qcom,ipq5332-wcss-sec-pil > > + - qcom,ipq9574-wcss-sec-pil > > + > > + reg: > > + maxItems: 1 > > + > > + firmware-name: > > + maxItems: 1 > > + description: Firmware name for the Hexagon core > > + > > + interrupts: > > + items: > > + - description: Watchdog interrupt > > + - description: Fatal interrupt > > + - description: Ready interrupt > > + - description: Handover interrupt > > + - description: Stop acknowledge interrupt > > + > > + interrupt-names: > > + items: > > + - const: wdog > > + - const: fatal > > + - const: ready > > + - const: handover > > + - const: stop-ack > > + > > + clocks: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > What is this? How did it ever appear here? Sorry, but this is not a > syntax present anywhere. > > > + > > + clock-names: > > + $ref: /schemas/types.yaml#/definitions/string-array > > Neither this. Look, I have never reviewed something like this: > > https://lore.kernel.org/all/20240829134021.1452711-2-quic_gokulsri@quicinc.com/ > > NAK, that's not a binding style at all. Please do not invent completely > different style. > > What's weird, this change did not happen at v8, so you still kept my > review tag even after inventing this weird code. These were introduced in v6 https://lore.kernel.org/all/20251208-ipq5018-wifi-v6-2-d0ce2facaa5f@outlook.com/#t by George, not me. This is why I felt the changes were 'significant' and dropped your reviewed-by tag. Will restore them to the way you had approved earlier and post a new version. Once I restore the above to your approved version, can I include your reviewed-by? Or, shall I wait for your fresh approval of v9. Please advice. Thanks Varada > > + mboxes: > > + items: > > + - description: TMECom mailbox driver > > + > > + qcom,smem-states: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + description: States used by the AP to signal the remote processor > > + items: > > + - description: Stop Q6 > > + - description: Shutdown Q6 > > + > > + qcom,smem-state-names: > > + description: > > + Names of the states used by the AP to signal the remote processor > > + items: > > + - const: stop > > + - const: shutdown > > + > > + memory-region: > > + items: > > + - description: Q6 reserved region > > + > > + glink-edge: > > + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# > > + description: > > + Qualcomm G-Link subnode which represents communication edge, channels > > + and devices related to the Modem. > > + unevaluatedProperties: false > > Best regards, > Krzysztof >