From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88DA0306D3F for ; Mon, 22 Dec 2025 17:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422806; cv=none; b=Mowp8ZPG0oDqdkqLa9Qt6XX/aumYbQru3fTQCc/GRp//O/5xsCX95Pztu65FCRDN9QaxJQQSUIN7M63d9InkD+HTVtFEYD9OEgCp33oGBcU5tgpUMxStYgsddEToMDW+IMiVYidTrYJqHsPFb8+ImGwKQ5d6T33E/RurMhU481g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422806; c=relaxed/simple; bh=VIFf1U5GRy0XwNaSKn2IE50Ho6S8Qyrd1XW4SiN5kJ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LJvkMPF9r3MwHw1t9bXTE3fY36DLMQirMeKDDAAL+dSnPGBOmPIyaHZHbtBCfR50cmEU7lqPO6z3aOurebnD6KftqjXsXEzGoHyY9cNjngqWTNWIzmg22NL43bLXaN3Eav3XxNneq0kNwlV5v1rxkH4WF3StRldl+lPWel7pSbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DynX/JLy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=noqQNVzH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DynX/JLy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="noqQNVzH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766422803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0f4fyk4zQd9fdm0CypX1izzvghVD+Nvn4s4UeRXutpY=; b=DynX/JLywm7WGzHdQeYUDFRE67wpzJImZS2RNXAvPtjf3hAcKq1y+ZsxJELoCwnv8V10DX W4seGhz+4taPvZrRd+H9dvyRUPrp4xF5UB2tgBwPNhkrmMjAw3lZD9zPqQn2YRCwPoZaoj /FsiHyjw+advtHQBisYYqyRH9WwP7Uc= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-I7MxLTWxMtOOCXJgUrrjVQ-1; Mon, 22 Dec 2025 12:00:02 -0500 X-MC-Unique: I7MxLTWxMtOOCXJgUrrjVQ-1 X-Mimecast-MFC-AGG-ID: I7MxLTWxMtOOCXJgUrrjVQ_1766422801 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b51db8ebd9so1317118385a.2 for ; Mon, 22 Dec 2025 09:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766422801; x=1767027601; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0f4fyk4zQd9fdm0CypX1izzvghVD+Nvn4s4UeRXutpY=; b=noqQNVzHciN3yMdTX8Dps/u2bH4VTzq0tnVvPTofml8KAZrO+4P0lpIIMO3/T2vodi PQNClCNfQs9EjrbREkdMuszY2rGCVl4NPbCIh2XIa0n8Vv/Y1dQAm2z+GAAXJYlgQFG8 UYTZxrzJIPSVy00b0cBTQ7MCkQ/uWHwr2AyvLqxXGc7HNKUtvNWrDr9NN1jLW2xLcLtG 1tUfD3aECYCKF/ew/6o3rcfX8pSP8uwp0IFN/8SCXnh8GZDEFIGojS1yRh55o6RVFmyA CMFGze0BpNxTeJiYCZx0zM9idpYSOUCaJtzgU5mDBtGVWxZ7AHnThZEAknwtkvMA2n7J Rvlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766422801; x=1767027601; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0f4fyk4zQd9fdm0CypX1izzvghVD+Nvn4s4UeRXutpY=; b=xHcp4CqNW/Bc/lEYS7QxWMDX8u25WQqch7jwjFHmY56JforKm13aJkSn8ztktF2PCL ITrnkSwWtR4EnIf+NjBlCu/0dQ5F+oAIT1BeTROB9zmQS/SOxL2KRr2o5xTkvAKvJq7z J4L9z/CY9cf7yg7sIBjqeIp5WN8q89nNzhHaSp/h1aiUt55mj2XjqlIukK9Q74sHjB0Q w9sRksmQ7TNoeqnL9U9JCvhyEyIgot+ceJ5JIpfWd9SJSbLWz/PxWCyVN4HuswPWPaSv Jt+YUtJJcvWlIqsquykGkmYaKLAqHIf6XF55QgI0iMAlP+xHPaZIylsWQtK1rhx32+dh /vvQ== X-Forwarded-Encrypted: i=1; AJvYcCXZUGGPPKLEOaCgvGvnhWOlUHgxRr1Uwi2o5OspL9+e0E9NNNO5xRM83tG4LxW/3xFyzXEezVe/m1DGkrQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0piYxdOzfT+IDrgL6NjsVVd7r1HV8CkiTY8v+htE/TCEZqdOW bnohapUd/PN3DvVV3jUx1pz9Wp72wQO8COM6t+K9FCeMsnXA29a5txgfiI7FkwQyLgLAJGn7Wpv /51M066GTB0ghQmXFBURqTwb0HwigFwh7SDDWWxewdKwghZz9ylDs6R7dRN3WoU0/eg== X-Gm-Gg: AY/fxX7dqEQZWcdXPInZjg/7VR68WLzR96XJ+qzke4BMhsf46pfxMRO0ypEXVvDHVeX eZP9duMfXjpf2n1eZDs8Iy00I9mhC+jckHz+TKmh/JVxdaeqxNQCtTkoA26zjN/cRs/qeOxC5qc DW3bdJ3mXBxSGSFHcJwMYXdVDzd0naSyuRHolyIB/wctsD3HhHpmbq7huSpRKFW1vSS+VTAnWAy 7FkD2hY6zvz6DKYY+ZiMf8DIysW1Zr7Zs/UhciOgZXKA5KUlA9H6O6e88SrrhtmW8PKgmuPO3OK DxJEB+c+CEhmbL/LHDIZ9XrtK0ia7GYsanS2YXdpTdJ+XMV1KaIGexsC+JE5h3vRS2UNRCTpdmx x6+O1gchoAa9AM1cNKpB4vi+N5Yy0D9rhqg7KD5g+iKdn X-Received: by 2002:a05:620a:691a:b0:8a3:22d7:6ca3 with SMTP id af79cd13be357-8c08f66c311mr1952379085a.31.1766422801371; Mon, 22 Dec 2025 09:00:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAXWK3aLK/w4OobjiC8eVjtvAbAxtwT1W5l5sKLlnUZ5at1LIDG+lvn7LFEDMGYJA0qFTMJw== X-Received: by 2002:a05:620a:691a:b0:8a3:22d7:6ca3 with SMTP id af79cd13be357-8c08f66c311mr1952376385a.31.1766422800985; Mon, 22 Dec 2025 09:00:00 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d997addd5sm86399716d6.33.2025.12.22.08.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 09:00:00 -0800 (PST) Date: Mon, 22 Dec 2025 11:59:56 -0500 From: Brian Masney To: Ryan Chen Cc: Michael Turquette , Stephen Boyd , Philipp Zabel , Joel Stanley , Andrew Jeffery , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mo Elbadry , Rom Lemarchand , William Kennington , Yuxiao Zhang , "wthai@nvidia.com" , "leohu@nvidia.com" , "dkodihalli@nvidia.com" , "spuranik@nvidia.com" Subject: Re: [PATCH v15 3/3] clk: aspeed: add AST2700 clock driver Message-ID: References: <20251010072540.666673-1-ryan_chen@aspeedtech.com> <20251010072540.666673-4-ryan_chen@aspeedtech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) Hi Ryan, On Mon, Oct 27, 2025 at 06:24:59AM +0000, Ryan Chen wrote: > Hello Stephen, > Will this be accepted in clk-next? Given that aspeed is a SoC vendor, and you already have multiple clk drivers, I think at this point your best bet is to do what the other SoC vendors currently do. I think you should: - Create a new subdirectory drivers/clk/aspeed/ - Move the existing aspeed clk drivers into this subdirectory, and update the Makefiles / Kconfigs as appropriate. - Add a new entry to the MAINTAINERS file for the aspeed clk drivers. You probably also want to have that entry cover the reset driver, and any other aspeed-specific drivers as well. - Post that patch set. Include this new clk driver as a separate patch in that series. Feel free to CC me to the series and I'll review it for you. - After it's reviewed, wait a week or two, and send Stephen a 'GIT PULL' using git request-pull. I can help you with the workflow if needed. One important detail is that you want to base your branch for the GIT PULL on the lowest common denominator, which is usually the latest rc1 from Linus. So even if Linus is at rc5, try to base yours on rc1, unless there's some issue, and you need to document why. Stephen should get the merge to newer rcX branches from Linus, and not you. When you send a PULL to Stephen, you can use 'b4 am' to assemble the contents of your branch. When I sent him a PULL a few months ago, I included the b4 commands that I used. https://lore.kernel.org/all/aL8MXYrR5uoBa4cB@x1/ If he accepts the pull, you'll still need to post your patches to the clk mailinglist, and have them reviewed on list. Folks from aspeed should do that review publicly on the list. Brian