Hi, On Sat, Dec 20, 2025 at 06:00:09PM +0800, Chukun Pan wrote: > Although the hp_det pin is not used, according to the schematic, > the headphone detection pin is GPIO4_B0. Fix the incorrect pin. > > Signed-off-by: Chukun Pan > --- Apparently all of the public schematics (board rev 1.1 - 1.3) have HP_DET_L connected to GPIO4_B0. It's also easy to see how the wrong pin ended up in the DT: the schematics also added HP_DET_L as a comment to GPIO0_D3 (which is actually connected to TP_RST_L)! Reviewed-by: Sebastian Reichel -- Sebastian > arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts > index 392ba83ab05a..a0d8f52a706f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts > @@ -812,8 +812,8 @@ gmac1_rst: gmac1-rst { > }; > > headphone { > - hp_det: hp-det { > - rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>; > + hp_det_l: hp-det-l { > + rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > > -- > 2.25.1 > >