From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F12D234E767 for ; Tue, 23 Dec 2025 15:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766503768; cv=none; b=ocES+Hl3flL+M3eKSzgJ8zF9E3jV4RGZzhZerOFF3edj5t4xoHLoTnUguOHHTE9h684rrNCo6Aj6yg7mip9cdRROVP4+a6OogL8+oxEOs1UGbBsBPka+HlX5pg3dAss4leqwBrzwrAGvz62br2sVPRmTNyZCFqwtvTHV2eR5g00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766503768; c=relaxed/simple; bh=J3Ux6KfmhKmVgyLO5VYVS8zBuR2bX/I0/MfIw/LAZ8o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aZ1En/BIprveQ937eEYuSO6XApuxdZg6R3Hbic5RRU0MrgO11dg6h2PB5Isz/vciJyzTqJnN7EFaode6571VD/fPX1iMXxemzUfD7vlSZNttOM2n0cERdFkPr/qz7j1jHDA+nGdX90jvIJSScYOOcKDmMgA1GdsWt6Fy+YeafPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cLax2bY+; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cLax2bY+" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4775e891b5eso21349335e9.2 for ; Tue, 23 Dec 2025 07:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1766503765; x=1767108565; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KU2jR3iD71XyPNeJB6Z0f1sjv8gA+ESxHLWTu3Zqx2A=; b=cLax2bY+nqPZ2zW1yoNStNqZB0J7RvhbDINYMmSNot1/ncLinjhKWmv7ZTpBZgLT70 /gES+aPI8ChI3np23Fq2xLAXu/uv9eFVyOtguudeaoEqoW+1uTvhjr0TQhKYao5qP7N3 lb6qKODdh+4a/1mimcHbDOyYje3JwUTTTwklI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766503765; x=1767108565; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KU2jR3iD71XyPNeJB6Z0f1sjv8gA+ESxHLWTu3Zqx2A=; b=C09FAc/EGUv4CmJ9zklmSjvOWIF64KXmrR2xwwC/U70FFnDpUCDtnwHHG+CkNxFASy 1bvfpdSukZsCqqDzxjGHMXNnCFXVOBK9TQwDoeaya5EGAF8KaiNCKescrhMYUb2pBK+U JJ5f3lEOTvOKPUCBtxwQqckTrYie58qIagMQJPfeW2kGcKgua0vepUh3Q5aobrz/fG3P 3gLvviXUrkHSajyAZVbrn5urEvCbvpU1SkEgWEQl8q600VaWKXlD/5HpqeCL93mhnuiC SlyeM7M+l9dY2g/VycIG2IrA9PN06M+ZyjQGjj4YcIf9fftCcWFCLXnBM9sscVJfFdOf 6yfQ== X-Forwarded-Encrypted: i=1; AJvYcCUm0iZ8WT5zRNAsZq3p78bMXczEFv6NWaSXIOvYGqJS04ny4vBi5G/ifuNTRTK6SkZJfn5SrW0XlHpq7WM=@vger.kernel.org X-Gm-Message-State: AOJu0YxtUhCF/BKzSSvY/MqqEXBdtsjEMDYPVjAh9yysi5iZdChPfjQX rEpYrxFYvkvocV9Hqhe7jUznDynQxgTgH6ao+hLGcPBjyX3uVbUJNUnkpPhWUEL3Pg== X-Gm-Gg: AY/fxX6G5ZCe0ph5RhyKrFru8jBcpJrw/S9FMvB/Te3PEwiQbi/gkot43apscJJcauf +RARE5tByrZW+8n8jkxCDZdzuWfeBmNJOr8E+A3YHdnv7sOXyV9jK8xzeE5o3drJYNoIUvPh/Wr TM2ewlmkVp/doJae3nmK8q+1aEnPh1NW4Ibn1f7NAnfBeJa1USK58i5/ZD5aVdp2Uwx4avkj9f2 rigoFSQy9R6iPx4IBmX6eA6czUsvdsqFkfYNbLnmF7qI730VAIwxkp8bYDlLpdtE8gmRU8JjcjH UxDQM7Ub8ln9cN4zNuAKA1XN0c3sMgFKg41U7AtCpDLOQFJF6h0MzyHc3iySkAWFJxsEJ+0tqy4 s3zWakBK3aMW7lu3BJbDgZns9vYRs8AsVxmj+9RVH6ppDhp9fPKHVEvXkUmKIpdngL4bST8He4T cbrNp1X9GFtS9XniiuYQ== X-Google-Smtp-Source: AGHT+IG/0CMavtTslZpbI5j2xnemhkhT+LYz90KZrJXqfzvE0jdXgerJdltJj03OeHUtFpEK624zOg== X-Received: by 2002:a05:600c:4506:b0:477:9392:8557 with SMTP id 5b1f17b1804b1-47d1957711fmr143504525e9.18.1766503765317; Tue, 23 Dec 2025 07:29:25 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cbc0bsm248425045e9.11.2025.12.23.07.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 07:29:24 -0800 (PST) Date: Tue, 23 Dec 2025 15:29:22 +0000 From: Fabio Baltieri To: Dmitry Torokhov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benson Leung , Guenter Roeck , Tzung-Bi Shih , Simon Glass , linux-input@vger.kernel.org, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] dt-bindings: google,cros-ec-keyb: add fn-key and f-keymap props Message-ID: References: <20251209154706.529784-1-fabiobaltieri@chromium.org> <20251209154706.529784-4-fabiobaltieri@chromium.org> <20251209192243.GA963693-robh@kernel.org> <2gd2npolfpo5jruwraamwpn3wurm7w447jnwsbcfonmhos2owf@ejrqiz3qdxj4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 17, 2025 at 10:05:45AM -0800, Dmitry Torokhov wrote: > > Had a look at the tegra-kbc driver as you suggested, first thing it > > seems like the fn-key functionality there is dead code since 2013, > > `use_fn_map` could only be enabled with platform data, not OF, and that > > has been removed in 3a495aeada2b, as it stands kbc->use_fn_map can only > > be false. I could send a patch to rip off that code if you want me to, > > clearly it hasn't been used in a while (unless I'm missing something). > > I guess you are right, we shoudl clean that up. We have another newer > driver that uses the same approach: > > drivers/input/keyboard/pinephone-keyboard.c Alright I'll look into it and rework a v2 with the extended map, checked the code again and I see your arguments, sounds reasonable. Cheers, Fabio -- Fabio Baltieri