From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay03.th.seeweb.it (relay03.th.seeweb.it [5.144.164.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5EF532E15B; Wed, 24 Dec 2025 09:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.144.164.164 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766569433; cv=none; b=SXLK8ehHiktPM3TSC0wKwJkPnEPPHwQaEABoCq6hUUYiaWaWZrFqptiLdm2RATEBb7GHJH4Gbc3ANPsuKAMH/i2cMriL9EngU8wSUHwZj+DJCoUaQyQTTshNXszvqHjc3Rp3rqcx9ieflEnAvROs2JOzLbu/PbPCqhfblxRo0w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766569433; c=relaxed/simple; bh=cqrRVlT5zEkk7a+GLMF4w0WtQOwiW5t7Wwt+reF+RlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pcxg7bLqVFCDFBL5+PWLHFQcM0KYe2fuLbex907kr+YJ9iquPcbr5pRP0Ro3Xv4MGH4qtT0mdVjMNKMrILwQSOsT+oej+LNUvWvAzQQ8RvY4+fdwq9WSIyjQlSnzJv0sJe1AkY6EtYb4CW5U4sWb0XT3CdKgd7v4UARa4v8m5jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org; spf=pass smtp.mailfrom=somainline.org; arc=none smtp.client-ip=5.144.164.164 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=somainline.org Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 0537A1F6CD; Wed, 24 Dec 2025 10:43:42 +0100 (CET) Date: Wed, 24 Dec 2025 10:43:41 +0100 From: Marijn Suijten To: Neil Armstrong , Sam Ravnborg , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Casey Connolly , Rob Herring , Krzysztof Kozlowski , Simona Vetter Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang , AngeloGioacchino Del Regno , Konrad Dybcio , Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v2 07/11] drm/panel: Add panel driver for Samsung SOFEF03-M DDIC Message-ID: References: <20251222-drm-panels-sony-v2-0-82a87465d163@somainline.org> <20251222-drm-panels-sony-v2-7-82a87465d163@somainline.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251222-drm-panels-sony-v2-7-82a87465d163@somainline.org> On 2025-12-22 00:32:13, Marijn Suijten wrote: ... > +static int samsung_sofef03_m_probe(struct mipi_dsi_device *dsi) > +{ ... > + ctx->vddio = devm_regulator_get(dev, "vddio"); > + if (IS_ERR(ctx->vddio)) > + return dev_err_probe(dev, PTR_ERR(ctx->vddio), > + "Failed to get vddio regulator\n"); > + > + ctx->vci = devm_regulator_get(dev, "vci"); > + if (IS_ERR(ctx->vci)) > + return dev_err_probe(dev, PTR_ERR(ctx->vci), > + "Failed to get vci regulator\n"); > + In case someone wonders why this is inconsistently *NOT* using regulator_bulk while the other patches are; this was a last-minute clean-up whose fixup! commit I seem to have lost in a separate branch. This will be incorporated in v3 together with the whitespace fix in the comment. - Marijn