From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65B3127467E for ; Wed, 24 Dec 2025 07:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766562886; cv=none; b=Mpbtmwcmmx43XQ1eCVtnS3VpT4dhtzo/XkcgRcNZcX3Vd1to8ZGNzfrKnj1PCsk+gB+N/Nas2/ZYkKZ88qp94p6u9KBGv8oQzwjNiBGR0Nvh0dqDBffWVeWS+auNjniEHZFhsvxij5SAsl2a+EOD2DIK5Di0M6dycy0Gea5tfHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766562886; c=relaxed/simple; bh=prHeNq6+IwMAosGmXVhGjyfETY3x+V4ffWZ3SpwWAIs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XBCw8qXUOsiRyeg1c5rmnrU+HhXCixOA+Yc6EKdPDA2VOLtgdwxlPZTTW+QKXV8nq2VIjVz1MljV+AsuGs2hVc16BsMKCRByGWz4WbZMWPY8lO8LO5l/n4HTDv9ujql+6Mq1feuFj7QL0lTYmtE4wX1OqUs0Zr+0BAx6jz6T/Zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CY1v8ejj; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CY1v8ejj" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so3580207f8f.2 for ; Tue, 23 Dec 2025 23:54:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766562883; x=1767167683; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WZrIGbDjUMc3J6sIbF34jJNhsrhnGJpTC/Mf9dBpW/Q=; b=CY1v8ejjHPxBnY9hF58+btxsz0V8xZGv1nzmOTF9IokLb7D+PwCgogVxV+0hdcxcCL sgloFcjxD8MDokDL1TnOOionvpNzf/5s/FnjEp66ED6Im6yLA4Hwu6wF7Zf+nMlZfZpQ aDq47cdUvCtze7z+pWdguWp+rg5/JiFsvjeKQFvdyx2o0JWfzKybdz8loSvIRhsFTemL diNByyfSZfCwYiLGWuttkhSYNxut/8qZyub75d9RfLXj20mC2HipMB45cxSJoQUjkjn/ F05GA0TKKxmw0Z0L2NLBS5u7718yTn6NXE6zqlSj9L5c/8ViXrFR0bZMOmR5AjjH7zBC L5yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766562883; x=1767167683; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WZrIGbDjUMc3J6sIbF34jJNhsrhnGJpTC/Mf9dBpW/Q=; b=cetAxG40B2fZTCSD2SdzOLaB05818LcLs6UW2GVk/jsYPcXfJSKzNKK5r+B6LGp4+i RvQNdx2WvCPEc0ey0f5xzRilRZiyDfnJeOpqP6/jxfcuHaq4byGr+/fzhi7mWCFoMkxk +Csrxcyte0OwmFk70U+Rx4fkz0IS37buN2yIcVbjWwWOUPLjLEh3Uvlpak0KMwOidb9H gCsMNCfoYK6u7+RNiDyfdIUALl2a5oLo+F0qNyeaA/IH6yxkjBwkIrCD+PkGFyXE8ukL 9koovj313nRLTF9b6iLfg/hrrpPv6tIqEpeyjL99yWwh5M4bFTlODsBlWLXkhf3DZc26 Q5vw== X-Forwarded-Encrypted: i=1; AJvYcCWyV4Go0y4Fy/HuqnKdT5hJ62PRUfFvW7D29PafkI0OChiThVDvdKqlH3bmBGLMyPPbTN8+uuyutorF5cU=@vger.kernel.org X-Gm-Message-State: AOJu0YzLpbZ53pbGuCOzMstrt16eQrlLiikhbM4UZtN4b+a0A8C7mLcb eOzSbKuXz7M4www4J4YIhUxmA1k09BjBM47uASDdUpF+un21VPCze7YEv1TzjIVkrRg= X-Gm-Gg: AY/fxX4AdbCojwmWkcfor60jJfcVt2+b+uQPXcKd/m50iUaiX01LSJXzkOjDptHV+wW mxtQDHeFM7bMFU/qaYRTb9t4lckcDn+YCw6yS1Cmh4LCHxTc9lFTygG/J73BPjziKS0cpl4f9Gu XKtCiYsIS+gxQTMjgndlRiVzOaGxvU78rBmXKe55cZu9TNMZ+iOnJT36T0GH3VGQpiYyA3zqvJs 8DeNF0YhJrIrYFllfgxNRw3+463REE1fSaGKDgYP5pIaKUwe3oiODvLOTr8Ca0RO+drLvx6fZ7m ruIEqAdqFt8EKzHRrbHaUtRjn7JWjwKR+AJ0UWmG97sH5LKbdk2+5gUdnAEpBjYROYsVsT5yXIi MXeDF/vJd3QoSSsKKl2wCucP78D2F3pUo+yKXtDLnMdIL+XuqSuQP5HFDd2fyLqrQ0/A2q++bl6 B+quNtPiqnnik82koR X-Google-Smtp-Source: AGHT+IECNLFLhXkd5CDpgr63GCQOyj7vf3ddOYc1QU6NGh9n1MI1zpPSZMz6dgba6MyyIQX9ZAgPJg== X-Received: by 2002:a05:6000:25ca:b0:431:5d2:4526 with SMTP id ffacd0b85a97d-4324e4c9df3mr19740323f8f.19.1766562882584; Tue, 23 Dec 2025 23:54:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1aef7sm32714761f8f.7.2025.12.23.23.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 23:54:42 -0800 (PST) Date: Wed, 24 Dec 2025 10:54:38 +0300 From: Dan Carpenter To: "Christophe Leroy (CS GROUP)" Cc: Haoxiang Li , ioana.ciornei@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Su Hui Subject: Re: [PATCH] bus: fsl-mc: fix an error handling in fsl_mc_device_add() Message-ID: References: <20251222074958.992911-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Dec 23, 2025 at 04:34:44PM +0100, Christophe Leroy (CS GROUP) wrote: > > > Le 22/12/2025 à 08:49, Haoxiang Li a écrit : > > If device_add() fails, call put_device() to drop the device > > reference and do the cleanp. > > > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/ > > Signed-off-by: Su Hui > > Signed-off-by: Haoxiang Li > > --- > > drivers/bus/fsl-mc/fsl-mc-bus.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > > index 25845c04e562..90a2107a9905 100644 > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > @@ -896,7 +896,8 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc, > > dev_err(parent_dev, > > "device_add() failed for device %s: %d\n", > > dev_name(&mc_dev->dev), error); > > - goto error_cleanup_dev; > > + put_device(&mc_dev->dev) > > This change has obviously not been tested, not even built. > Yeah, it doesn't build. > And by droping the goto, the kfree() are not done anymore, leaking > mc_bus/mc_dev p kzalloced areas. > Calling put_device() triggers fsl_mc_device_release() which does the free. regards, dan carpenter > > + return error; > > } > > dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev));