From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28630331213 for ; Wed, 24 Dec 2025 12:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766578257; cv=none; b=ZiFOzjA2Qu6rlDDsfFZpJ0YnmSoiXRUIifW/l2HVveb/EvxnJ43/wePffY5eju2jU3aDt3+KnMfZjCcg8z3fI7UiPlCg30Gkb0Rkl7cBCu34vxlnyj0vsw15A82MquYLPij3Ob7xW1uxft4OCJ5KhPnCrtEGPvPgTVUZa3Nyb8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766578257; c=relaxed/simple; bh=gaEk/FozvI7csbLOEOALR18mmERKfPTC/DiJmFjnlqY=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WJf385AgO/dEfpyuXAx0p3BJ3xQslqcgpqvmla77Jg1tsL1D0FTZg1iXdbZxAh3dP4wzTeX8b/A1wFrA/Qxy8xw/YS2vqQKQUM1UTcco31pSoof8Ypqe08FFtp2vDc2surOoLA20mdagQG2uO8XHGRDdHwOmQjqrx5uWF9EkIXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c/s3Vy5V; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c/s3Vy5V" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7bab7c997eeso6739973b3a.0 for ; Wed, 24 Dec 2025 04:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766578255; x=1767183055; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=amDWvZilcUNQCRnb9FMww/04o+Z50BC4wdV0XDGsTVQ=; b=c/s3Vy5Vd+7qObHpx4EwOMQOPh/GAUz7tORee1wbImWh7g4HNz48nvElgUfbTNJbU8 XXAdn2tvkqaGiNtVulQHzfUxYf983hP+NcFdKTOYrxncmpp3OuJwjg0ahxStug0HqkSl q1OUVUqLVgfXi45NtDYiItVeQe14oG4TqSE7sf2ckbOE40t09R7daDduJwzy8tgboyLz S9lC7UPZnwHvlSKEaoEQk9Z5DCgtshiQUo403PY0sqZNcFDYOFaW6yLctZyxYu9NCCkp P8N/uO6938K3rAAmiFbencE7K6A6HE9f1LtV5zMYhk5KQ/zeEP+Fol+rx5gDKhtkBJvG IEpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766578255; x=1767183055; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=amDWvZilcUNQCRnb9FMww/04o+Z50BC4wdV0XDGsTVQ=; b=sxre3evHlbzOlntbx/E512v5uZaUmz2w7Bxc3z8xj7ghJiCX0Xf7y/cWEObd1JPedA /5/gR0QIb+c/zMpxC4mkcnDG1urcMPNpz3u3jOIT0fc6IhQQdj8L8ToMHzDGLzovG21G w88vzlXfXObjrTT21rbsbuSHHQ/ju5nX4hHOlOqXijS/qNl3P+BPBK7iVVks9kDSNhvJ moZp08Yu9L0nXktn1lZYBJvv2/LUqZ2QAMm5/j0Iih5LilYYqlBQvXcETrGl1FDMptr3 F6GjGfBo2fzG51rBulmX0rq2/zhCYmxKNvYv5B6lX0p5BRgoIJSrJp1e8MrQg2aXimlb 0iNg== X-Forwarded-Encrypted: i=1; AJvYcCXHw+XMwFfEOqcVg5pr4LPo3h7hg6FXfYQNx7vj7/8McsnKdGcpDuIUUReC/N4QWNFmsNukEuQg7mlkW90=@vger.kernel.org X-Gm-Message-State: AOJu0YzVUevXSEIc7Z0wee3EuQTFJlcqKEW+m22u0XZD2sIiIns/p4OQ MpwmmcnwouzpKZPLpTkU6uDHG1ZqdqPZqBKAVA6A4P4e5hOKApX3d8Bp X-Gm-Gg: AY/fxX6fqR9E04T0QhKteM4Fh5X4Ju3KzykY6tAl6r9KbhjbK5FuPErYyeyI8wfsedw w8W70cW71kHznfQU0y+K33ZQ2n+Jk1IroqdWcR3FwwPn66DCo3qiiso4XWH5/bpu4mJcmM/toUW 7dD96ED/jAXMnn7v3ybH1tIctBr/yN+E2+y2petCG160gr+eKKibyktCaBM9S8xP8LgSTxdzqOY K1loQrv6mI7Oz2hQM508gF7TM92CY1IWTtqh/r3adwcBYfLgZm1sGhrKulQiPUlxIeCTNdy7X9V w/sGGunOH9iUMado3jTTKaZ0TnUF+EsD4z1bk1JJVyG0AGHJEmp05XA6BSvpUKdKJDQXi3MB5n5 kJK76g6C+hGEFayKnkeMFZQNDFylGrBEL0CB0HcxgM+kVoZanRrK1H1pA/kYfI+6mKSGPqaRvnv zuITE= X-Google-Smtp-Source: AGHT+IGMW8f9KARCRCORQsU4PNhY2Xois2Gs10c6eZiOv5H3XYoy7LVCzNTRaQVZrN60Cq6oSWPrPw== X-Received: by 2002:a05:6a00:a90e:b0:7e8:4471:ae79 with SMTP id d2e1a72fcca58-7ff68245f80mr14622236b3a.69.1766578255361; Wed, 24 Dec 2025 04:10:55 -0800 (PST) Received: from localhost ([2a12:a304:100::105b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e0a1a2asm16666372b3a.41.2025.12.24.04.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 04:10:54 -0800 (PST) Date: Wed, 24 Dec 2025 20:10:49 +0800 From: Jinchao Wang To: mathieu.desnoyers@efficios.com, Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] exec: do not call sched_mm_cid_after_execve() on exec fail Message-ID: References: <20251218032327.199721-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218032327.199721-1-wangjinchao600@gmail.com> On Thu, Dec 18, 2025 at 11:23:23AM +0800, Jinchao Wang wrote: Hi, mathieu Please review this patch for mm_cid. The syzbot test failure occurs because the syz-repro breaks the system state, causing all user commands to fail. Actually the syz-rero can only trigger a panic or error. The broken system can be recovered by resetting binfmt_misc with: echo 0 > /proc/sys/fs/binfmt_misc/status Thanks. Cc: mathieu.desnoyers@efficios.com > sched_mm_cid_after_execve() is called from the failure path > of bprm_execve(). At that point exec has not completed successfully, > so updating the mm CID state is incorrect and can trigger a panic, > as reported by syzbot. > > Remove the call from the exec failure path. > > Cc: stable@vger.kernel.org > Reported-by: syzbot+9ca2c6e6b098bf5ae60a@syzkaller.appspotmail.com > Signed-off-by: Jinchao Wang > --- > fs/exec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/exec.c b/fs/exec.c > index 9d5ebc9d15b0..9044a75d26ab 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -1773,7 +1773,6 @@ static int bprm_execve(struct linux_binprm *bprm) > if (bprm->point_of_no_return && !fatal_signal_pending(current)) > force_fatal_sig(SIGSEGV); > > - sched_mm_cid_after_execve(current); > rseq_force_update(); > current->in_execve = 0; > > -- > 2.43.0 >