From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EB5A18A6A7 for ; Wed, 24 Dec 2025 13:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766582404; cv=none; b=ZOJCuDOKNw3nvdCfmVKU456NE5Vxm4cEnShfBiRjzH5uan94tXz2D2LN8CNVc7GxLBYXr7qRRChZAWXPYLKl5SvS+NOpwcTRgWu6PXZtKghDQk/yu85LCkVIfkxLRqafpu7Xew0gnx+LMP7o+/ATwb53IkSBUQU32IRdAFpohnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766582404; c=relaxed/simple; bh=Z1vwCpy3xpWeWvKjBKC069x7b13vg9BDJ+FjLOjAjPg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pTpAoQJzAFM4sZBakUpcSJ3LbQc/wHTwWCMj3fiztEmdh1C+MLEM/N6y7n2U61ANnbkf0PrlIvLZtJ0WirBI6IL0id9o1s5DmHWa/wLOIMDP6qTEbDrBXuxqB9dHN2ecv2IZSIGfqISseOGNcaXIBaoeFrmfu8u7wXgMUw8XurU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EpkkCD/9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rWi8zJs/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EpkkCD/9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rWi8zJs/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766582401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pnyVa0gL9PqRyxoGgad9ZgIf7TrhLDmrnLDL5gmFISs=; b=EpkkCD/9s9oan/5rFZgSSmjoFTPKV3MIDFh13QLN/4QY9N4sWw27pYCy4Z+Iuk1020WrzW V7odbDxd3aMwCivxTxxFDxyV4YuVjK54mDPIYkTq5/VPTq7OddzmyYehEAiM0tq/sLn5nw EpO1e7ElIwQjixX4gjCz/SzxkJ8dpBU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-xYfXrXkNPf6jllGJmaEc7g-1; Wed, 24 Dec 2025 08:18:22 -0500 X-MC-Unique: xYfXrXkNPf6jllGJmaEc7g-1 X-Mimecast-MFC-AGG-ID: xYfXrXkNPf6jllGJmaEc7g_1766582301 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477cf25ceccso67635005e9.0 for ; Wed, 24 Dec 2025 05:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766582300; x=1767187100; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pnyVa0gL9PqRyxoGgad9ZgIf7TrhLDmrnLDL5gmFISs=; b=rWi8zJs/stENPkTwFR5cuv8ZF5kDJpVB37mXM86ZyFmJ0Ri8qE87MoqIm3IRLYvpZ6 uGzwz1XH+6wW+LK4PqK60uEN1Qdnn037FfyYwErehbKdxnaSl6X9uonwPQXEZl+w6BuV 3NKzdxuyTFvO2Yr/0fi4Du7qHEyJhVZWSGtFSzwRQiN37JyPXy31cidXqO3+co7wrUVJ SX4H7Uch3T9Nen3lBW0vaSXuKTzvxPSdLAap+FD+J8AjaGc2+AzlqS5DgHGp1rrXxE4I aY0Um2QLwyfWMmAUVqjTUganSRV5pJjQEkXncdY+RDyFK9MttjTe9TSxnotX9KbRWJYA CftQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766582300; x=1767187100; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pnyVa0gL9PqRyxoGgad9ZgIf7TrhLDmrnLDL5gmFISs=; b=tTgT4Ce5pOdfmpLGhy+O056cU7qWRfpLtoeb5yR/HRzewv8vLRsFTrKGUC0lmKCq+z L+o2FVbktuvyuBL1DB1+ozEtgmKfJPE1SOS9CTJpIJYiLgDwtW+Wv8tnli27qNPCc8EY WwISig0tOyIgcwxpApPEgeSDzQtY+juqRNF5Ua9U6ag1wc8WtyXQGCDknr+mRXVvA3Mk 4XwbHeRM613GbWai96zVyfNgsO2TScyp1ytij1r4U/+N7U/3WNuAkaQCuomejOvmLVYE 123tlu29/zWJNJ0iLOAxptYraoHb30/K+apYHmYYZqLLi706PMwYe1xf6Kuda3WJwCjn u6xQ== X-Forwarded-Encrypted: i=1; AJvYcCUBk8Gs8Zgm4vJ8WgriizSWb3g5oj8PeEcwkq0VTtpj9onMyq/zEZdXrRRgI7mUnNvIZjI+BDmal8oEuYU=@vger.kernel.org X-Gm-Message-State: AOJu0YxL9NVXBcCzTj3+LafzlXBZnJ+rhKnvi4q28IaQWL4a1S2Kk4wh wR1juGpl4USGNqERBHe0runNoWtDn0W5sJqSa6UBvQ2Lrx3xouP5iDDWdXq5DlllT6+Gsdtrzpn Ewy7ajxyGOA4F9wXHNVb560T236fsxcLZpeGptRLinCuoWE5ALIWr8KmdHpbMOF/i2Q== X-Gm-Gg: AY/fxX5VpmV+dj/8u9jcMu6QtzSwBqJnMlk+n3o6pyNx6XTRw6wOE2d5TqFDNtq64h0 B1udrH33jol0FzSr+4N5tfv9u5UQj0dbN7UW3OZSd7GhyRuVM6w1dndthBQz9S5JIDNQ2KRAn5L XG7Y8FXWxTSHbpt3TmdKSscPxz7DgaGt2Po6cKBF7ChurT5N4rCmmWT0rgDJ7QK5SnO5m0soUBc zaXx4a4elNsAHDZCY0Gn/bnqvk44CydzIbkCCVL1kYR06KfMZzlJr/N2s0nktZ6nM5pqDBtPzZZ ThuFuws+j+fGELe5hFnc5fwsd0l6fPLIjPbBYPzkBj+iOcZ0x5vV+dWk3zzVpW0ckIjWsII1Ons a/ZHpw+LFLTjbJJk= X-Received: by 2002:a05:600c:1f84:b0:477:5c58:3d42 with SMTP id 5b1f17b1804b1-47d34de4cb7mr63019755e9.10.1766582300586; Wed, 24 Dec 2025 05:18:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/SlkuvhiTEvzYbTpBDDuJpHJEzzSjm3eiNJ/Fe6ZgvJBNGCeEN2QpRSXh5vQwgRwhpvCKLg== X-Received: by 2002:a05:600c:1f84:b0:477:5c58:3d42 with SMTP id 5b1f17b1804b1-47d34de4cb7mr63019525e9.10.1766582300181; Wed, 24 Dec 2025 05:18:20 -0800 (PST) Received: from leonardi-redhat ([176.206.16.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa64cesm34326729f8f.35.2025.12.24.05.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 05:18:19 -0800 (PST) Date: Wed, 24 Dec 2025 14:18:17 +0100 From: Luigi Leonardi To: Stefano Garzarella Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] vsock/test: add a final full barrier after run all tests Message-ID: References: <20251223162210.43976-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20251223162210.43976-1-sgarzare@redhat.com> On Tue, Dec 23, 2025 at 05:22:10PM +0100, Stefano Garzarella wrote: >From: Stefano Garzarella > >If the last test fails, the other side still completes correctly, >which could lead to false positives. > >Let's add a final barrier that ensures that the last test has finished >correctly on both sides, but also that the two sides agree on the >number of tests to be performed. > >Signed-off-by: Stefano Garzarella >--- > tools/testing/vsock/util.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c >index d843643ced6b..9430ef5b8bc3 100644 >--- a/tools/testing/vsock/util.c >+++ b/tools/testing/vsock/util.c >@@ -511,6 +511,18 @@ void run_tests(const struct test_case *test_cases, > > printf("ok\n"); > } >+ >+ printf("All tests have been executed. Waiting other peer..."); >+ fflush(stdout); >+ >+ /* >+ * Final full barrier, to ensure that all tests have been run and >+ * that even the last one has been successful on both sides. >+ */ >+ control_writeln("COMPLETED"); >+ control_expectln("COMPLETED"); >+ >+ printf("ok\n"); > } > > void list_tests(const struct test_case *test_cases) >-- >2.52.0 > LGTM! Reviewed-by: Luigi Leonardi