From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B05D33375CD; Tue, 6 Jan 2026 13:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767706836; cv=none; b=pgUBMMlC68D2yd6ZdK9ZDmcstQank6i+kc7vl2IAfCEalOpOg9pgqEnjvGop/xymVb5s3ILxMlTrtwUW/h5+/fErQcn5j4rZGntov4rWeVlrEbQUHp31xvTsOPFBUJ66PUdGYkudy7fyLNn2tyAi3B1kXSBn4tX9yvGUrCeryL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767706836; c=relaxed/simple; bh=riYTKJoFQ1Amngen0HhfQApbfcrmFFwHT6saLPWenhg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LxKIvuKSh9bsY+tZnvXYnwJqi90/AXcRxfDQoTGWcsSGUKFkdcQsx8JlALIqmIlvKl4AjftaZfJZc86/kvtoiBxWQsSiOF7UNpisFYgHpjaTy6ijU6R3cfW+CWf0sscRzgH0jNmImpaLuZoKYiXZQlbio/2ujD0xDn8/UXBy1qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=foss.arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA5E7497; Tue, 6 Jan 2026 05:40:24 -0800 (PST) Received: from bogus (e133711.arm.com [10.1.197.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D1043F6A8; Tue, 6 Jan 2026 05:40:25 -0800 (PST) Date: Tue, 6 Jan 2026 13:40:23 +0000 From: Sudeep Holla To: Jens Wiklander Cc: Alexandre Belloni , Sudeep Holla , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Corbet , Sumit Garg , Olivia Mackall , Herbert Xu , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , Sumit Garg , Ilias Apalodimas , Jan Kiszka , Christophe JAILLET , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Michael Chan , Pavan Chebbi , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E. Hallyn" , Peter Huewe , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Cristian Marussi , arm-scmi@vger.kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 00/17] tee: Use bus callbacks instead of driver callbacks Message-ID: References: <20251218135332f323fa91@mail.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 05, 2026 at 10:16:09AM +0100, Jens Wiklander wrote: > Hi, > > On Thu, Dec 18, 2025 at 5:29 PM Jens Wiklander > wrote: > > > > On Thu, Dec 18, 2025 at 2:53 PM Alexandre Belloni > > wrote: > > > > > > On 18/12/2025 08:21:27+0100, Jens Wiklander wrote: > > > > Hi, > > > > > > > > On Mon, Dec 15, 2025 at 3:17 PM Uwe Kleine-König > > > > wrote: > > > > > > > > > > Hello, > > > > > > > > > > the objective of this series is to make tee driver stop using callbacks > > > > > in struct device_driver. These were superseded by bus methods in 2006 > > > > > (commit 594c8281f905 ("[PATCH] Add bus_type probe, remove, shutdown > > > > > methods.")) but nobody cared to convert all subsystems accordingly. > > > > > > > > > > Here the tee drivers are converted. The first commit is somewhat > > > > > unrelated, but simplifies the conversion (and the drivers). It > > > > > introduces driver registration helpers that care about setting the bus > > > > > and owner. (The latter is missing in all drivers, so by using these > > > > > helpers the drivers become more correct.) > > > > > > > > > > v1 of this series is available at > > > > > https://lore.kernel.org/all/cover.1765472125.git.u.kleine-koenig@baylibre.com > > > > > > > > > > Changes since v1: > > > > > > > > > > - rebase to v6.19-rc1 (no conflicts) > > > > > - add tags received so far > > > > > - fix whitespace issues pointed out by Sumit Garg > > > > > - fix shutdown callback to shutdown and not remove > > > > > > > > > > As already noted in v1's cover letter, this series should go in during a > > > > > single merge window as there are runtime warnings when the series is > > > > > only applied partially. Sumit Garg suggested to apply the whole series > > > > > via Jens Wiklander's tree. > > > > > If this is done the dependencies in this series are honored, in case the > > > > > plan changes: Patches #4 - #17 depend on the first two. > > > > > > > > > > Note this series is only build tested. > > > > > > > > > > Uwe Kleine-König (17): > > > > > tee: Add some helpers to reduce boilerplate for tee client drivers > > > > > tee: Add probe, remove and shutdown bus callbacks to tee_client_driver > > > > > tee: Adapt documentation to cover recent additions > > > > > hwrng: optee - Make use of module_tee_client_driver() > > > > > hwrng: optee - Make use of tee bus methods > > > > > rtc: optee: Migrate to use tee specific driver registration function > > > > > rtc: optee: Make use of tee bus methods > > > > > efi: stmm: Make use of module_tee_client_driver() > > > > > efi: stmm: Make use of tee bus methods > > > > > firmware: arm_scmi: optee: Make use of module_tee_client_driver() > > > > > firmware: arm_scmi: Make use of tee bus methods > > > > > firmware: tee_bnxt: Make use of module_tee_client_driver() > > > > > firmware: tee_bnxt: Make use of tee bus methods > > > > > KEYS: trusted: Migrate to use tee specific driver registration > > > > > function > > > > > KEYS: trusted: Make use of tee bus methods > > > > > tpm/tpm_ftpm_tee: Make use of tee specific driver registration > > > > > tpm/tpm_ftpm_tee: Make use of tee bus methods > > > > > > > > > > Documentation/driver-api/tee.rst | 18 +---- > > > > > drivers/char/hw_random/optee-rng.c | 26 ++---- > > > > > drivers/char/tpm/tpm_ftpm_tee.c | 31 +++++--- > > > > > drivers/firmware/arm_scmi/transports/optee.c | 32 +++----- > > > > > drivers/firmware/broadcom/tee_bnxt_fw.c | 30 ++----- > > > > > drivers/firmware/efi/stmm/tee_stmm_efi.c | 25 ++---- > > > > > drivers/rtc/rtc-optee.c | 27 ++----- > > > > > drivers/tee/tee_core.c | 84 ++++++++++++++++++++ > > > > > include/linux/tee_drv.h | 12 +++ > > > > > security/keys/trusted-keys/trusted_tee.c | 17 ++-- > > > > > 10 files changed, 164 insertions(+), 138 deletions(-) > > > > > > > > > > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 > > > > > -- > > > > > 2.47.3 > > > > > > > > > > > > > Thank you for the nice cleanup, Uwe. > > > > > > > > I've applied patch 1-3 to the branch tee_bus_callback_for_6.20 in my > > > > tree at https://git.kernel.org/pub/scm/linux/kernel/git/jenswi/linux-tee.git/ > > > > > > > > The branch is based on v6.19-rc1, and I'll try to keep it stable for > > > > others to depend on, if needed. Let's see if we can agree on taking > > > > the remaining patches via that branch. > > > > > > 6 and 7 can go through your branch. > > > > Good, I've added them to my branch now. > > This entire patch set should go in during a single merge window. I > will not send any pull request until I'm sure all patches will be > merged. > > So far (if I'm not mistaken), only the patches I've already added to > next have appeared next. I can take the rest of the patches, too, but > I need OK for the following: > [...] > > Sudeep, you seem happy with the following patches > - firmware: arm_scmi: optee: Make use of module_tee_client_driver() > - firmware: arm_scmi: Make use of tee bus methods > OK if I take them via my tree, or would you rather take them yourself? > I am happy if you want to take all of them in one go. I think I have already acked it. Please shout if you need anything else from me, happy to help in anyway to make it easier to handle this change set. -- Regards, Sudeep