From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1044364E8A; Tue, 6 Jan 2026 17:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722028; cv=none; b=aq/GxQc1A/PuE9Ilrsb6sz65OEWFviR3XHNe+bjStWq9uvVBB10vYL2Czm75lRu3fJdZWq2pkBpP9nXEO+O2n5Xo4rcPMKJQ1GH2oUBdf4JdGYLMrn+h0tlgDp72ilfB8MyQP3XXU24IRcwyKwFWiVPA0iErDVvmF43DcFReszY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722028; c=relaxed/simple; bh=LKWPitbcGrd3Rpd+vyUqksGir5Ob6WW1z1gEt7mAFzk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DRZKTaBVFJiM6XOZYX6SF9fZSX4+r/h/LG1z8L9mx9LxzlAYvGDLvmWexnpzm+00kuXVdByJfyKQv/ZN+lBJR8f79BWlOBir7x/ZfpHTpaI2RXx1ewNFtl2QP7hAZ5+5iQPZbBQEjXztMAbFvrUugYx5oX19i6AqcSSWBrq9Bns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=nAl+7afP; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="nAl+7afP" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NeRc65GgtPKha3VBPc75CE2yju7Fvs2u23mVuFJS94M=; b=nAl+7afPDn0GKI0lv6drLUgXh5 Sv+T406urwiNXaZ5hXTQCgxv6OmLgra0PRGIpHxfhfoSnpX/f4WCivJiWex/WzHTw0jfrzZouHZpd Z0PWml4rxKHQQu7TOoUZiHUQ9g5WKg6sYxuf++B/H9YVH7a2k42sh7li+vFWctRUb2DpxrhnGQVMl 2e6a6/yRQ95N5sPnwEBFsV80q1o1eMgf3wkyY4qdAMUR1Ts9T2K82mpkCMWsmzPt4A5yFst5CJKKu Y3rWDk8wPcVBrUAJz9iGSgDrP3ddxwXwieutAolLMp0RN4Mk/sze2Jni8fQvf1mEM8DQecClK95Hk gZnwDj+Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56880) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vdBFN-000000000sa-1PL4; Tue, 06 Jan 2026 17:53:33 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vdBFK-000000000c6-0NYK; Tue, 06 Jan 2026 17:53:30 +0000 Date: Tue, 6 Jan 2026 17:53:29 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Simon Horman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors Message-ID: References: <36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org> Sender: Russell King (Oracle) On Tue, Jan 06, 2026 at 05:14:57PM +0000, Daniel Golle wrote: > +static inline int __mdiodev_c45_write(struct mdio_device *mdiodev, u32 devad, > + u16 regnum, u16 val) > +{ > + return __mdiobus_c45_write(mdiodev->bus, mdiodev->addr, devad, regnum, > + val); Something doesn't look right here - missing a couple of spaces to correctly align? I suspect checkpatch would spot it? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!