* Re: [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol
2025-12-28 19:06 [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol Randy Dunlap
@ 2026-01-06 17:57 ` Abhishek Pandit-Subedi
2026-01-06 18:20 ` Benson Leung
2026-01-09 13:15 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Abhishek Pandit-Subedi @ 2026-01-06 17:57 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Pavan Holla, Łukasz Bartosik,
Greg Kroah-Hartman, Jameson Thies, Andrei Kuchynski,
chrome-platform, Heikki Krogerus, linux-usb
On Sun, Dec 28, 2025 at 11:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> EXTCON_TCSS_CROS_EC isn't used anywhere else in the kernel tree,
> so drop it from this Kconfig file.
>
> (unless it should be EXTCON_USBC_CROS_EC ?)
Yes, it should have been EXTCON_USBC_CROS_EC. This was eventually
deprecated in favor of using the Type-C connector class and the power
supply class.
Devices that support UCSI will not support the extcon driver (i.e. in
firmware) so removing this entirely for this driver is likely a safe
change.
>
> Fixes: f1a2241778d9 ("usb: typec: ucsi: Implement ChromeOS UCSI driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Pavan Holla <pholla@chromium.org>
> Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Cc: Łukasz Bartosik <ukaszb@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jameson Thies <jthies@google.com>
> Cc: Andrei Kuchynski <akuchynski@chromium.org>
> Cc: chrome-platform@lists.linux.dev
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: linux-usb@vger.kernel.org
>
> drivers/usb/typec/ucsi/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20251219.orig/drivers/usb/typec/ucsi/Kconfig
> +++ linux-next-20251219/drivers/usb/typec/ucsi/Kconfig
> @@ -73,7 +73,6 @@ config CROS_EC_UCSI
> tristate "UCSI Driver for ChromeOS EC"
> depends on MFD_CROS_EC_DEV
> depends on CROS_USBPD_NOTIFY
> - depends on !EXTCON_TCSS_CROS_EC
> default MFD_CROS_EC_DEV
> help
> This driver enables UCSI support for a ChromeOS EC. The EC is
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol
2025-12-28 19:06 [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol Randy Dunlap
2026-01-06 17:57 ` Abhishek Pandit-Subedi
@ 2026-01-06 18:20 ` Benson Leung
2026-01-09 13:15 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Benson Leung @ 2026-01-06 18:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Pavan Holla, Abhishek Pandit-Subedi,
Łukasz Bartosik, Greg Kroah-Hartman, Jameson Thies,
Andrei Kuchynski, chrome-platform, Heikki Krogerus, linux-usb
[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]
On Sun, Dec 28, 2025 at 11:06:03AM -0800, Randy Dunlap wrote:
> EXTCON_TCSS_CROS_EC isn't used anywhere else in the kernel tree,
> so drop it from this Kconfig file.
>
> (unless it should be EXTCON_USBC_CROS_EC ?)
I concur with abhishekpandit@chromium.org. It looks like this was a typo at
first, but removing the depends should be fine.
>
> Fixes: f1a2241778d9 ("usb: typec: ucsi: Implement ChromeOS UCSI driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> Cc: Pavan Holla <pholla@chromium.org>
> Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Cc: Łukasz Bartosik <ukaszb@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jameson Thies <jthies@google.com>
> Cc: Andrei Kuchynski <akuchynski@chromium.org>
> Cc: chrome-platform@lists.linux.dev
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: linux-usb@vger.kernel.org
>
> drivers/usb/typec/ucsi/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20251219.orig/drivers/usb/typec/ucsi/Kconfig
> +++ linux-next-20251219/drivers/usb/typec/ucsi/Kconfig
> @@ -73,7 +73,6 @@ config CROS_EC_UCSI
> tristate "UCSI Driver for ChromeOS EC"
> depends on MFD_CROS_EC_DEV
> depends on CROS_USBPD_NOTIFY
> - depends on !EXTCON_TCSS_CROS_EC
> default MFD_CROS_EC_DEV
> help
> This driver enables UCSI support for a ChromeOS EC. The EC is
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol
2025-12-28 19:06 [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol Randy Dunlap
2026-01-06 17:57 ` Abhishek Pandit-Subedi
2026-01-06 18:20 ` Benson Leung
@ 2026-01-09 13:15 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2026-01-09 13:15 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Pavan Holla, Abhishek Pandit-Subedi,
Łukasz Bartosik, Greg Kroah-Hartman, Jameson Thies,
Andrei Kuchynski, chrome-platform, linux-usb
Sun, Dec 28, 2025 at 11:06:03AM -0800, Randy Dunlap kirjoitti:
> EXTCON_TCSS_CROS_EC isn't used anywhere else in the kernel tree,
> so drop it from this Kconfig file.
>
> (unless it should be EXTCON_USBC_CROS_EC ?)
>
> Fixes: f1a2241778d9 ("usb: typec: ucsi: Implement ChromeOS UCSI driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Cc: Pavan Holla <pholla@chromium.org>
> Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Cc: Łukasz Bartosik <ukaszb@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jameson Thies <jthies@google.com>
> Cc: Andrei Kuchynski <akuchynski@chromium.org>
> Cc: chrome-platform@lists.linux.dev
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: linux-usb@vger.kernel.org
>
> drivers/usb/typec/ucsi/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20251219.orig/drivers/usb/typec/ucsi/Kconfig
> +++ linux-next-20251219/drivers/usb/typec/ucsi/Kconfig
> @@ -73,7 +73,6 @@ config CROS_EC_UCSI
> tristate "UCSI Driver for ChromeOS EC"
> depends on MFD_CROS_EC_DEV
> depends on CROS_USBPD_NOTIFY
> - depends on !EXTCON_TCSS_CROS_EC
> default MFD_CROS_EC_DEV
> help
> This driver enables UCSI support for a ChromeOS EC. The EC is
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread