From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF15C4C6C for ; Tue, 6 Jan 2026 21:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767736524; cv=none; b=dCYFc6TD5dJGyKWMcEuKYBklnQuDPjGhXjAorpK9/441Zcbm2JSPavKMJonkoS4lujHAThNc5VOhHToJct0DC4+7GZf55ogan/8k8gscmq7MhRT2axHGRJDpmP+///MZ9WumhjZJV15SoF0EPlz+HUYW8frZd5XChi/mcbDbwn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767736524; c=relaxed/simple; bh=JyzU6uS4mnZa2qbjEWrlcoUz8mHSgMv2SxAzc1MpBhY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VEuC4+oPC7uMCom9bIAjrLZ3Zy7NYaxoSwLWIi1E0EKqXxjBpZZQdUuQzAcGBingjerwDrqdS3u34lA58E3rt1K/pc0pgwnOaHyVQaQFSHtDKg0Y/WvmKpaaL3q5RXCwJYgY666zH+2ESt6c4/59jPv9LWq2UnigNR4PfMsldOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NLgNpTHA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NLgNpTHA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767736521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kx5/XXbX9+2VkaOTBFhbIcQfuW1+G4RScSpCCrEiFHI=; b=NLgNpTHAc7TsLQs6Si4ZaP0lzO3RxSlJbCUm/5dzF59cxNuwst+w668x0gxUlEqzUbsNme D/ZrtRkqWlAUzy/0f5Q4V2QCYDiI3aNh0fYe44mKhicxR3XJxL5kX+nx8jqAFTFgxPtLdX 7/r3eESoXmwI76FAfbzzPc3UX8eKQEM= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-gRM6ROJSOkeQCeUJDznDEw-1; Tue, 06 Jan 2026 16:55:18 -0500 X-MC-Unique: gRM6ROJSOkeQCeUJDznDEw-1 X-Mimecast-MFC-AGG-ID: gRM6ROJSOkeQCeUJDznDEw_1767736517 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 05B3B195FCDF; Tue, 6 Jan 2026 21:55:17 +0000 (UTC) Received: from redhat.com (unknown [10.22.88.156]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E8D5718004D8; Tue, 6 Jan 2026 21:55:14 +0000 (UTC) Date: Tue, 6 Jan 2026 16:55:12 -0500 From: Joe Lawrence To: Mikulas Patocka Cc: Josh Poimboeuf , Peter Zijlstra , Petr Mladek , linux-kernel@vger.kernel.org Subject: Re: [PATCH] objtool: fix compilation failure with the x32 toolchain Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Tue, Jan 06, 2026 at 12:13:15PM +0100, Mikulas Patocka wrote: > When using the x32 toolchain, compilation fails because the printf > specifier "%lx" (long), doesn't match the type of the "checksum" variable > (long long). Fix this by changing the printf specifier to "%llx" and > casting "checksum" to unsigned long long. > > Signed-off-by: Mikulas Patocka > Fixes: a3493b33384a ("objtool/klp: Add --debug-checksum= to show per-instruction checksums") > > --- > tools/objtool/include/objtool/warn.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6/tools/objtool/include/objtool/warn.h > =================================================================== > --- linux-2.6.orig/tools/objtool/include/objtool/warn.h 2025-12-31 20:10:31.000000000 +0100 > +++ linux-2.6/tools/objtool/include/objtool/warn.h 2025-12-31 20:14:15.000000000 +0100 > @@ -152,8 +152,8 @@ static inline void unindent(int *unused) > if (unlikely(insn->sym && insn->sym->pfunc && \ > insn->sym->pfunc->debug_checksum)) { \ > char *insn_off = offstr(insn->sec, insn->offset); \ > - __dbg("checksum: %s %s %016lx", \ > - func->name, insn_off, checksum); \ > + __dbg("checksum: %s %s %016llx", \ > + func->name, insn_off, (unsigned long long)checksum);\ > free(insn_off); \ > } \ > }) > Acked-by: Joe Lawrence -- Joe