From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0015C2FFDE6 for ; Wed, 7 Jan 2026 10:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781485; cv=none; b=XNW8+yOgnLS6rSYjkA2pvsAj4l45rkq8jGzUT5HLcplDCP49zqkirmYJx7QhyRRTLuh5J7o5SoD17zbq8QqtqPIy7F9Rh3tS2Bq8vepKuXid8HPEun2C7gBv29K5vb4kkgnOLiL+OAFqPMscSkGG5vpDENwkddwAi4nDyi/Mqq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781485; c=relaxed/simple; bh=RU676P3TvU0swoFzAWorS8H0cptCGiCBmBQZLWScomk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YdKIAxXTzHl+MK4+N4jO+k4fVyIPr1ZdZhoJ32Wm535ABnNomFzyQ09Ncta8NjU2fxQM7YbgTwQqUi1+/EX6RUGof37MAxuw3kkjzOnsXIbSp4dTugtUaCkSROvpLxHKVxmGhdBe2vreYvCWkXUgxH71ZvEhafE+QG63ckUAvuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YaphE1YY; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YaphE1YY" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47d6a1f08bbso7108935e9.2 for ; Wed, 07 Jan 2026 02:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1767781480; x=1768386280; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AK2Gg8unTsWO3CwKx4f9Ov3gr2i0DpoldAAWtOWz2w0=; b=YaphE1YY0YNYnR30Ev6vb+Db7WqxbNcgWezK6VBjVTnh7+5F+MkC4sr+khDNbwdxQ5 +gioT+7P3ShwsUG2Takob/CqnzwIK0SS9jwWFZ/zhneBHmc79q2B7DAeL5RklvoxrXbf +yWFgminR1DvzSnr7mI1p86lWHKaYUFndgUbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767781480; x=1768386280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AK2Gg8unTsWO3CwKx4f9Ov3gr2i0DpoldAAWtOWz2w0=; b=VVCzWTQrBAswTwSNu53WYGBToQTjegIabKceCbB/+sDUA8n2czmpAkzMOZYPmdYuQg NX8iJj1nL7+HVyEsVyQ/xDd3z+FKZuH88ZbFzG6hTX2WI7qWLKnMDSzdNyvNHYl3V4ke KU6CBofxzaus/qy5amPT+BQ6Pc+3VFPfL8xoo3wHdSdpl+U695fzKFhWML4mI4q26sT4 hUcPbmBZTZs0R7q1ht5hhMg/kRf2sxQsm2nu14t8BJttpCR2Y6d/x417ydy0FGmJ1Ai5 V1Z5u+36Q0AV1H/Fgbc2m2WVvkTOSLT+mxGysJg7fxUmg7F/lKknY3x7jI8ipVET/OGl jwkg== X-Forwarded-Encrypted: i=1; AJvYcCVXD9fjqDT18FkvoiGITdMn+Z7a1ECL3jgM/kvlkEBB6gAPES0HYkhZpcNuzThWBp9QRU08Y/VQHPOw4Nw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8P72rfvhKZ8i/T84F5LX0uz+m2ZRDTuKqIGMfUYaNXKiq7Ev6 DJDZpLIdyCnAmejQitA/c7P0noj762Q+ITqOJydypVVQbR9v37wyeDvmt2JlUtfSSA== X-Gm-Gg: AY/fxX7UZLNzQy4GHdEtVAaJYiGUXiBfLPTMyXakzpVy8l64zh0PN8NS3aX4ijfqD58 lfnFU1KeTFX77GBdAv+QpSHIGmEOOSk4FgShmpliosEcKOBvfN93mibleDfDqnqkyMcXvsFphiL p1AYT0hWx84rlpc6k3+ChbJSYaKCIqGGCKuclWGGEQVwbcumG1aOLlcYpmJad597hcbfrdUHUjc 9A/SU+EYsfXjxUMhBZoCqCuxMzXkriqbfqkiaK9N6H5gp1ZHbS0sxbpbm+f0QHVG0ssKXB2f+P/ dzm1eSe9fylqKx9VdsfU2bmpj6M6hAxpvRneDthCMKZ3JSg0lUv/ftTY+YhtHRBlTMaHRmeOESn oEwim/ae3ni83vURdUqZsz06iQvVTgeayGtW+z8wNH+bTjV4+cPTdDwsZGKWS1QCD1E1CPNQxPj GeO8P3ZrGGZLMzME+GePMR4sga7BWF X-Google-Smtp-Source: AGHT+IELXErZD8ru3w6x43TKd1f8wm86x+ymI62qEzqJdcBMa1KawoY4byUO5aTYAhFJUs8vu9rlqQ== X-Received: by 2002:a05:600c:19cc:b0:47a:7fd0:9f01 with SMTP id 5b1f17b1804b1-47d84b21227mr24311245e9.16.1767781480359; Wed, 07 Jan 2026 02:24:40 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f653c78sm93239545e9.11.2026.01.07.02.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 02:24:39 -0800 (PST) Date: Wed, 7 Jan 2026 10:24:37 +0000 From: Fabio Baltieri To: Simon Glass Cc: Dmitry Torokhov , Benson Leung , Guenter Roeck , Tzung-Bi Shih , linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/1] Input: cros_ec_keyb - add function key support Message-ID: References: <20260106112953.692304-1-fabiobaltieri@chromium.org> <20260106112953.692304-2-fabiobaltieri@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 06, 2026 at 09:22:06AM -0700, Simon Glass wrote: > Hi Fabio, > > On Tue, 6 Jan 2026 at 04:29, Fabio Baltieri wrote: > > > > Add support for handling an Fn button and sending separate keycodes for > > a subset of keys in the matrix defined in the upper half of the keymap. > > > > Signed-off-by: Fabio Baltieri > > --- > > drivers/input/keyboard/cros_ec_keyb.c | 174 +++++++++++++++++++++++--- > > 1 file changed, 158 insertions(+), 16 deletions(-) > > > > Reviewed-by: Simon Glass Thanks again! > > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > > index 1c6b0461dc35..74ac1700b104 100644 > > --- a/drivers/input/keyboard/cros_ec_keyb.c > > +++ b/drivers/input/keyboard/cros_ec_keyb.c > > @@ -29,6 +29,11 @@ > > > > #include > > > > +/* Maximum size of the normal key matrix, this is limited by the host command > > + * key_matrix field defined in ec_response_get_next_data_v3 > > + */ > > +#define CROS_EC_KEYBOARD_COLS_MAX 18 > > + > > /** > > * struct cros_ec_keyb - Structure representing EC keyboard device > > * > > @@ -44,6 +49,11 @@ > > * @bs_idev: The input device for non-matrix buttons and switches (or NULL). > > * @notifier: interrupt event notifier for transport devices > > * @vdata: vivaldi function row data > > + * @has_fn_map: whether the driver use an fn function map layer > > How about: driver uses an fn function-map layer Yeah sounds good, will send a v5 with that comment tweaked.