From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3CD6155389 for ; Wed, 7 Jan 2026 08:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767772855; cv=none; b=GdUs3/K9xCZSOTbEWqkwvwNgeTNC/ZmCwlaPKrxiE/HN/UNaGZazetpu6Bwh7fPPVtB0c1wVBM4meN6jYBjV+Um0HD0mA73wz3NOBeXQDI3TJQo8YM2MkzaFfRpJcZP34bi6+mt31Q1+OEjHCxP4Vtg1kaFc1hXAyNyEQGukO9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767772855; c=relaxed/simple; bh=QSnIBwU96zV2LrzudZzkWGGqFB0hjABiY5fKcpQ3XBk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eZbRt/59M2T9MxcNlFwEk8b8fOmGNR/jlko2dFTWv1d2HEvx8fciissEzEZElrt/63tmmCSlBRrnd8DNy7YQx7DVi5wbeoEzsfI+Kz0qacys/xYZrLRR8oknu/wx3X/Vr6+VNYxBKpcYK/ip7YNJB8uchGMMB8R5jQ3ukJh/87A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g4nlAvvs; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g4nlAvvs" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-59b30275e69so1497073e87.1 for ; Wed, 07 Jan 2026 00:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767772852; x=1768377652; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=VhnBpr7196+FOJUvDq4alYkgMDcX0xTE5ToCjAvUb4M=; b=g4nlAvvsFiJeNsjHXum7T1WqNMBOTQKqg4ni1EACkui+g320BgRz/osGUdq9jMN/wy DluqCrViQ0bwrIgJ6Y2vuxYCitBjB4PlA3bg14IzabbTCtmImU/QgKP4t2IGchF2T1xW L6j0F+bRzxlN+OKXLrkouiHQmtHqgTPnWsF3pAlhUYLxkmtqivM1UyxkvZXPYWNymAFc 521ibs9U/KPH1VUZ5aONZvEpf1esMzlHuOyK7vWq2j8BQ0/rbKGp2wkuHns8vSnwDbXY BtEGYgHDtY3SA3OT1BilGqYFowmmDRBqokVQY3J3V7ornC8fgzSGGVGUOH7rzusiGPev LNyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767772852; x=1768377652; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VhnBpr7196+FOJUvDq4alYkgMDcX0xTE5ToCjAvUb4M=; b=YU6h9wk0kazkpM9+jUcDPXcfxAN1x5XYwZFTE19tAeDshr6SZimYtJB0Aqy2mc/51i D0Z/CQgyYPMfvRqcGqcgUTwExdIJfQT+bf83BucKzW6AdKs2mQLEOy7itghgXoVj1lDD P3OQrdD+T8E6I7oZWVMvZA3rujed1aUByp8EziL4uvPa3UQROAciKzDw/pxcl0hKhCdJ LNsk44pJEwRx552yA5cNRxh6viorp4woxxZyvY3L10YEzCplWEYIqcFLzhPpjDtVvlzY AJT3s5t9v2+eECOMQ8KZ5jSDIe4YsuSFtbiHrnDLltYHmCTj7YfvyEGgHk2gKS7aF4K/ rXCA== X-Forwarded-Encrypted: i=1; AJvYcCUOLEJqJkABcxexefmPpDAWIB1xJ6TUKLq7pndup7mIiLYQQg8kNEfYKdwiSkkHvZ1c9zMBFPvwhljhhLo=@vger.kernel.org X-Gm-Message-State: AOJu0YwPFEgVISiZ16GkCTW39YByaw7zkE3F+8BoO0V12w48lKepkTGB P1vOcAoSQOqP74LWeJ0TcFYO2flX6dHQcCeQGrRFXeY5cii1hrcJLsQCQULdliTBPZg= X-Gm-Gg: AY/fxX7vNdNbk4gLn1oRhxPg+JHh+hN7D9sPPdw/m75Le/Z+DIMWAJ54/3JQn1MUsT2 jk85ISHlHa5vwBTEhmhut+AHC+E74K5nDHXFzaOxmEP1sxC5KuzfGt9nRFCkpwzF0VHrDNMsLSY UyiK45orbfhAY3dKxuGpb6gSy5BBtYqcj5mMoxE0HT89ltuPMrLNEWR8h3M3b5OrnVwZdfTBhyg 3yGdx23MyKIQ0Zf+PIIQjOaCncQMpWa9DV3SOz9tkg4B1HM1ZggaHHeBwqLNCKgnP5Sluns2rJT pVyhZ75ZLSBxFtIHL9atIveMXfltRxnySviLH/9dShaJwiyf81MkR+yIUIRP7GU/2CRjGE5Yy7L ctxmz2nIDeaK/v1bcAbyevVT2UxCmeHfxCzGyY/cxGhU4xC5FLvhI30dsYH7i/zigh1g+AhSGqk y75LFqpdIU792AyoLePVbKwjB1C+o1aAB4dEEaHD6IAqk1H6fK1eiwxdo= X-Google-Smtp-Source: AGHT+IGP9An1nYsAtOO925vmyDQ8zlULnKIWzpU5EiZN7i69pmtbFARTzBugqgf6PV60tIxYNMlI5A== X-Received: by 2002:a05:6512:131e:b0:59b:2670:aa5 with SMTP id 2adb3069b0e04-59b6f0420c0mr461240e87.37.1767772851534; Wed, 07 Jan 2026 00:00:51 -0800 (PST) Received: from nuoska (87-100-249-247.bb.dnainternet.fi. [87.100.249.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59b65cea814sm1150596e87.12.2026.01.07.00.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 00:00:50 -0800 (PST) Date: Wed, 7 Jan 2026 10:00:48 +0200 From: Mikko Rapeli To: Tomi Valkeinen Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Michal Simek , Bill Mills , Ilias Apalodimas Subject: Re: [PATCH 0/2] drm: xlnx: zynqmp_kms: 16 bpp fixes for Xorg startup on AMD KV260 Message-ID: References: <20251205123751.2257694-1-mikko.rapeli@linaro.org> <533168f1-1655-4947-9032-b08463f502d7@ideasonboard.com> <5f570a3b-7bee-43e0-9a36-3d106984fec6@suse.de> <3d214bf3-6b52-4942-95d9-0504fa6f5877@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3d214bf3-6b52-4942-95d9-0504fa6f5877@ideasonboard.com> Hi, On Tue, Jan 06, 2026 at 10:29:37AM +0200, Tomi Valkeinen wrote: > Hi, > > On 06/01/2026 09:41, Thomas Zimmermann wrote: > > Hi > > > > Am 22.12.25 um 09:58 schrieb Mikko Rapeli: > >> Hi, > >> > >> On Fri, Dec 19, 2025 at 02:30:11PM +0200, Mikko Rapeli wrote: > >>> On Fri, Dec 19, 2025 at 01:59:14PM +0200, Tomi Valkeinen wrote: > >>>> On 05/12/2025 14:37, Mikko Rapeli wrote: > >>>>> Currently on default yocto images Xorg fails to start on AMD KV260 > >>>>> because 24/32 color depth gets detected but does not actually work. > >>>>> > >>>>> These two patches fix the issue and now 16 bpp gets detected > >>>>> and Xorg starts and draws on external HDMI display using > >>>>> kernel.org based linux-yocto kernel. > >>>>> > >>>>> Anatoliy Klymenko (1): > >>>>>    drm: xlnx: zynqmp_kms: Init fbdev with 16 bit color > >>>>> > >>>>> Mikko Rapeli (1): > >>>>>    drm: xlnx: zynqmp_kms: set preferred_depth to 16 bpp > >>>>> > >>>>>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 3 ++- > >>>>>   1 file changed, 2 insertions(+), 1 deletion(-) > >>>>> > >>>> Did you notice the few already sent serieses on the list where the > >>>> topic > >>>> has been discussed? > >>>> [PATCH] drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888 > >>>> [PATCH 0/3] drm: zynqmp: Make the video plane primary > >>> Oh I wasn't aware of these. > >>> > >>>> Or is there something else on KV260 that messes up the 24 bit color? > >>> These look very similar and likely fix the X11 startup. I will give them > >>> a try. > >> Right, now I've tested: > >> > >>   * these patches from Anatoliy and me to help X11 use 16bpp mode by > >> default > >>     and removes the need to manually setup Xorg for 16bpp > >>   * "drm: xlnx: zynqmp_dp: Support DRM_FORMAT_XRGB8888" which enables > >> the X11 default > >>     24bpp to work, no need to set Xorg config to 16bpp > >>   * "drm: zynqmp: Make the video plane primary" which also fixes the > >> X11 default > >>     24bpp to work, no need to set Xorg config to 16bpp > >> > >> All of these fix HDMI graphics output on AMD KV260 board with yocto > >> genericarm64 machine > >> and core-image-sato image which includes Xorg. The graphics rendering > >> is still > >> very slow but I think that is a different problem. > >> > >> I guess the last series from Sean Anderson is moving forward so I'll > >> reply to that thread separately. > > > > Just want to say that the series here improves xlnx and makes it a > > 'better' driver. IMHO the changes should be merged independently from > > what happens with the other series. > I might be missing something, but I don't think I fully agree. Yes, the > userspace doesn't seem to be able to cope with the current upstream > driver behavior (even if it's not wrong as such, afaics), so in that > sense this series is better. But I don't think (almost) anyone really > wants to use RGB565 if XRGB8888 is an option? And that's what the other > series is trying to achieve, and that series conflicts with this one. > > So I'd rather try to get a conclusion on Sean's series (or the other one > from Mike). If that effort fails, we could go with this series as a backup. I did testing of all three different patch series'es on AMD KV260 and did not find any performance difference between them. The Xorg rendering is still very slow to an external HDMI display. I don't have an opinion on the graphics formats but just want something out to a display by default. I think there is a lot more to fix to get the performance into usable state. Cheers, -Mikko