Re: [PATCH 1/6] nfs: properly disallow delegation requests on directories

Christoph Hellwig
2026-01-08T09:24:49Z

On Wed, Jan 07, 2026 at 09:20:09AM -0500, Jeff Layton wrote:
> Checking for S_ISREG() in nfs4_setlease() is incorrect, since that op is
> never called for directories. The right way to deny lease requests on
> directories is to set the ->setlease() operation to simple_nosetlease()
> in the directory file_operations.

This fixes generic/786 on NFSv4.2 for me, so:

Tested-by: Christoph Hellwig <hch@lst.de>