From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 111FA352FA5 for ; Wed, 7 Jan 2026 14:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767796405; cv=none; b=iVm55++vg0wsXyJTkVuMlPbsHnaSyZwC2Sme0Y+e4bosyqa0ZAVhrGQ7lVLB+MmTPbjjlS40gc6Y45JWecELEq8i70TFiNiudv9mKBi8qryO4rIIs3Rf7kyPSrAkJjwSyisIr1iRstDIZZuvUtT1UVODZq2JXYV5ugqXURzKOTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767796405; c=relaxed/simple; bh=2bzqlIKsXX9eO3lZgBojgE7dcdQpm//aVw2u08myThA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IWESH9wEnp2PzI1ZGkbXOgyLUV99lfptxDtY9rONQ5jdoDlVN7cLQc5pfxQlLh+empApBDDEWwhs+/SlDWTOyxto+euql92aTGVvb3bG8JLywmpMltGnZ+O4CkSjryQdjTuYTL8BhVyD3STI+BhbEaP96DlpxYrANFE3aknxcrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qHtH8alC; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qHtH8alC" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47d3ffb0f44so14242795e9.3 for ; Wed, 07 Jan 2026 06:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767796401; x=1768401201; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ehCzga0f5q0xi43P9nCB2+2oc9tg1sqwri9arZAFlk4=; b=qHtH8alCNALBmwUDnfTi7rVypHeszjuGel3MAfkugPcQLBe2i3g+JbolEdcHZkBjhQ U9jW1+bmQ6lWuCsIJ4xcIyyY/tjARe107PNbLusCFYRS+b1RZgXEk7PCD59ksbT3yMmm /5IuI3b7ZSYJtVDdZlQ2h2rMNHjk/Ji+rHmtbYnIGQaxNJJtkmHktx5b9UvBVWQnQorB 487SNM4wlW/i9fDvN+2tXZkAD1At0hyJG2HJZjAvSTzhOUL36vflHA401R2+UOnGLttQ sl8Hibew2UAFZ8dWwBstBSDn3OkelRlwBnqm3VQJ7QU9tLNSxz3fwxusuxJF3PEdPeif DDuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767796401; x=1768401201; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehCzga0f5q0xi43P9nCB2+2oc9tg1sqwri9arZAFlk4=; b=whVQN3Sqf7Cm2WFjJpKxvh4lYQM7Fdeqzk0T1gMo5i/dRVgaKx3M1e1xI+tCdwH5SU CP24ENSY06u0DDs+SRy0KnBlnFwqafd/iZZFyCfzOSM8gEfp9RF7bH7HVb3OUIgBgyNa UFQdKTwaLetNKeItnw03lEXbTzygniIdAPWsp+Q8NOHlIb6NS/maVV0fj0t7N82cn5DQ rCvJq6YIPLpyJsInXQ4JuIdgTf11lduRnPCkFOIo70W7hbhsVde1MFOweoCr0Fiyrh39 JXW8Ts1Cj6kIZIiIKN3IsVSWwJALQFQtMQxOuyWBK7VZ1SHGocQgV+WRPIFm33z3ixvr agBA== X-Forwarded-Encrypted: i=1; AJvYcCWhO5c0/zsEGrngstMYttEmxbE2LejQRqvlLAi4EXXwX3+2Xhm10CS7RgG7h5Wy13HfEm/G2EwPQXxdgOk=@vger.kernel.org X-Gm-Message-State: AOJu0YzK0aT+xUKeLpksxEjWHuhYniUnygIIpkMWx4+y/G/Zvsx0gvzI yECkWXMiDThhPQPg1XZWjUR8O+FRgP33Qyy5b0OQkjFqrJhtYSUtqilYMQD/9NHt2CI= X-Gm-Gg: AY/fxX4s3ak1bDyqfzYwsnZ4hIZIvDbrHHONn4eGcpe7kGxEpXAtRG2ALfd50Yl4UVt ThwUQxiapDQWOKuApICCKYa/R/TwL4kvXDb5yVt9HMV3J2SIHWJDgy9gBalni7o+5yRe00Gn5BO /aG3KY+YQ7bzrd8X4Rebxtxu0pud4ykPMi8/cmShZzqAeOWkQWqXKZjxfUbhKJuJ1cfuMa2VN4F H88vZtaUqWuOAZ5lhlwcJ5pnANrzz1nq4cX7METtJ38KX8DP1K5WvBSy0hm/7vtqy+wcAEPUaue B4lo97AuZAV+NIsc3t76F3QAm0X+Me6eHAa4KJnEKw+QOrEMKvl3zXP6UNdyYzpJtogFwa6OEje NndAamjK7Zrs6VI16sRMiIcapi/BrE5rIUaK0kX6pQFBqozuwKJja9GL9ztYPHkNFZNR5ytMLer V1q98yOZLJcxtr49oa X-Google-Smtp-Source: AGHT+IHkgW927iPiW7zVWJf1VnqJUxtlpbfccw9OxZ6+AFkNdl4ava7yOMMQmuHv9ZI+fg8GpAmGDQ== X-Received: by 2002:a05:600c:4692:b0:47d:3ead:7439 with SMTP id 5b1f17b1804b1-47d84b5403dmr31430905e9.37.1767796401195; Wed, 07 Jan 2026 06:33:21 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f653cd6sm106370605e9.9.2026.01.07.06.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 06:33:20 -0800 (PST) Date: Wed, 7 Jan 2026 17:33:17 +0300 From: Dan Carpenter To: Karthikey D Kadati Cc: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 RESEND v2 3/3] media: atomisp: propagate errors from ISP xnr and IRQ enable Message-ID: References: <81e2d12c-342b-4b88-88a0-3e24115541aa@kernel.org> <20260107134844.68074-1-karthikey3608@gmail.com> <20260107134844.68074-4-karthikey3608@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260107134844.68074-4-karthikey3608@gmail.com> On Wed, Jan 07, 2026 at 07:18:44PM +0530, Karthikey D Kadati wrote: > Propagate the return value of atomisp_css_capture_enable_xnr() in > > atomisp_xnr(). > > Also check the return value of atomisp_css_irq_enable() and log an > > error once using dev_err_once() to avoid flooding dmesg. > Leave off the "to avoid flooding dmesg" because otherwise it makes it sound like we were flooding dmesg before. Just say: "Also print an error message if atomisp_css_irq_enable() fails". regards, dan carpenter