From: Niklas Cassel <cassel@kernel.org>
To: Koichiro Den <den@valinux.co.jp>
Cc: jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org,
kwilczynski@kernel.org, robh@kernel.org, bhelgaas@google.com,
Frank.Li@nxp.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] PCI: endpoint: Add BAR subrange mapping support
Date: Thu, 8 Jan 2026 10:41:09 +0100 [thread overview]
Message-ID: <aV97tR3AKxBVCBHr@ryzen> (raw)
In-Reply-To: <aV9638ebwqc4bsbd@ryzen>
On Thu, Jan 08, 2026 at 10:37:35AM +0100, Niklas Cassel wrote:
> @@ -596,6 +596,9 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
> if (!epc_features)
> return -EINVAL;
>
> + if (epf_bar->flags && !epc_features->subrange_mapping)
> + return -EINVAL;
This should of course have been:
if (epf_bar->use_submap && !epc_features->subrange_mapping)
return -EINVAL;
(I simply used flags in order to compile test without applying your series.)
Kind regards,
Niklas
next prev parent reply other threads:[~2026-01-08 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 4:41 [PATCH v4 0/2] PCI: endpoint: BAR subrange mapping support Koichiro Den
2026-01-08 4:41 ` [PATCH v4 1/2] PCI: endpoint: Add " Koichiro Den
2026-01-08 9:37 ` Niklas Cassel
2026-01-08 9:41 ` Niklas Cassel [this message]
2026-01-08 9:59 ` Niklas Cassel
2026-01-08 16:39 ` Koichiro Den
2026-01-08 4:41 ` [PATCH v4 2/2] PCI: dwc: ep: Support BAR subrange inbound mapping via Address Match Mode iATU Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV97tR3AKxBVCBHr@ryzen \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=den@valinux.co.jp \
--cc=jingoohan1@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox