From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Zixuan Dong <dbeidachazi@foxmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: atomisp: remove redundant OOM error messages
Date: Sun, 28 Dec 2025 21:23:44 +0200 [thread overview]
Message-ID: <aVGDwLtf4tbEH4P2@smile.fi.intel.com> (raw)
In-Reply-To: <tencent_C0328035BC37187FA2BED4352C504E3C5607@qq.com>
On Mon, Dec 15, 2025 at 01:53:32PM +0800, Zixuan Dong wrote:
> The memory allocation functions (kvzalloc) already emit a stack dump
> on failure when GFP_KERNEL is used. Printing an extra error message
> is redundant and increases code size.
>
> This resolves the checkpatch warnings:
> WARNING: Possible unnecessary 'out of memory' message
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Sakari, can you pick this up?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-12-28 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 5:53 [PATCH] media: staging: atomisp: remove redundant OOM error messages Zixuan Dong
2025-12-28 19:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVGDwLtf4tbEH4P2@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dbeidachazi@foxmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox