From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [5.144.164.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31CEF271A9A; Sun, 28 Dec 2025 22:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.144.164.165 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766962165; cv=none; b=n7q4K/d/O7Q+IB3t0qeII6kQJGW1+hsOz0MIG2B303CqOrULVBYREqSWnKPNCVDfUZA+F56xJwgjQcUP0gPyRxNf32llZToD0TPovsGiGbD4rzR+eXSo7K+MZ4Ih3rQZZc4GLYm/45R7YCATOnI5uEQt/YOXo3BgOJvIeMHPEmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766962165; c=relaxed/simple; bh=3PKL9uB3edz3XFN3H2NDn6U+xyLVc8KlC++fMDHYexk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o4yPpCRDGx3rZ1QyMiQos+wC+aQcgnYbv3U8WJvYB9S4Z5+t3yEKXgW6L/XPj0IDaYtV4g9L8lYVESCRuh7XxuMWQc53lNNeaJNoEU2l/0zFlAR/Egg1EsYQZi3v8KVt/a5M9gxNcrlMyWOaAkyn1uODrDKaVdCAYPPiaRYlLns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org; spf=pass smtp.mailfrom=somainline.org; arc=none smtp.client-ip=5.144.164.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=somainline.org Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id B77B71F8D7; Sun, 28 Dec 2025 23:49:14 +0100 (CET) Date: Sun, 28 Dec 2025 23:49:13 +0100 From: Marijn Suijten To: Krzysztof Kozlowski Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Casey Connolly , Rob Herring , Krzysztof Kozlowski , Simona Vetter , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang , AngeloGioacchino Del Regno , Konrad Dybcio , Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung SOFEF03-M DDIC Message-ID: References: <20251222-drm-panels-sony-v2-0-82a87465d163@somainline.org> <20251222-drm-panels-sony-v2-6-82a87465d163@somainline.org> <20251222-godlike-mongoose-of-valor-3eeee0@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2025-12-22 09:36:23, Krzysztof Kozlowski wrote: > On 22/12/2025 09:33, Krzysztof Kozlowski wrote: > >> + - | > >> + #include > >> + > >> + dsi { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + panel@0 { > >> + compatible = "samsung,sofef03-m-amb609vp01"; > >> + reg = <0>; > >> + > >> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>; > >> + > >> + vci-supply = <&vreg_l11c_3p0>; > >> + vddio-supply = <&vreg_l14a_1p8>; > >> + > >> + port { > > > > Not tested :/ > > Ah no, this one is correct. It's the other patch with similar compatible > which was not tested. I think you mean: .output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml .output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'port' is a required property from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml Which looks to be fixed by including panel-common-dual.yaml and changing `port` to `ports` in the properties and required table? At least the errors are gone, just asking if that is acceptable. Then: .output/Documentation/devicetree/bindings/display/panel/samsung,sofef01-m.example.dtb: panel@0 (samsung,sofef01-m-amb609tc01): 'vci-supply' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/display/panel/samsung,sofef01-m.yaml Which I do not immediately understand how to resolve. I'd believe there's a problem with the conditional inclusion of this vci-supply property based on the compatible name, but do not see where the problem lies as other dt-bindings seem to write it this way as well. Can you point this out to me? Alternatively I'll drop the example with vci-supply, but this'll return when said panel is committed to DTS. Lastly checkpatch complains that the "lgd" prefix isn't a valid vendor. Should I add "LG Display" to the list or rename it to "lg,"? > Actually two others were not tested. We are not a testing service - it > is your task. That is not very kind; sometimes things might slip through and it's nice if CI catches them at a last resort. - Marijn