Re: [PATCH v2 03/11] drm/panel: Add LGD LH599QH3-EDB1 panel driver for Sony Xperia XZ3

Linus Walleij
2025-12-29T12:33:57Z

On Mon, Dec 29, 2025 at 12:21 PM Marijn Suijten
<marijn.suijten@somainline.org> wrote:

> > Can you break it out to a subroutine?
> > lgd_lh599qh3_edb1_unlock()?
>
> Sure, though unsure where the "lock" sequence resides (and why it needs to be
> unlocked twice, unless this was autogenerated and is unnecessary, or implies a
> "flush" of sorts) or why it looks so familiar to the Samsung panels.
>
> Will rename it to lgd_lh599qh3_edb1_unlock_multi() and pass it a
> mipi_dsi_multi_context so that no extra return-code handling needs to be
> implemented.

I think extracting the unlock macros from the s6e* drivers and put into
a separate .h file is the best for starting to unify these drivers a bit,
but no big deal, I can do it later.

> > +/- this nitpick:
> > Reviewed-by: Linus Walleij <linusw@kernel.org>
>
> Just making sure, you reviewed the SOFEF01 driver with your Linaro address,
> which one do you prefer or should I keep this distinction?

The Linaro address stops working at the end of this year,
I'm sorry if my fingers sometimes type the wrong address...
linusw@kernel.org is what I should be using henceforth.

Yours,
Linus Walleij