From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B7D21D5AF for ; Wed, 31 Dec 2025 14:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767191901; cv=none; b=HxrNfLQcnOsvtuxxIfYAwv6I4XLCeMDPlVYuArI2Xv0PoadfVNpYqwpP1d9WscIMqrLCSO56q3mkL/vGbxZSe3p/PNYEOsqrbqTh2RVtpHsdJVkC72vzDhN9l04dCqmiFAQKn/ML52Jni85VAlU4Wv04XWadPGkkPInAgq5mXe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767191901; c=relaxed/simple; bh=fxOtoZQmqJyrlEyrXP3Y5e1kvtKLUYdOVazie8WEHG0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PYJ+j/CTKZyPPN73Laq5c1BsuE4eg0hCdAiLRBboZanaWO36FxoVxTJB1/vng2GHsIsQOubd3m5608vCHjZUVKMxTExPrByTJKwRwMHA+vKSHSmcNWcTuu4x+/BUOUiE/lXwkwYAC9maz7Hdh50Gb6V/JeSkc7mwq8r2BYZXSn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ym9AzWvZ; arc=none smtp.client-ip=209.85.218.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ym9AzWvZ" Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-b73161849e1so2079314266b.2 for ; Wed, 31 Dec 2025 06:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767191898; x=1767796698; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nLbaMCIjSuuimKPRaZzy2+ZfuglyLTZsRd/zUw1VYM8=; b=Ym9AzWvZt0cnQDCh9mrgmPLa6V+FTqVXUrhz+fQl3wGQGNoisnV8VWuF3F/y31+87/ nk1MytOxScIbM5k9YiqWo3XZVpFjZ96XV6kex9RneLydiToC0hgq9OYs7PJlqXsSmxkT TGna7EjoahRmctBrYtXnuleB5kHVPJV2GFwMWFE0ipQeYg5GcJTmH+l4UvYc3XBSWuJA QYQNutRQO9aXu+lMs2N2x356Q8KxO41HdVxZukB+HbHaWAIBc6sWlrB1AthJPPFeElS6 Ok3gIbYqqxG9HFNbyVNZL7kKDWC9zVo6Xu1R+Mfd0weJEdkjmwlY+8vmP8YVs557TAbr V6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767191898; x=1767796698; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nLbaMCIjSuuimKPRaZzy2+ZfuglyLTZsRd/zUw1VYM8=; b=diin3vLC6SM0kvhxl1UhhJp/nOCCgjkb5WNo/gZRcAZ98MufUaOMdey37Y62P92Am6 oGW4jenUljsRkfNcO24vBOdxeqjslgPBwadXhtL6hNBd4pF83uu47UW9sZnGsORMO4du CwEWRcBA3HvGQKW7wIX8DCX9fnnbOXRqC+wh3SSr92HYbgfcujAIJyMzs47gGlawElwp GCgGKPQbJDd10sMO3LYfu35U/NXgoETtdbCszDVl7X2LWavdqVdFXa6Eae6ec/41Bx+x 64d5PVqY1EDfvwvXNErusRxlmcMaRlyHW7UT+tqZsBYryDSN6KX0pZSfFoE4kEogNbIv KNDQ== X-Forwarded-Encrypted: i=1; AJvYcCVEcBuzugLhlf9vUwEJtruBAnePCvkey33OHAr5CcvQ9UQVRBoGkzvfsEYkMB2PpUF9UHY1djjV1rT/wE0=@vger.kernel.org X-Gm-Message-State: AOJu0YxcZTk7OB7LEny13W+c8h70rzClkz/agcFFt5+A6JJ9Up8+YCPA 18D/MVAdaS//UV/iM0bVdkhKvUecmIfD6HiA6N6uLCw9eMd4MucQZe2U X-Gm-Gg: AY/fxX6b7WBHbn2fCntCCxgETDg/RMWjt7J9hxYhjFhBiJKB67mICLTVgo8mgu6XMTH jkGkUhbqYDaLZGouzzSPwfR838NtjI0PeedndERipUo/vgPcsbVMOv9Qwx1YNxGMDB5YTNRhPkl fPUyzFHzbRS2Tj+q7wAgLbf/jwGDLQsX19yLz4Fr3VxxOd5q9ahZz4h9PXnwytFX9dEqj4/0/3G s7gbmjShhKUkWFJJXWKsxQOGLh9Q4V/5313R9iSkEpGwi5/eL3XgQTNho2dk0wwO0avg2jqYS0F iX2zTJ43R6gcAr1D89ddPyj7wwaT2oRV7uLImtFqjoucExLFHnwjanm929vW1xYdzWQzylx9SGq 2fkCVsKTeYsNTOAPZVQnNtZ/Da6V1eHrGGE7HSqh14jXrcwAAaTSza8uyJzwAn5bGp3Lpfk7mWU HcAoA7VifpswDM X-Google-Smtp-Source: AGHT+IHo11GLNdzN0xc8eu2YrCtj6KWXaR8GqZPN+jp2a2EX+hxp8jfzxnhHPFpRITxjtPv/qRT6Sw== X-Received: by 2002:a17:906:4fcf:b0:b83:7fb8:1f54 with SMTP id a640c23a62f3a-b837fb81fb0mr911378966b.39.1767191897480; Wed, 31 Dec 2025 06:38:17 -0800 (PST) Received: from osama ([2a02:908:1b4:dac0:75b2:7ca6:1e15:d2e6]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f3e271sm4024323566b.60.2025.12.31.06.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 06:38:17 -0800 (PST) Date: Wed, 31 Dec 2025 15:38:14 +0100 From: Osama Abdelkader To: Luca Ceresoli Cc: Andy Yan , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail Message-ID: References: <20251226223229.123860-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 31, 2025 at 03:09:51PM +0100, Luca Ceresoli wrote: > On Fri Dec 26, 2025 at 11:32 PM CET, Osama Abdelkader wrote: > > When drm_bridge_attach() fails, the function should return an error > > instead of continuing execution. > > > > Signed-off-by: Osama Abdelkader > > Looks like a bugfix, should it have a 'Fixes:' tag and 'Cc: stable@...'? > See https://docs.kernel.org/process/submitting-patches.html > > > --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c > > @@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder, > > } > > > > ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > - if (ret) > > + if (ret) { > > dev_err_probe(dev, ret, "Failed to attach bridge\n"); > > + return ERR_PTR(ret); > > + } > > > > dw_dp_init_hw(dp); > > > > It could be more concise, without adding braces: > > if (ret) > return ERR_PTR(dev_err_probe(dev, ret, "Failed to attach bridge\n")); > > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Thanks, v2 is on the way. Best regards, Osama