* [PATCH 1/1] lib/kstrtox: fix kstrtobool() docstring to mention enabled/disabled
@ 2025-12-27 9:22 Chaitanya Mishra
2026-01-01 18:11 ` Kuan-Wei Chiu
0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Mishra @ 2025-12-27 9:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mario Limonciello, linux-kernel, Chaitanya
From: Chaitanya <chaitanyamishra.ai@gmail.com>
Commit ae5b3500856f ("kstrtox: add support for enabled and disabled in
kstrtobool()") added support for 'e'/'E' (enabled) and 'd'/'D' (disabled)
inputs, but did not update the docstring accordingly.
Update the docstring to include 'Ee' (for true) and 'Dd' (for false) in
the list of accepted first characters.
Fixes: ae5b3500856f ("kstrtox: add support for enabled and disabled in kstrtobool()")
Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com>
---
lib/kstrtox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/kstrtox.c b/lib/kstrtox.c
index bdde40cd69d7..97be2a39f537 100644
--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c
@@ -340,8 +340,8 @@ EXPORT_SYMBOL(kstrtos8);
* @s: input string
* @res: result
*
- * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
- * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
+ * This routine returns 0 iff the first character is one of 'EeYyTt1DdNnFf0',
+ * or [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
* pointed to by res is updated upon finding a match.
*/
noinline
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] lib/kstrtox: fix kstrtobool() docstring to mention enabled/disabled
2025-12-27 9:22 [PATCH 1/1] lib/kstrtox: fix kstrtobool() docstring to mention enabled/disabled Chaitanya Mishra
@ 2026-01-01 18:11 ` Kuan-Wei Chiu
0 siblings, 0 replies; 2+ messages in thread
From: Kuan-Wei Chiu @ 2026-01-01 18:11 UTC (permalink / raw)
To: Chaitanya Mishra; +Cc: Andrew Morton, Mario Limonciello, linux-kernel
Hi Chaitanya,
On Sat, Dec 27, 2025 at 02:52:29PM +0530, Chaitanya Mishra wrote:
> From: Chaitanya <chaitanyamishra.ai@gmail.com>
>
> Commit ae5b3500856f ("kstrtox: add support for enabled and disabled in
> kstrtobool()") added support for 'e'/'E' (enabled) and 'd'/'D' (disabled)
> inputs, but did not update the docstring accordingly.
>
> Update the docstring to include 'Ee' (for true) and 'Dd' (for false) in
> the list of accepted first characters.
>
> Fixes: ae5b3500856f ("kstrtox: add support for enabled and disabled in kstrtobool()")
> Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com>
scripts/checkpatch.pl warns about this:
WARNING: From:/Signed-off-by: email name mismatch: 'From: Chaitanya <chaitanyamishra.ai@gmail.com>' != 'Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com>'
total: 0 errors, 1 warnings, 10 lines checked
Please ensure you run checkpatch.pl before submitting any patch.
With that fixed, feel free to add:
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Regards,
Kuan-Wei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-01 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-27 9:22 [PATCH 1/1] lib/kstrtox: fix kstrtobool() docstring to mention enabled/disabled Chaitanya Mishra
2026-01-01 18:11 ` Kuan-Wei Chiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox