From: Jorge Ramirez <jorge.ramirez@oss.qualcomm.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
Cc: vikash.garodia@oss.qualcomm.com,
dikshita.agarwal@oss.qualcomm.com, bod@kernel.org,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: venus: assign unique bus_info strings for encoder and decoder
Date: Thu, 1 Jan 2026 20:47:35 +0100 [thread overview]
Message-ID: <aVbPVwlJHWY60VAd@trex> (raw)
In-Reply-To: <20251126140041.754071-1-jorge.ramirez@oss.qualcomm.com>
On 26/11/25 15:00:24, Jorge Ramirez-Ortiz wrote:
> The Venus encoder and decoder video devices currently report the same
> bus_info string ("platform:qcom-venus").
>
> Assign unique bus_info identifiers by appending ":dec" and ":enc" to the
> parent device name. With this change v4l2-ctl will display two separate
> logical devices
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> drivers/media/platform/qcom/venus/vdec.c | 6 +++++-
> drivers/media/platform/qcom/venus/venc.c | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 4a6641fdffcf..16587767e597 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -433,9 +433,13 @@ vdec_g_selection(struct file *file, void *fh, struct v4l2_selection *s)
> static int
> vdec_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
> {
> + struct venus_inst *inst = to_inst(file);
> + struct venus_core *core = inst->core;
> +
> strscpy(cap->driver, "qcom-venus", sizeof(cap->driver));
> strscpy(cap->card, "Qualcomm Venus video decoder", sizeof(cap->card));
> - strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info));
> + snprintf(cap->bus_info, sizeof(cap->bus_info),
> + "plat:%s:dec", dev_name(core->dev));
>
> return 0;
> }
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index b478b982a80d..0b5843ba536f 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -144,9 +144,13 @@ static int venc_v4l2_to_hfi(int id, int value)
> static int
> venc_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
> {
> + struct venus_inst *inst = to_inst(file);
> + struct venus_core *core = inst->core;
> +
> strscpy(cap->driver, "qcom-venus", sizeof(cap->driver));
> strscpy(cap->card, "Qualcomm Venus video encoder", sizeof(cap->card));
> - strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info));
> + snprintf(cap->bus_info, sizeof(cap->bus_info),
> + "plat:%s:enc", dev_name(core->dev));
>
> return 0;
> }
> --
> 2.43.0
>
just following up in case this one fell through the cracks (cant find it in media-commiters).
happy to resend if needed
prev parent reply other threads:[~2026-01-01 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 14:00 [PATCH v2] media: venus: assign unique bus_info strings for encoder and decoder Jorge Ramirez-Ortiz
2026-01-01 19:47 ` Jorge Ramirez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVbPVwlJHWY60VAd@trex \
--to=jorge.ramirez@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox