From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C17253359 for ; Thu, 1 Jan 2026 19:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767296863; cv=none; b=jpnjJsFzMWv2xyxaWA+sanNgGhtd5/dunExDPySpMYG4oLl9Nv6bMPdCT8XEo7OsJJhS84wXNhKBOJ/wOWwf6UJ9nc3eozo7fHC4o3PUT0NQw47WRz4WD93uP9rZj4QjkzantuIEeIEA/WRo7PGydbYxPN9I4ciHlgMvyMuxQcA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767296863; c=relaxed/simple; bh=wPz6/A7Ye5l/a54roj0Woc9lHGdEkaFnDIW3yhQ3GqY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cXXzzPB9albEYCtXE6Ripi+K4aTE3yDXKIJK8oU7YN22GexRDAKVWg4CQn92wCVc7c40ihTm2BjLhTMcUxPOnIrQwNrXmljRTpC4Kbxn2w33pstHLPwxwKHNlmfMG5K9NogMjBl5urimkZE2SFgrAYZrvpdND4lXbmquhnyzrhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KZNzDM3K; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LgjPg69h; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KZNzDM3K"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LgjPg69h" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 601IcrTs2942268 for ; Thu, 1 Jan 2026 19:47:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=WmEa8sTsuONOQC5mcK4WwQNA 371bg3byPjHRzHnsmp0=; b=KZNzDM3KBpqIgpcawvfWw/zjmU5Um2XfO8FQMGBW rNF6fhTJS133Hv50joenXXTGHPUwef0wfvPcdiW1W6GZFRtucmoxh7bCSBlpISvu 3ibNd5bzDJwF61tqh5GE5MH7+HYdn6H0FfPLMhPkJ/ZBrPnj84+sG+7R+3BTmetS P0NyeJKrnTz/XdhY13bE6ukAg7oG/Ch0Lw6pQTFY/MOlaEftmZzQC/GzuALSpQSM TbO1zyj9ddSEk9m3uUg4HkGMksBeVi5DUWmxSiq5XUYaaQwH+WGOoqB81aXz/u63 jXcZnjyypjf6rCGD+6eUSVfP82iyJx4sfJ8E8s3lxzTNyQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bd2bb2g48-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 01 Jan 2026 19:47:40 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed782d4c7dso207883731cf.2 for ; Thu, 01 Jan 2026 11:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767296860; x=1767901660; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=WmEa8sTsuONOQC5mcK4WwQNA371bg3byPjHRzHnsmp0=; b=LgjPg69hxYP9btKcVDdqbonllEg7zbjArNjCTp7O+6awzNMdpXlGIU3MKdK9Tm4jU/ 0ZzJyLvdlSWIyE1pNJxJheInsuasSTp3ZMoPlAVJEFOnODHcNjGpYs/GzPT2vXOAk6pW fOCspixePMYL0LpqAE68MfmHkk5MgEId2kRoKAeesCH/Hs5jbtJUwGwbOwn11ydivPq/ qcqLdyrf1iwFhTDnQexaGaFURu4h6c0xeRp+CLDUpGwhSfpmJPElQDHMAZZUCKJI7ccK xJN06q7d15KAdaif8evlPDsMIteByG9GYDJD1e76UE6pZprq4q5DmNsbxjmASv7GLtcD 6ftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767296860; x=1767901660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WmEa8sTsuONOQC5mcK4WwQNA371bg3byPjHRzHnsmp0=; b=Uq27rzDHRyNMPZbHhTkl3bXWoVOc7ZCKKs1g84/HRIbyRDjFiXfvsfSVr0brfdv4rr HYhv0b9VzI5dloZPix/Lz2/QpH6yWDazhQEcQM7sR+2Zpda55P0WuMRtY/U7qSX4pddN kTIiww1xKiUlBFgJVh35Po6MXIETDT5AqXGEGrTMe0+To3/GYhYbt8IFjBE2g/QCa6j8 fH0tA8prRVlFjDiweBGj7Z4YyxuF/+4EfyX9mVoXH9AKEvWzS7a/Lt385vV6uI++VQe1 r6P3F6xNpzCMSy7HNXUXWQAfrT6k76i+ALImjJrwcO0RgrDj/VaUM8J6NGZDfTddujTS DrkA== X-Forwarded-Encrypted: i=1; AJvYcCUnanPyiWYl8/OcgTIRcd0bQgWr2ekbLwODvqCpAT54MVPk0hGndtuQDbn2Sa3NcVSqSY40L2bmmLIwSwU=@vger.kernel.org X-Gm-Message-State: AOJu0YxfVhVZxroBTAxJcWFQeX6oeiszQQ1XDp0JGw2Ee3eqvxK9u7uP YC55w/1Cl6sSOjNldeywP+4NLz6YMc8bKrQNYCKBadFAT4U2mBS2vvZHuvIdXTtFitjA+T8HPsl 2n9RwIeE4DTWuRCsI1aAtKmMsDgxhepyChScfb8y85c/JB/cEkyhnLAaoCipK06JS/t8= X-Gm-Gg: AY/fxX4tWPZnqE3+ypjCCbYj0bmftMXORWF6pmWlL/+FXpqUeoO5nv/BBnn6H+bHp3q U/h87JSRKsD/j5HlZWce0hNBMbwf3dL7tUfye188xQE+ghQ5XJxGiinaO/DvMXJUa/swb3aA1ZI zwlJ/TLc0BFxWt6m4FbBO//LhYWKuGlYjsBoFXZNHlsSt2RGmqBEZd2yJ+clV4W1OD/ZyqeuQCh jAJKuZx/wGmwGjBViD3ukWUmV7RcrK7YO/IBSSeIgM/MWel9kE84yguWLxHD5WYiP1b/3WNNirQ qe3F5Ph98uQ1jLj3ma5ldc+gcRwE8jic7NfEX9xKa0l1X0hQN3GFgLYMdzVINlgzLb9nsfF+Uue nhHH7+/T3gKfxCzvhGkwrumOIsC9GlPQfGLjeMHDb6Zok X-Received: by 2002:a05:622a:344:b0:4f3:4ec0:9032 with SMTP id d75a77b69052e-4f4abdd5bb4mr587273731cf.72.1767296860375; Thu, 01 Jan 2026 11:47:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEabtzU2q2HPDpVEB8UPSt94tcsqv57u9yIYbx0KjUeGxp18xsypq11MCYSVw2DcQCDo4P+ug== X-Received: by 2002:a05:622a:344:b0:4f3:4ec0:9032 with SMTP id d75a77b69052e-4f4abdd5bb4mr587273541cf.72.1767296859899; Thu, 01 Jan 2026 11:47:39 -0800 (PST) Received: from trex (198.red-79-144-197.dynamicip.rima-tde.net. [79.144.197.198]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346d33sm720111565e9.3.2026.01.01.11.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jan 2026 11:47:39 -0800 (PST) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Thu, 1 Jan 2026 20:47:35 +0100 To: Jorge Ramirez-Ortiz Cc: vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: venus: assign unique bus_info strings for encoder and decoder Message-ID: References: <20251126140041.754071-1-jorge.ramirez@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126140041.754071-1-jorge.ramirez@oss.qualcomm.com> X-Proofpoint-GUID: ZyzPq1_UhNKAQ4gFq3WelWdgSJZ9XFE1 X-Proofpoint-ORIG-GUID: ZyzPq1_UhNKAQ4gFq3WelWdgSJZ9XFE1 X-Authority-Analysis: v=2.4 cv=dMKrWeZb c=1 sm=1 tr=0 ts=6956cf5c cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=5kMdAn2P/uOieV37Se86+Q==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Ru27C6mqnJDUFzEZ51EA:9 a=CjuIK1q_8ugA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAxMDE3OSBTYWx0ZWRfX9jNm7s57Cztc R7RU2iG1tuelKvp+//gPCyRs8Tx/JL12aHpCc0dW3dyjzIJ4XBXOW9J1Am1rb64k+k1KYet4Zqk TrnEceAOr2uDhgeLOglO+HVFLZ/Sa6xHP8cu/huWSd6SdMxyN4aiFhtzjy3Jix0Uk209dst+BYx oGj9QOM/giRZl5XjhFzt8BxLZJYC9c6HvRu8TgWphFuSylBByHYX5D6eIRW0cx4xiche9lB0niP RprGYkPrI0VMFBDE5pTc+FmM3fa32/QAQu+lQVNKMMQR5L5noyEL7jawRfQybItV0cn2wCeC2G3 PQF6CMrZpKZewB39hwMwvQtx+A83jK6+HgAHe/SG6hWzD0r8NoGPr6u5O7hI1bbkXgUylalxgR2 zlaPmHadFHhHCmKQz4X47NbFgJcQ2hYH+9wGDMuRKcCcB8Os4W3N+iBVfg2yEetJLhrwE9AOz4h 2b/H87viboIl4QzBnXg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-01_07,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601010179 On 26/11/25 15:00:24, Jorge Ramirez-Ortiz wrote: > The Venus encoder and decoder video devices currently report the same > bus_info string ("platform:qcom-venus"). > > Assign unique bus_info identifiers by appending ":dec" and ":enc" to the > parent device name. With this change v4l2-ctl will display two separate > logical devices > > Signed-off-by: Jorge Ramirez-Ortiz > Reviewed-by: Bryan O'Donoghue > --- > drivers/media/platform/qcom/venus/vdec.c | 6 +++++- > drivers/media/platform/qcom/venus/venc.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index 4a6641fdffcf..16587767e597 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -433,9 +433,13 @@ vdec_g_selection(struct file *file, void *fh, struct v4l2_selection *s) > static int > vdec_querycap(struct file *file, void *fh, struct v4l2_capability *cap) > { > + struct venus_inst *inst = to_inst(file); > + struct venus_core *core = inst->core; > + > strscpy(cap->driver, "qcom-venus", sizeof(cap->driver)); > strscpy(cap->card, "Qualcomm Venus video decoder", sizeof(cap->card)); > - strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info)); > + snprintf(cap->bus_info, sizeof(cap->bus_info), > + "plat:%s:dec", dev_name(core->dev)); > > return 0; > } > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index b478b982a80d..0b5843ba536f 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -144,9 +144,13 @@ static int venc_v4l2_to_hfi(int id, int value) > static int > venc_querycap(struct file *file, void *fh, struct v4l2_capability *cap) > { > + struct venus_inst *inst = to_inst(file); > + struct venus_core *core = inst->core; > + > strscpy(cap->driver, "qcom-venus", sizeof(cap->driver)); > strscpy(cap->card, "Qualcomm Venus video encoder", sizeof(cap->card)); > - strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info)); > + snprintf(cap->bus_info, sizeof(cap->bus_info), > + "plat:%s:enc", dev_name(core->dev)); > > return 0; > } > -- > 2.43.0 > just following up in case this one fell through the cracks (cant find it in media-commiters). happy to resend if needed