* [PATCH] tpm: st33zp24: Fix missing cleanup on get_burstcount() error
@ 2025-12-26 12:09 Alper Ak
2026-01-02 17:29 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Alper Ak @ 2025-12-26 12:09 UTC (permalink / raw)
To: peterhuewe, jarkko
Cc: Alper Ak, Jason Gunthorpe, Stefano Garzarella, Christophe Ricard,
linux-integrity, linux-kernel
get_burstcount() can return -EBUSY on timeout. When this happens,
st33zp24_send() returns directly without releasing the locality
acquired earlier.
Use goto out_err to ensure proper cleanup when get_burstcount() fails.
Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)")
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
drivers/char/tpm/st33zp24/st33zp24.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
index 2ed7815e4899..e2b7451ea7cc 100644
--- a/drivers/char/tpm/st33zp24/st33zp24.c
+++ b/drivers/char/tpm/st33zp24/st33zp24.c
@@ -328,8 +328,10 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf,
for (i = 0; i < len - 1;) {
burstcnt = get_burstcount(chip);
- if (burstcnt < 0)
- return burstcnt;
+ if (burstcnt < 0) {
+ ret = burstcnt;
+ goto out_err;
+ }
size = min_t(int, len - i - 1, burstcnt);
ret = tpm_dev->ops->send(tpm_dev->phy_id, TPM_DATA_FIFO,
buf + i, size);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tpm: st33zp24: Fix missing cleanup on get_burstcount() error
2025-12-26 12:09 [PATCH] tpm: st33zp24: Fix missing cleanup on get_burstcount() error Alper Ak
@ 2026-01-02 17:29 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2026-01-02 17:29 UTC (permalink / raw)
To: Alper Ak
Cc: peterhuewe, Jason Gunthorpe, Stefano Garzarella,
Christophe Ricard, linux-integrity, linux-kernel
On Fri, Dec 26, 2025 at 03:09:27PM +0300, Alper Ak wrote:
> get_burstcount() can return -EBUSY on timeout. When this happens,
> st33zp24_send() returns directly without releasing the locality
> acquired earlier.
>
> Use goto out_err to ensure proper cleanup when get_burstcount() fails.
>
> Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)")
> Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
> ---
> drivers/char/tpm/st33zp24/st33zp24.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
> index 2ed7815e4899..e2b7451ea7cc 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.c
> +++ b/drivers/char/tpm/st33zp24/st33zp24.c
> @@ -328,8 +328,10 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf,
>
> for (i = 0; i < len - 1;) {
> burstcnt = get_burstcount(chip);
> - if (burstcnt < 0)
> - return burstcnt;
> + if (burstcnt < 0) {
> + ret = burstcnt;
> + goto out_err;
> + }
> size = min_t(int, len - i - 1, burstcnt);
> ret = tpm_dev->ops->send(tpm_dev->phy_id, TPM_DATA_FIFO,
> buf + i, size);
> --
> 2.43.0
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-02 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 12:09 [PATCH] tpm: st33zp24: Fix missing cleanup on get_burstcount() error Alper Ak
2026-01-02 17:29 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox