From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ADA1131E49 for ; Sat, 3 Jan 2026 06:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767421027; cv=none; b=s0PVMceKyljV8zQSZ7n3sgaLVH9EXDyxnlSJ+3Mq8m8BdAvKo0nJ3F7Ksm7F892Fmmr85/ZhgzwOnzEEBBD8xrMQHpdB7Lh9K/Y8AMg8D5cxWY4+9ELHwjkidbhjuGkuOtHnHcoCDt/xRVcY3GexSG5K7+dgA6E9JE8xLnT1qYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767421027; c=relaxed/simple; bh=OvhHsmnhwBytDwLUIZZt3NNO22amAFYoNYaJEB8XD9I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U1wvgP/WyYWrkqX+70dMhQ1qNdJ+GxP4tyJe3vA0/qeKQyapbsIHch1lHR/VbHFAWPVESUqmKxRCJ/gcPTOQTJmqFoz5isXTEP1MLiZcS7qd/hLFM9hUOByHyZmIpBfrszrjnM5TVzFdbVGH6Jzvq4zFALr1vYAnC7b172bCjvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CLMzOR/R; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CLMzOR/R" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-42fb5810d39so8138417f8f.2 for ; Fri, 02 Jan 2026 22:17:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767421024; x=1768025824; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0fBTw2m0sw3DdZqYCahoE5TIOLBwDoJuhOGkXgvJXBI=; b=CLMzOR/RwI2YMXXLnWzTNCq3EuQGAR22JxggEVtWWzr1wQMLzQjOkIR85wRFSmnnjQ knWZnqb1RMq9+0vFeaW9oWDA5gfvfUnV9+NuTOWyoiNrKZ2GeFR3a9OPInEdql6CETdx GKPj2dt34tWAes36tNyETN9n+qbuVoBcTTa8GYY328my4WZkekcbYIwkMf0XqBBSD8+j eY83w1CTYj8KrnMBheItjCUuT0Zih+E31ngcHAid4InNDU5yGS3a5Fegn7EXzKHitXMA Jpzap6jRsQokSlQ9lhRq/UYDYOsy8gf9nNrF0Y1zJadD0o4E9t6FpLH4U9twiUpq7L30 jt6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767421024; x=1768025824; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0fBTw2m0sw3DdZqYCahoE5TIOLBwDoJuhOGkXgvJXBI=; b=av5C9KoqStGLYWtkA6aLA3kiALy+xpYtWqPWw1dIcuAa45zaaffA7iYqvJ1/o6UYo3 fGR7m4a+qX/Ko4zgdVlwo118yXIhCPcQ5caPENV6c0qfetb4KQFdgEdL0462TMrBKiXF sPJn6hKNNNLCl8cQpVW5ijWDsK2qZbyXViDsVeDIX5ShpKDsgYFWF6ONFCTmC84ZOnuU CoiMnKwB353ui7Jt4bDpADpFxMpGvWq5JgiNYY1U26luMjPzdwqOUDUxvK2l26MsoRBp txh7GbSwW1ixIu2tNbD9QVeuK0EXokUj2yVlcz8dq8zdv2ja9QpkfSUIYy01z69RxKQ+ faAA== X-Gm-Message-State: AOJu0YypM6u5A+Ou61yXuIQmxLnLxmk5XT86xFJxHqWJ/c0wHnLpuu3O 2MXlNk0UJjHV179k8W1INTy799EEP2F3lO3OvlZA/H+6JooaqKbjzfsG X-Gm-Gg: AY/fxX4+pynQ6bCUyxZ/JdX9KnXLuuD/9fGzlzsmd3WZoBCa7Yrn1huYEIVywXujo43 GX5VRAvF4AqpYa2Awu2Ad8odZEO+AZjqos0wEkdOx1FRwPkr1Zqa5FErIQtNVewZuMPux018lcz /a1uKNL/ngFN74a/G6CMIxcY7yE0bK11XHOIsEsu+9EPOlUv03iJWcmXKoVaSWGoAgP7OmBqfGG 2y6njwSndxLPOtXHLRHA6OUeTse+FiG3qJabMZRXDp31DbwAU5O5wdSoaE1FQI97MCxTSzACixd CsBYtuPtfPtGabBoVJebO+67cFDsYluA5+pzjVqDiax7PkKkY5Q9svM1abpo0R86N4JnwDLv7CK tPQ1IULmRocCfiIbVIDEQfHUXzOUYuoIjHCc4IuGiJheNKFGJurWhcxPlCECslMTE8GTsiYpXex SR0LC9LxCOrk4A50w7aosPyCZquuW6fAdOnVi58QDFksCCkCz8RlB9HtT7VLgmghxG X-Google-Smtp-Source: AGHT+IHdlE+Cj3VwwM7OZ4YHjWykCfF7XHJggX+PliZI3MM3Nwc7QElP+yBNZ3QQxm4vymnI/vBKVA== X-Received: by 2002:a05:6000:2504:b0:431:5ca:c1b7 with SMTP id ffacd0b85a97d-4324e4cbcc1mr61300652f8f.23.1767421023534; Fri, 02 Jan 2026 22:17:03 -0800 (PST) Received: from localhost (brnt-04-b2-v4wan-170138-cust2432.vm7.cable.virginm.net. [94.175.9.129]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab257asm88770406f8f.38.2026.01.02.22.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 22:17:00 -0800 (PST) Date: Sat, 3 Jan 2026 06:16:59 +0000 From: Stafford Horne To: Geert Uytterhoeven Cc: LKML , Linux OpenRISC , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonas Bonn , Stefan Kristiansson , devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/5] openrisc: dts: Add de0 nano config and devicetree Message-ID: References: <20251217080843.70621-1-shorne@gmail.com> <20251217080843.70621-3-shorne@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 18, 2025 at 07:36:08PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Wed, 17 Dec 2025 at 09:23, Stafford Horne wrote: > > The de0 nano from Terasic is an FPGA board that we use in the OpenRISC > > community to test OpenRISC configurations. Add a base configuration for > > the board that runs an OpenRISC CPU at 50Mhz with 32MB ram, UART for > > console and some GPIOs for LEDs and switches. > > > > There is an older version of this floating around that defines all of > > the hardware on the board including SPI's, flash devices, sram, ADCs > > etc. Eventually it would be good to get the full version upstream > > but for now I think a minimal board is good to start with. > > > > Link: https://openrisc.io/tutorials/de0_nano/ > > Link: https://github.com/olofk/de0_nano > > > > Signed-off-by: Stafford Horne > > Thanks for your patch! > > > --- /dev/null > > +++ b/arch/openrisc/boot/dts/de0-nano-common.dtsi > > @@ -0,0 +1,41 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include > > +#include > > + > > +/ { > > + memory@0 { > > + device_type = "memory"; > > + reg = <0x00000000 0x02000000>; > > + }; > > + > > + leds: leds { > > Move this up (or down), before (or after) all nodes with unit addresses? OK. > > + compatible = "gpio-leds"; > > + status = "okay"; > > Missing blank line. OK, also I can remove the "okay" line as well. > > + led-heartbeat { > > + gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>; > > + color = ; > > + function = LED_FUNCTION_HEARTBEAT; > > + linux,default-trigger = "heartbeat"; > > + label = "heartbeat"; > > + }; > > + }; > > + > > + gpio0: gpio@91000000 { > > + compatible = "opencores,gpio", "brcm,bcm6345-gpio"; > > + reg = <0x91000000 0x1>, <0x91000001 0x1>; > > + reg-names = "dat", "dirout"; > > + gpio-controller; > > + #gpio-cells = <2>; > > + status = "okay"; > > "okay" is the default, so you could drop this line. OK. > > + }; > > + > > + gpio1: gpio@92000000 { > > + compatible = "opencores,gpio", "brcm,bcm6345-gpio"; > > + reg = <0x92000000 0x1>, <0x92000001 0x1>; > > + reg-names = "dat", "dirout"; > > + gpio-controller; > > + #gpio-cells = <2>; > > + status = "disabled"; > > + }; > > +}; > > > --- /dev/null > > +++ b/arch/openrisc/boot/dts/de0-nano.dts > > @@ -0,0 +1,54 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/dts-v1/; > > + > > +#include "de0-nano-common.dtsi" > > + > > +/ { > > + model = "Terasic DE0 Nano"; > > + compatible = "opencores,or1ksim"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + interrupt-parent = <&pic>; > > + > > + aliases { > > + uart0 = &serial0; > > + }; > > + > > + chosen { > > + bootargs = "earlycon"; > > Do you need this? What do you mean here? I want to keep "earlycon", and it is not supplied in de0-nano-common.dtsi. > > + stdout-path = "uart0:115200"; > > + }; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > Missing blank line. OK. > > + cpu@0 { > > + compatible = "opencores,or1200-rtlsvn481"; > > + reg = <0>; > > + clock-frequency = <50000000>; > > + }; > > + }; > > + > > + /* > > + * OR1K PIC is built into CPU and accessed via special purpose > > + * registers. It is not addressable and, hence, has no 'reg' > > + * property. > > + */ > > + pic: pic { > > + compatible = "opencores,or1k-pic"; > > + #interrupt-cells = <1>; > > + interrupt-controller; > > + }; > > + > > + serial0: serial@90000000 { > > + compatible = "opencores,uart16550-rtlsvn105", "ns16550a"; > > + reg = <0x90000000 0x100>; > > + interrupts = <2>; > > + clock-frequency = <50000000>; > > + }; > > +}; -Stafford