public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: fix sparc32 tests with -mcpu=v9
Date: Mon, 5 Jan 2026 09:31:19 +0100	[thread overview]
Message-ID: <aVt2181zh7Ypj0mc@1wt.eu> (raw)
In-Reply-To: <a1bfcb7c-7fe8-4206-ba17-4ed68493de7c@t-8ch.de>

On Mon, Jan 05, 2026 at 09:19:16AM +0100, Thomas Weißschuh wrote:
> On 2026-01-05 08:44:50+0100, Willy Tarreau wrote:
> > Hi Thomas,
> > 
> > On Sun, Jan 04, 2026 at 11:14:13PM +0100, Thomas Weißschuh wrote:
> > > Since LLVM commit 39e30508a7f6 ("[Driver][Sparc] Default to -mcpu=v9 for
> > > 32-bit Linux/sparc64 (#109278)"), clang defaults to -mcpu=v9 for 32-bit
> > > SPARC builds. -mcpu=v9 generates instructions which are not recognized
> > > by qemu-sparc and qemu-system-sparc. Instead qemu-sparc32plus and
> > > qemu-system-sparc64 with a 64-bit kernel and CONFIG_COMPAT are needed.
> > >
> > > Rework the test setup so that -mcpu=v9 also works correctly.
> > 
> > Hmmm doesn't this mean that we're now unable to emit proper sparc32
> > instructions with this compiler ?
> 
> That depends on the definition of "proper" sparc32 :-)

For sure!

> Jokes aside, that compiler still supports -mcpu=v8 just fine,
> only the default has changed.
> 
> > I don't know which CPUs the kernel
> > still supports, but if it still supports these old SS-5, maybe we
> > should instead pass the correct -mcpu to clang so that it emits the
> > expected instructions, otherwise we're just hiding the regressing by
> > upgrading the test machine beyond what the kernel supports ?
> 
> The 32-bit kernel also runs just fine on QEMU SS-5.

OK!

> My reasoning was more that we now test both the v8 and v9 code paths in
> nolibc. But in the end it doesn't really matter, as it is the same
> kernel interface for v8 and v9. We can also just specify -mcpu=v8.
> I'll do that for v2.

OK thank you for checking and explaining!

Willy

  reply	other threads:[~2026-01-05  8:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-04 22:14 [PATCH] selftests/nolibc: fix sparc32 tests with -mcpu=v9 Thomas Weißschuh
2026-01-05  7:44 ` Willy Tarreau
2026-01-05  8:19   ` Thomas Weißschuh
2026-01-05  8:31     ` Willy Tarreau [this message]
2026-01-06 11:40 ` Geert Uytterhoeven
2026-01-06 11:47   ` Thomas Weißschuh
2026-01-06 13:36     ` Geert Uytterhoeven
2026-01-06 18:32       ` Thomas Weißschuh
2026-01-06 19:34         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVt2181zh7Ypj0mc@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox