From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A7CC42049 for ; Mon, 5 Jan 2026 05:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767589868; cv=none; b=VwmkdW+gUusCxzNaNPdaHoyrwShhplUSvCx+isC6ShHeXMGlU6RkzkNCWm97cYrbxP70Q449+yZdAJAhttYEJdcffdXg8/ixQzLWFXyj39bRAHP/Iq63yBGXRTm2I9LtLzjoHxmefjgurapO3sNcvUoOs3YeXsEhfLp7zjwC1/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767589868; c=relaxed/simple; bh=WF9Sz2IhN9bGLIbLOcwdYrTwvywEFHkO5vlzbir2gEQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QWQiewWrMuRPpbWqg3fIgJsRYJJYIw3OgnIMURB9/B0K3SzY/hhS28oX3MZpdpGViFXx4nN56w5RcAyykqT5EJ5fzwCMISDj4VOEyg2tXJmWabuwkTXOOE/r0ogdGg0ny4+fUaIKyfxa9lWTMzcku+CpLUcaxsAM4pzGjZxHsws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Bei2fnu7; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Bei2fnu7" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a0d06cfa93so155315ad.1 for ; Sun, 04 Jan 2026 21:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767589865; x=1768194665; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MvpNrM6V6EQoznDW/e/eykjEU9kcBlSrOOOQoJkleao=; b=Bei2fnu7zTY9TawBGSPqwf3bFtvy+gFVtdDwix7xrVw7w4JlLWK6k+kc7q5E9LfCHt bk04gME564UwrMdANzs7Ea2oiJ/0HWcJdNctPorINuox7oCsDyGux/lYmc20jkruhIZ+ SJ5epOA11SzQzCIgi7K5ySPMLOTJln4S4y8xma+s/LrkcIARpWrvFAon07BxZb/Vlh9A l96WjmrjeQc/83lUEay1F/GloK2UJuQr8JxoRXnm06RKNLRTE4Y1iQm96ISwKwpCypei zYfq+WO8D8EG6wvo0MeH2NevX/wo7ntFPj6SCwzwoSviOAhQO4+VdWj2txcPv8bc7dC4 JSWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767589865; x=1768194665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvpNrM6V6EQoznDW/e/eykjEU9kcBlSrOOOQoJkleao=; b=eebvnVqNu48rE4toDw0eD+fS+NFw4RlUPRyNTkUb+iJMGeS2Sx55vLErCKrsqxjNZH 3BPjMeeLQZU0LY3X/xgQCeOz/Z/3S8S9x0d0n2C6G7tCTgQroNuHCriuKMVyXO3luV2J Th0K3R+W3aHbyn0zVx/rT63uT2+Xrq6SoiG4uvMhXZNRDxFuT5ozX2TZxgiC5rjpczEX arieMGGQ0a7SezxAtbdAbxWKjvqbxSQWwA03uNmRwWFOmawJRKWyau95TrTGMbxmbAU/ v0YWXzJn48bNqkKhgPH68fywggOZzhMi2Qc3bD8si9yaSShzmqGKvuixiBSopjRJvmfu nrBA== X-Forwarded-Encrypted: i=1; AJvYcCVU4HlFW5c4r/wIGx90/8vAdLtz3nSYySMfr/ZPRcNnJWUBn7qCo2dxVt5Ltf785JSLgauhyW9TiN+eeaM=@vger.kernel.org X-Gm-Message-State: AOJu0YyGWFRlmL7xx/kXolDsQWLV2gHdjJ0ft6ZfbMVA7JLH91h0GnPz I0odqzK8CL0UPzBTsVTlEPsilFtf8gSspRn3PCGk3TjEDz3Dxxr90HUnafYtWxocBg== X-Gm-Gg: AY/fxX4z4jMfNFttxRJwSb3tlV9n8ovo6TQ26p7io4KqKDMb9vlpJ6FGObUPV66myRO aRbySkSOAXHANg4xyJ4TITB4Xd39qIutDopt6I7swVOAG8B+CQt4ANioFNr+oIJDAuluhR3R/o6 N5HailPwBTNrsML+YDBgyXFPKjg7T2xROZemPXTYKFDI83tJvDhvD+sA6C2x+eCoKrL0eXkpunO RsYnoQRLKFU3jshL5wUhmpy1Y1Kr9IHgp6XyPDLOf8xiQEnO72MDoBBYGh6k6RynFy1FE/D9v5h feoOAW52RmXT1RFV190tvjOkqTLBfkPAgHjd9dbdFFx9N/NsQkLqIoszJUa4TV7GkAKJVIfPEgh MlPcWS5mkkumDOTMwhdG14K3UaZzfoE/dyfmfyy3yHVoxiiyZQac/gCxqEl7Eyky4tTT8SZKskS u2iozpxW6y3/K6KhsjjN2wqLgEKU/CxL6oE2HEO2aNJTXDW4F06iRBf60jZyouQTw= X-Google-Smtp-Source: AGHT+IH6GRc2aKx9uWPc08BhMYf4GulScHtpZeTvi1OKubAvka4Vbsx4UDJ2sIYfstiF5FDYFBSb0Q== X-Received: by 2002:a17:902:d4d2:b0:26d:72f8:8cfa with SMTP id d9443c01a7336-2a3c3188ae9mr1797925ad.13.1767589864039; Sun, 04 Jan 2026 21:11:04 -0800 (PST) Received: from google.com (248.132.125.34.bc.googleusercontent.com. [34.125.132.248]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7ae354easm46697199b3a.16.2026.01.04.21.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 21:11:03 -0800 (PST) Date: Mon, 5 Jan 2026 05:10:58 +0000 From: Bing Jiao To: Chen Ridong Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gourry@gourry.net, longman@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, david@kernel.org, zhengqi.arch@bytedance.com, lorenzo.stoakes@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, cgroups@vger.kernel.org Subject: Re: [PATCH v4] mm/vmscan: fix demotion targets checks in reclaim/demotion Message-ID: References: <20251223212032.665731-1-bingjiao@google.com> <20260104085439.4076810-1-bingjiao@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 05, 2026 at 10:48:09AM +0800, Chen Ridong wrote: > > cs = container_of(css, struct cpuset, css); > > - allowed = node_isset(nid, cs->effective_mems); > > + nodes_and(*mask, *mask, cs->effective_mems); > > Why do we need the and operation? Can't we just copy cs->effective_mems to mask directly? > > Per Longman's suggestion, name it cpuset_nodes_allowed and handle the filtering in > mem_cgroup_node_filter_allowed. Please keep the allowed nodes retrieval logic common. > > Best regards, > Ridong Thank you for the explanation and suggestions. Patch v5 has been sent with the corresponding updates. Best, Bing