From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6E5322C77 for ; Mon, 5 Jan 2026 05:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767589710; cv=none; b=ocITuhpjsFfghYcsaiGJ03OgraktX3cUwjxxA4guEqkr2V2IpafXFc3rRtQ2biMPWi7PuebpsuNjbCYCN8sjgnHCD7zBV5a5hlWmdyrVqQxerBtDB8GOtr6EJYOUq2xYM3Oecmkvkz0ShgNQTBmDCAP1xfI5zuiLkDSB02z5Bgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767589710; c=relaxed/simple; bh=+04wm1UCl9KIPAir4UBfGkCW95fMzLVX25tujB/CHaE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=md7Al505xKQbnCxxzcYWnJHn+5a6c5PUA/6/RjV3TRQUL3iinuz0skvB25CjkIdc/mUoPOG1QTfruvAqDkIfAkvNFk1dXXuoahKmbLdurTxw3v3rt9ofT/zdmj+5zx9vzHog98GHXWHXLrAyQsHDep4php8Q1S9Vlmkp7LX4XRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DPaiStXi; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DPaiStXi" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29f02651fccso182045ad.0 for ; Sun, 04 Jan 2026 21:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767589709; x=1768194509; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cd/jk1OYxxJI0FgFMQ/4AyHrYlkj9I7IC7MmkMckJUw=; b=DPaiStXiDdhK0IAmGdPW26fTWKcqh4zHghzWxl9tUdkgj8/rq9wch0djy68zV0cLUm 26BNMTGsQSzm+CzSdF3wpTH1NPq5aCsblbiSyv4S4G00LUNNGclo7nDVutFoXy6otyFp N4OJsw6SXiwoWJrimyIEW/dvEv133VFy7yR2QvLe+RBMPh2/5hSTa5Iy1vtBj0SlKWs5 fLjtITG3MD/PX+CT5M4vzQG3aYPO5Y+o7e9eY6G4Vrb4yRn8Bd4AYQvvnwWogGbqDjeg ZVVGFi9OLolQuEjYEKAWH0W0ifrBvq00cz5KYgnSdHjmqaWLoGaY9QPIlXAiW76pZQXR fIgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767589709; x=1768194509; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cd/jk1OYxxJI0FgFMQ/4AyHrYlkj9I7IC7MmkMckJUw=; b=jIXoC1moWo4VNtMpPAUxi6veNLewsLtNhnp1E07JNBeubkxnx02NEfRe7OZKenY0S2 4LGZhQscaFW9bhb3OX44nwQuMdLPi1SMG0r79bdHB9YkVhUlrU0kDHAB2rE2j6ufT315 SvftST7tQDnMDgoX3adBMu4GaEFzf2sJAQaOHSkq6qCAOqZuSdVPq7nfaxc+wSnY3hwQ wOS6+7srCi+sOm/56kQMmmSdTxaQ188NteVlHyoDc3vc8RHlXujmOb6pyGz3qfOzqOl9 914OadeT/k05+h070kiMt189jG6M1DUUBC4nFNY1NsAvCGF+RaTZa+6hs/up83OnRFyu AhyA== X-Forwarded-Encrypted: i=1; AJvYcCUM1plajqBMpJSX75Mrz0FSJSLVce7yA9cDjr39I/z2odIXlW+lhilJro+IsXgxNo5ZgHMvKfjiGOJzyVk=@vger.kernel.org X-Gm-Message-State: AOJu0YzEPbJsE8yE0tc0qVnZEkaVQleS5yvgoZXUVOK4R78iYpNZssYB MfmRZHFY3TysHFLTyBwzZ77sdGDwOBGwW/gLuf3eaI+ZCOHXtvZeTGaURV51fDzV0vV5Z7hLzkP yUUUyGw== X-Gm-Gg: AY/fxX7lVqA3HNmlMXJHCp5yeO3CVMxHAV6fvAuqoj91tflGrUBV167lEd40kB81FyA V5MxY9kFgF9teVJhJj0TcuAaGpxoVFBg3cPkP6rbl5khWEpgUQ3kEyydRVXK1OicPH2zSZaedaA 8X8F6VuiRBamzGOkJjl6C7l15MBTomO7LMYNZ4n+xSX9rANLEgN6h/1SlVpoIDRV6LCDSSkLjgi USMKP3Vf5v1fPR7w4cGeGxxnci9tvRQD/uBGfeI7xOeJL+CCHqKHCDskISUFqloe0yQFm9Ru9Is 98rgpOVfzEuOOhXuYyGkwTqQSjXodjwWfQSsPoaqn81WDU1dTqhsHe7RFzCW6FVpYddKrU/iG4C iTfqs83maMnft+MdyuMBO7RMLkP6d84dLSrvUj81q224tZqVVYBrJgZnYvz1g/eGprcSayGp2o0 PCHr3zV+ZcRVJ4V/KEoGI2KMCUNAoQaz/ms/XTCbDqkrUvumKRJKwn X-Google-Smtp-Source: AGHT+IGk8Jm8wNCmyi1j3iw6iak7/1We7ESwQmtL7zKxxPgAfcDGUZnYJOZFjtq1xd+E+EX1n5ZlNw== X-Received: by 2002:a17:902:d588:b0:29e:27f4:bac0 with SMTP id d9443c01a7336-2a3c1c161d4mr2381045ad.16.1767589708401; Sun, 04 Jan 2026 21:08:28 -0800 (PST) Received: from google.com (248.132.125.34.bc.googleusercontent.com. [34.125.132.248]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f45bf6f1dsm3187814a91.2.2026.01.04.21.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 21:08:27 -0800 (PST) Date: Mon, 5 Jan 2026 05:08:22 +0000 From: Bing Jiao To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gourry@gourry.net, longman@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, david@kernel.org, zhengqi.arch@bytedance.com, lorenzo.stoakes@oracle.com, axelrasmussen@google.com, chenridong@huaweicloud.com, yuanchu@google.com, weixugc@google.com, cgroups@vger.kernel.org, Akinobu Mita Subject: Re: [PATCH v4] mm/vmscan: fix demotion targets checks in reclaim/demotion Message-ID: References: <20251223212032.665731-1-bingjiao@google.com> <20260104085439.4076810-1-bingjiao@google.com> <20260104102745.cfd4f6bd661e8e817afcdba8@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260104102745.cfd4f6bd661e8e817afcdba8@linux-foundation.org> On Sun, Jan 04, 2026 at 10:27:45AM -0800, Andrew Morton wrote: > We'll want to fix these things in 6.16.X and later, but you've prepared > this patch against "mm/vmscan: don't demote if there is not enough free > memory in the lower memory tier", which is presently under test/review > in mm.git's mm-unstable branch. > > This seems to be incorrect ordering - this fix should go ahead of > Akinobu Mita's series "mm: fix oom-killer not being invoked when > demotion is enabled v2". > > So can you please redo this patch against current mainline? And please > also review the "mm: fix oom-killer not being invoked when demotion is > enabled" series to ensure that things will work together nicely when > that time comes. Hi Andrew, Thank you for the detailed explanation. Patch v4 has been sent. V4 is patched against the mainline. Tested on both the mainline and mm-everything (after Akinobu Mita's series "mm: fix oom-killer not being invoked when demotion is enabled v2"), and passed. Best, Bing