From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6619C286408 for ; Mon, 5 Jan 2026 12:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767615782; cv=none; b=WVF0gQEbslbTysvZIORkuN//+uo4QlBfFzwa7xfnCloetbiVtTbqRjnLfu4Ozl/QJ+c0UqnvoB4QafTUPD+IdYbEm5M5eSkLM2KKIhWlYSUI/TGDDU+z2qC+SzYv4/mz/GX07nJYRK2nn2EM8LqJR4VyvEpzvnK+I1wDjzYLxXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767615782; c=relaxed/simple; bh=CRxNMYPdimaY9e8J/cfeL+jPUPoY7Kuuaa/d6b0oOVc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VnoytBs2/3u7dw5jDtO77iV31PAas2Xv6NgntLIv4slZREiS9ZiqqGC0PP2Kb6nqdQWxskImCdriMbKX4Zs1msvWik9BKD3q+nEb9l5jS/3fSOxFd1bKzOg0A8gP0LRK3B1h8ph8m/rpkEyk6KsvtNdJ6vhBbw/ho7zyzIMiAG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=fail smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=H+0qiyXm; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="H+0qiyXm" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47d59da3d81so8065275e9.0 for ; Mon, 05 Jan 2026 04:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1767615776; x=1768220576; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rDjr7sjCBTGkDF0qNYJvmYk50F7qRRVcJ9woEM6oAYE=; b=H+0qiyXmrVvmNtTMZeO4UhmbzhqS+ZNtcXiCxdsexmwXK33jj84bdSPgj+3ZWH65Bu QPYOtTKtjZz7cN/1DE4eF645Fp7lS3hHKYtPiT5gYcohNfoi8whcGGXVWn3AMLv44NXm JGd/DM0iiH6h3yPrWhUhXQIeNzTvUkDuMeXGNDcaphPBfQ6rcfZLKncPTxMakHn7AP1W jUvnjrlm0gnwL6geqwb6Yk51P3yYYOv+8PgD2kw7CzOLzbvu1aRL6HjdN0kqTO/v3Eyd Fxyh9eGeOdBxy/nIfxFt2Nb2YAi2A4vCuJZq6eHKVjdL8KkbyvAKMgCX++uQVOE+g3Xx gv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767615776; x=1768220576; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rDjr7sjCBTGkDF0qNYJvmYk50F7qRRVcJ9woEM6oAYE=; b=bIjPqbFjhIujDJgWfeBbXETw9mIs+LtOX+y900lwcaJkv2XdpODZrLL5/JeXXTF7qA ++AeY1pWutzPt7jCtUYlQhat4/4sKhNNSUien9+ihEffzNIhBnG0KYiSZQFPBbDON39C 4BUt2CeSO6xBFIRlUmnz2yiWegp3ICLT6mfh+xNoxVUnwhuYqpmP/FDvodm73t8JoJam Lf2q/un/qM3Cb91zFLHCtlPgZhiWMrTMEu57SUM3aaHzx1tA79CI5bLUJ+zUd3LtgieD zF+W+afW6H23NEtQxbKMtNM82UGVNSNw7xyEQGOugvWS+p8ZgOmnw3gdKy12Idm7ek1D ayqw== X-Forwarded-Encrypted: i=1; AJvYcCW0ikjwTJPbeS3SWn5icTKZ52rJmI8GhWQQZ1JAlGcz7QIojwQYhuHgu93Kv9guvV1bjD24jPsLLTWShrQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6unZhT4qtdPIt5dYXu8s5HTFURzOkcPuiIw/1mb8NWJS436Jb IEreScae42Tu6UHm7pR0Wdw5SVj39amCN6JnU06tardPgDXchVS7P98yPC4bSDyEe/Q= X-Gm-Gg: AY/fxX6I3X8rQDtWtA7PqZHhfjMgZSN+SnwuuDr5NdWxyyL+38vLXcA7AqujZF+qq/g G71MY/WePOGh6K/pzuY6W3d0uxyVzBKIxNlGE7dQcNh9f4W/l6T/brymez7TROhanTAP7kfpFpG 5//8OnonWftw+o+Ew+EjpCFNnpOCCEhPcRilSgjJX7RzbaxlPI4zVy67F+FPOIV4xwaIIQfNda/ mlaKKx8QA0M1SFMCpWnQPIlO5ZYSZBFdRZelzrEOzyhVRkwNR8WQmTDAMm5/0tYWSNhIpKzSeec E5w7rT4cbrXdji4nRvsVZxuVJ1F8RK+HDf6HGNcWapezPEUypqvB+XrruTuA06klafAHiniR6wL 0XaN7+YK1SkOI6dFWjNq1PMMYA0dCLgj5YX9SMxPmxptZ+G3eKHo0sljbJnrg594plxMWsq+3X3 ktLBTdOfL5powy7HQx6xDxrVkAlhXpdY18/Po= X-Google-Smtp-Source: AGHT+IHeC7mUboBRlz7N9ZYgFCvggY5aIL7EnfSyiNx0ei6dT1WAdqZGjNK1YMGVuVNtrTLRGbVA6w== X-Received: by 2002:a05:600c:4704:b0:46f:a2ba:581f with SMTP id 5b1f17b1804b1-47d6ba8900dmr108543375e9.16.1767615776595; Mon, 05 Jan 2026 04:22:56 -0800 (PST) Received: from localhost (109-81-90-116.rct.o2.cz. [109.81.90.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d6c0c62c8sm54656705e9.19.2026.01.05.04.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 04:22:56 -0800 (PST) Date: Mon, 5 Jan 2026 13:22:54 +0100 From: Michal Hocko To: Dipendra Khadka Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, shakeel.butt@linux.dev Subject: Re: [PATCH] mm/oom_kill: Remove unnecessary integer promotion in format string Message-ID: References: <20251230123336.ef33f8a55df71f3e3f782532@linux-foundation.org> <20251231122117.7683-1-kdipendra88@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251231122117.7683-1-kdipendra88@gmail.com> On Wed 31-12-25 12:21:17, Dipendra Khadka wrote: [...] > Checkpatch flags the 'h' modifier as unnecessary for this reason, > and many other subsystems have moved to using %d for promoted types. > Hence, I think this patch aligns with kernel coding practices. And here, this is the actual argument to push change like that. On its own this is not really worth it. But if there is a general push to remove %hd then sure change like this makes us closer to do that and quite honestly I am not a great fan of %hd. I will not miss it. Please update the changelog and then feel free to add Acked-by: Michal Hocko Thanks! -- Michal Hocko SUSE Labs