* [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach
@ 2025-12-30 21:17 Aleksander Jan Bajkowski
2026-01-05 14:49 ` Antoine Tenart
2026-01-23 5:59 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Aleksander Jan Bajkowski @ 2025-12-30 21:17 UTC (permalink / raw)
To: ansuelsmth, atenart, herbert, davem, vschagen, linux-crypto,
linux-kernel
Cc: Aleksander Jan Bajkowski
During driver detach, the same hash algorithm is unregistered multiple
times due to a wrong iterator.
Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/crypto/inside-secure/eip93/eip93-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/crypto/inside-secure/eip93/eip93-main.c
index 0b38a567da0e..3cdc3308dcac 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-main.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-main.c
@@ -90,7 +90,7 @@ static void eip93_unregister_algs(unsigned int i)
crypto_unregister_aead(&eip93_algs[j]->alg.aead);
break;
case EIP93_ALG_TYPE_HASH:
- crypto_unregister_ahash(&eip93_algs[i]->alg.ahash);
+ crypto_unregister_ahash(&eip93_algs[j]->alg.ahash);
break;
}
}
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach
2025-12-30 21:17 [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach Aleksander Jan Bajkowski
@ 2026-01-05 14:49 ` Antoine Tenart
2026-01-23 5:59 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Antoine Tenart @ 2026-01-05 14:49 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: ansuelsmth, atenart, herbert, davem, vschagen, linux-crypto,
linux-kernel
On Tue, Dec 30, 2025 at 10:17:17PM +0100, Aleksander Jan Bajkowski wrote:
> During driver detach, the same hash algorithm is unregistered multiple
> times due to a wrong iterator.
>
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Thanks!
> ---
> drivers/crypto/inside-secure/eip93/eip93-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/crypto/inside-secure/eip93/eip93-main.c
> index 0b38a567da0e..3cdc3308dcac 100644
> --- a/drivers/crypto/inside-secure/eip93/eip93-main.c
> +++ b/drivers/crypto/inside-secure/eip93/eip93-main.c
> @@ -90,7 +90,7 @@ static void eip93_unregister_algs(unsigned int i)
> crypto_unregister_aead(&eip93_algs[j]->alg.aead);
> break;
> case EIP93_ALG_TYPE_HASH:
> - crypto_unregister_ahash(&eip93_algs[i]->alg.ahash);
> + crypto_unregister_ahash(&eip93_algs[j]->alg.ahash);
> break;
> }
> }
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach
2025-12-30 21:17 [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach Aleksander Jan Bajkowski
2026-01-05 14:49 ` Antoine Tenart
@ 2026-01-23 5:59 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2026-01-23 5:59 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: ansuelsmth, atenart, davem, vschagen, linux-crypto, linux-kernel
On Tue, Dec 30, 2025 at 10:17:17PM +0100, Aleksander Jan Bajkowski wrote:
> During driver detach, the same hash algorithm is unregistered multiple
> times due to a wrong iterator.
>
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> drivers/crypto/inside-secure/eip93/eip93-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-23 5:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-30 21:17 [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach Aleksander Jan Bajkowski
2026-01-05 14:49 ` Antoine Tenart
2026-01-23 5:59 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox