From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDEFA43C04E for ; Tue, 20 Jan 2026 15:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768922080; cv=none; b=aV0hDYCS8KIOAk2759Rj222Kf8L0WeRxXB/3au5I/iinbX5bHaOEPr6O3eSvQw9Bxkb16Vc8t6/DSzEor+JI10NQVfFISwA6CpvtGAHWkZV/Lp7Xjuvi0+CNGzkbnvtH6ojeOaf14vwUJxM4itmAgMMeRK5lowYu8gMo1ML5ovY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768922080; c=relaxed/simple; bh=zctGoCy9tj06FxCF/1MEy/+RkDyWDn4JObiaM6T8qrw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tv7c3ElqWOO/PuoEFt7xXLoJdlb3hS3SgUR5Laj/gyrOZlQsLf/ubG642UeHj87Ayc7mrVUzFxBEJ1DMxQjzYuJbeBAEbe2RzhUaajesN3c6dn40FYP1Cls969LuYIipa/bAfCxQBgEpRFNnKkn5X4cgQJjfvYbK96UGJcjnyn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fuiLwAjP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qIejbGZg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fuiLwAjP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qIejbGZg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768922078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fMaak1xtD3IGbAXkM0qNP33HT0c4dctivzgnO4kRoKw=; b=fuiLwAjPxBZGII2j56pSln4Yjhve0q/0dE8Gk6brgciI0vRElg2IAfqJj7PsLXaOZ62cPl 1zW+i5fu9cgL+dFiXFAJK9+YSLigKrZ7eaifeMpLGkuoP/vTjmSY1kLL5/nfExJq6WbU5u dpG2QKj7mKbSLCEnfVj1bUFbFVPX+J0= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-v5YTfjyROpSn6oVnfGp10A-1; Tue, 20 Jan 2026 10:14:36 -0500 X-MC-Unique: v5YTfjyROpSn6oVnfGp10A-1 X-Mimecast-MFC-AGG-ID: v5YTfjyROpSn6oVnfGp10A_1768922076 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a2cff375bso125674146d6.1 for ; Tue, 20 Jan 2026 07:14:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768922076; x=1769526876; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fMaak1xtD3IGbAXkM0qNP33HT0c4dctivzgnO4kRoKw=; b=qIejbGZgKamY4rFzHLL83mnZxmxYlNkYzHuhzFCuUmVKbQMZDQKvJ7sRI0bwumDziy pc9UXdCLKaDNL7g09rIc5uT9boJoTG85cffw/xUmrm090O6wsQl6tH00NOC9tdZFZuGD kRDPdGeO1zff89wihMvd4J4xigGh1kaS5weMQyueaaVsq3gvf0tzS5FfS2/1CeGOSmfd n0khonoKHvSM55rdEmANHcksCKRif0/MewXEcjVJ8ARWfnZMHW9P+c9tqQ0/FIgVtqO+ PKQ+G0qhDaigWjHUefdedvAKo89+h8Yla13NmkKSapxsJOQ3naP+qQgnX0q6ek7M+oaf BdFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768922076; x=1769526876; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fMaak1xtD3IGbAXkM0qNP33HT0c4dctivzgnO4kRoKw=; b=i96QYT9SHXVsg+Rk591kN0JlnMDAYYDA0sNMIySjOyevUtF0Uc6U1IYar6PYdKCmOd dJvZ291TbecSREAqIvPQ+oU8yv/UDoqNbJvC1lYPgdTc3YW1P4uIq4vt+9QwjKJ48KCt CaeRFggdqxrNfCLDcoR0JS4/ZA6AO6d7v2Bdy7Ok+UVWHM506FWLzRNCGxWpvCeEuCaE qE2GRtKbdMlVpwg8w9a3RfID8ohy1tddnC3+Lvn/1Ix4tp6eJIqH9Twv8NwKl/qcq16S vCM1T8jkziyA9zFMjvWsDjWsUUI2ejXTOPs+o0kzwXG1j+pVuhdZO7gqX4LWt1lfA7fv Rx9A== X-Forwarded-Encrypted: i=1; AJvYcCVezqyrjKtZxD3b0537n9xEnsEo9CpK2L5SN5DkPBWhc8inCsKAgSKd7i0M4MKN5erTpC8oFNnydPMb2fg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1pde/c0zVGur3u3lc2HqFMB6ylmkHkQNyKU/DwBQMAswA5cZk RbslFcoxXv6Eba1ABKTmwzzk4KYWpUV4K6rWdferoqAUF/6Svp6zOifhgE5wCgwrdheWp7CbSqH Tyw6BgHlNQNmbVBQZq12mYqUORaxLPDnK3hQeyyQrxq7yPE3K+HoxIa2N2w211RcdVw== X-Gm-Gg: AZuq6aIR4Dt7JdOKmTvZIwPGGYe0HHCf96Guw7Re+zfGx7eybVsFLIOeC01R0zcqu3x WtEhLWHIMptvFRVJD8jWxa+t6VPU+SINt2qSipYm/UNx9M5O+c6akpZ9b4aqcCTHSquHbaDBRvC ceIArkDK9JB9UKuV+LoyuXwigGR1JdSYbNfJJh5eE9j1uAuqBBMQxBakQGAyvQah7rB1A5YU1NA ER21lm3FYmCOP4qb/KZtQZrBPos+g+vJwoW3WKNHrUxrSFa84pIvZGO7GK2FV/2S34Du94ZfBzZ q97fLXrRKkmZVyYEDa9XHLeHs9joAHbv74F6RF03Os/zwWwbUQJq3zVujbRJHU8fxbfYVDRW7WN rcjStKb8O0E3K8hG5xxEZsxRJ+ItSEcOky+piEXSjrR/U X-Received: by 2002:a05:6214:1cc9:b0:88a:3b1d:2f70 with SMTP id 6a1803df08f44-8942e0c3442mr216662396d6.10.1768922076101; Tue, 20 Jan 2026 07:14:36 -0800 (PST) X-Received: by 2002:a05:6214:1cc9:b0:88a:3b1d:2f70 with SMTP id 6a1803df08f44-8942e0c3442mr216661746d6.10.1768922075621; Tue, 20 Jan 2026 07:14:35 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e5e49f2sm109107766d6.6.2026.01.20.07.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 07:14:33 -0800 (PST) Date: Tue, 20 Jan 2026 10:14:32 -0500 From: Brian Masney To: Bjorn Andersson Cc: Dmitry Baryshkov , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: gfx3d: add parent to parent request map Message-ID: References: <20260117-db820-fix-gfx3d-v1-1-0f8894d71d63@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) On Mon, Jan 19, 2026 at 09:39:30AM -0600, Bjorn Andersson wrote: > On Sat, Jan 17, 2026 at 05:54:47AM +0200, Dmitry Baryshkov wrote: > > After commit d228ece36345 ("clk: divider: remove round_rate() in favor > > of determine_rate()") determining GFX3D clock rate crashes, because the > > passed parent map doesn't provide the expected best_parent_hw clock > > (with the roundd_rate path before the offending commit the > > best_parent_hw was ignored). > > > > Set the field in parent_req in addition to setting it in the req, > > fixing the crash. > > > > clk_hw_round_rate (drivers/clk/clk.c:1764) (P) > > clk_divider_bestdiv (drivers/clk/clk-divider.c:336) > > divider_determine_rate (drivers/clk/clk-divider.c:358) > > clk_alpha_pll_postdiv_determine_rate (drivers/clk/qcom/clk-alpha-pll.c:1275) > > clk_core_determine_round_nolock (drivers/clk/clk.c:1606) > > clk_core_round_rate_nolock (drivers/clk/clk.c:1701) > > __clk_determine_rate (drivers/clk/clk.c:1741) > > clk_gfx3d_determine_rate (drivers/clk/qcom/clk-rcg2.c:1268) > > clk_core_determine_round_nolock (drivers/clk/clk.c:1606) > > clk_core_round_rate_nolock (drivers/clk/clk.c:1701) > > clk_core_round_rate_nolock (drivers/clk/clk.c:1710) > > clk_round_rate (drivers/clk/clk.c:1804) > > dev_pm_opp_set_rate (drivers/opp/core.c:1440 (discriminator 1)) > > msm_devfreq_target (drivers/gpu/drm/msm/msm_gpu_devfreq.c:51) > > devfreq_set_target (drivers/devfreq/devfreq.c:360) > > devfreq_update_target (drivers/devfreq/devfreq.c:426) > > devfreq_monitor (drivers/devfreq/devfreq.c:458) > > process_one_work (arch/arm64/include/asm/jump_label.h:36 include/trace/events/workqueue.h:110 kernel/workqueue.c:3284) > > worker_thread (kernel/workqueue.c:3356 (discriminator 2) kernel/workqueue.c:3443 (discriminator 2)) > > kthread (kernel/kthread.c:467) > > ret_from_fork (arch/arm64/kernel/entry.S:861) > > > > Fixes: 55213e1acec9 ("clk: qcom: Add gfx3d ping-pong PLL frequency switching") > > Signed-off-by: Dmitry Baryshkov > > Why didn't Brian get Cc'ed on this patch? I'd love to have his input. Reviewed-by: Brian Masney clk_alpha_pll_postdiv_round_rate() previously had this code: return divider_round_rate(hw, rate, prate, table, pll->width, CLK_DIVIDER_POWER_OF_TWO); divider_round_rate() called divider_round_rate_parent(), which had this code that set the best_parent_hw: long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, unsigned long rate, unsigned long *prate, const struct clk_div_table *table, u8 width, unsigned long flags) { struct clk_rate_request req; int ret; clk_hw_init_rate_request(hw, &req, rate); req.best_parent_rate = *prate; req.best_parent_hw = parent; ret = divider_determine_rate(hw, &req, table, width, flags); if (ret) return ret; *prate = req.best_parent_rate; return req.rate; } I coverted clk_alpha_pll_postdiv_round_rate() to clk_alpha_pll_postdiv_determine_rate(), and that now directly calls divider_determine_rate(). I'll look through the other cases where divider_round_rate_parent() was called just to be sure there's no other cases of this. Brian