From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11483218E91 for ; Sun, 18 Jan 2026 19:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768763744; cv=none; b=Ax8C9+mF7Lpof4OL2+lLXmCsIUyaNMI5TqBN3pY03yd6icbxV860jmqrhV4hXZMxIQP2wkoQk/qpakn8dVMKERzmMmkfpFVNAPr5qdj97e/cSfeTy+JGxVJElym4LUls7Kc3y0UcglIRf7JTaJGDK5OI3NH+fQ0kYu91uKtg7bM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768763744; c=relaxed/simple; bh=Pyb3ZVCl2W20pvak8WFvwOGzpxZn5BT74Q6321nAW5Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IAvBbTxAqknue8w+FYxMBviv51LDUeOKUfeA8/hZEIjdE4FTrHZLPDXWJTIBbXXhCrF9A+cDs5vy1JYoIA4oeqT/DmXTiT17QGb7DWPZlOsLihUuwou6bqnIm+6/OLL+per2Gu7MkgqXCCE8CZq9SBHWC1mJ7gHy8lp14dqqLYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NlQjcg7R; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NlQjcg7R" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso23570585e9.2 for ; Sun, 18 Jan 2026 11:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768763741; x=1769368541; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g7eq9NZWv+jfQYvwT7GWinc/1t08cW4LlGcRYfwgt1M=; b=NlQjcg7RQyVW0q54uzrAtuGcX90hx6QprhuiRt3t9P/AjAFMZlP7wmQjSzsIBYtZfX GM/OO33XFEpQkUvtRxXGQ1kfK7u4WRdCY6gP/10w6vTh0QtAkaNlPp7k2aJWcufSaKDI OrSZFNydMbd71XaThhKbfloQHyEX84+RMsqplH3tbQudhxi1gXGPzdCVOgsKnE+dNfTT Nw4XVk42UbAEeDgqLFtYaJmST+UxQavGi2hPrDMvqdgIE8WW8y5c5OUgg1+gvWtpTS8g ASXTgwlcQswsa3Fxd7jJ+7v2U5FrDXMkgoHBbzwRQBMDGoc2t5BjlHnVXeC2BLbBQJyZ 5c5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768763741; x=1769368541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g7eq9NZWv+jfQYvwT7GWinc/1t08cW4LlGcRYfwgt1M=; b=Zi61s4hgLBi5xkTtWVL/nwMNcrxk6jwOZjQkG0jLYAPxu4qRlPw8GoHBo2qXN5EVTO 2sJx3c6gOuyj6elTMDdXwaJrYBi609bfF6mc/IhI6NGY6/ieJSbgLSYyRboNQ9dyijaj TZgSqJBTRHhwghhQRKO4yuUj2ao+Mp2ibJhk8pgMRbgualJa/p87Nu/FwnNbweMGZCPp 8azm+jY6/93g6g1/BYtM02JhZz+lsftJWDXXH38m1ZAtEjrroofkoLQazF+Jzue5fc/7 oL3IE+7xGLWpyKhUQnisgnzTTN+ZrZA2/8zg0JMNxKQIvr6jmpdjvskn9k0h9RvOjXp/ 1I3Q== X-Forwarded-Encrypted: i=1; AJvYcCWssm744W4AOAWTm3kyLBF9P3e+qft9PP8CivH95GUTZZP+uV+bSnDrKFI/Z1ikwg9yudLKwzBtTC59lpo=@vger.kernel.org X-Gm-Message-State: AOJu0YyU0Xv9oafUYuOhjvnsDl7/pjHA7wFg7CJroQ+ytfxaQ+HDKTow Uw0iRgqJKDkwbGaRaSGg89jWpohiMt/J0vUxgQ0TmH2pRWS9ph9WNV1vCH8mRz42y9I= X-Gm-Gg: AY/fxX41mKHdCdw8P64wDDNe/s8nHf4T8nIa33AqmcLJR+pEiIAmv5D2QGr7PragHOL 22eypV7cYi2H/zcBOqJo3rOqjN5DykA0Z5mmUFvPZTc7DQIySFS9ZugdPzuaAKQov63yu5+9kX5 KcJnLOE30CAUG5+t7yGkwIVW8ZDq2cOkBTeOH8KPhRgxps6Q0JZhwwY0OBNy8DNlwEFx4JtRU1C 96/LcGXZxbvAq4UoZ5tQcXZBQ62wERICLywLyONirSauQnwc41VCHic+8XNLc9Yz9SG8ypVCltT xUoeg0gPFSyeYXsLo/twy2524KIl5NS3kMCI63yjsi7vZKplpJvT5542Xe44S3jlTbo+/URQii/ FDzLKgJEbKglQJ5jeB87FEE4f1vUX6ugao4Yyg9w83Oy3tliJ2xFBmIiXvYPjXZRD+s9DdN96hs AKWm7sRe2IcXER42Vw X-Received: by 2002:a05:600c:4fd2:b0:46e:506b:20c5 with SMTP id 5b1f17b1804b1-4801e34c9b4mr122573745e9.26.1768763741271; Sun, 18 Jan 2026 11:15:41 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e8d77besm158279375e9.14.2026.01.18.11.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 11:15:40 -0800 (PST) Date: Sun, 18 Jan 2026 22:15:37 +0300 From: Dan Carpenter To: Felix Gu Cc: Sudeep Holla , Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scpi: Fix a reference leak on device node Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 16, 2026 at 08:54:39PM +0800, Felix Gu wrote: > When calling of_parse_phandle_with_args(), the caller is responsible > to call of_node_put() to release the reference of device node. > In scpi_dev_domain_id, it does not release the reference. > > Fixes: 45ca7df7c345 ("firmware: arm_scpi: add support to populate OPPs and get transition latency") > nit: delete the blank line after the Fixes tag. > Signed-off-by: Felix Gu Did you find this issue just by reviewing the code? I read the comments and then looked at a sample of four other callers and none of them called of_node_put(). So it's a weird thing. If this is really the rule then we should have a static checker heuristic to enforce it. regards, dan carpenter