public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: shinsj4653@gmail.com
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, nadzya.info@gmail.com
Subject: Re: [PATCH] staging: vme_user: fix missing blank line after declarations
Date: Sun, 18 Jan 2026 22:24:24 +0300	[thread overview]
Message-ID: <aW0zaMndlZeghsqM@stanley.mountain> (raw)
In-Reply-To: <20260118161954.80672-1-shinsj4653@gmail.com>

On Sun, Jan 18, 2026 at 11:19:54AM -0500, shinsj4653@gmail.com wrote:
> From: shinsj4653 <shinsj4653@gmail.com>
> 
> This patch fixes a coding style issue reported by checkpatch.pl:
> "WARNING: Missing a blank line after declarations"
> 
> A blank line is added to separate the variable declaration from
> the code logic, improving readability.
> 
> Signed-off-by: shinsj4653 <shinsj4653@gmail.com>

Use a real name, please.

> ---
>  drivers/staging/vme_user/vme_fake.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index 731fbba17dfd..55c00e1d162d 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,6 +67,7 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +

This is a bug in checkpatch.pl.  Try to fix checkpatch instead or
otherwise just ignore it when checkpatch is wrong.  The rules is that
when there is a declaration block at the start of a function then there
is a blank line between the declarations and the code.  Here, we're not
inside a function so something went wrong.

regards,
dan carpenter


  reply	other threads:[~2026-01-18 19:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18 16:19 [PATCH] staging: vme_user: fix missing blank line after declarations shinsj4653
2026-01-18 19:24 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-17  9:54 Marco Antonio Solis Segura
2026-03-17 11:41 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW0zaMndlZeghsqM@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nadzya.info@gmail.com \
    --cc=shinsj4653@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox