From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39162335BB4 for ; Mon, 19 Jan 2026 07:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768808098; cv=none; b=q88BECHDv6IUeFmhEhRTfyBIkrsl87jSOImZJCRiUKcwv82hniHVGGec4NH+xuX4BQf1cj6cJ1cAVoN6l2YHKuL27vtUSe4Hz1jY5+YsyTeZza673geJeE1ZpElb6B48aGhIqOmDaAt1KZipyIOr9HB7WafSfy1d9QQ9u2AhXs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768808098; c=relaxed/simple; bh=rqHziA/7ibS2eDUCKz1O/eYFSwdgc+yMGM/SouN+ohM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T+eYraVOBQBema2Rd8pJFQKkNcZIR0A0gICajtGxFhUVe0R7D81SPKYLnOslYDPstDrcX9pMHQVJtGhDAO5DzEnR6mEvr3DukQroFTdcdbqmXxS+glA7DDncpssuAqUB9ausD9qSK9SYaP+JvC9C0zv64qo4k67L1N9Zf0N1NPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zrpTGwF1; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zrpTGwF1" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43277900fb4so2243342f8f.1 for ; Sun, 18 Jan 2026 23:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768808096; x=1769412896; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=obgH7PlnqGdGeYUnWO+UEMNNbg4JwP+SwHiXbmrV760=; b=zrpTGwF1EyyQShDszzpYyp7kJffgZXoucsb7G2+i+x0Ob2t0ulKfMGoDO8L+HlEfXc lxtSzRPaXNiTux2NQ1GHWGKnBwzimWfqyZFyz93LS+mbjtrrtBtxhSGyFzLYNBn5F9Kb KUDzGIWcN5omuJi8Dt7btPICtcwubhx6Y6faLM2O9VsVxyJFxsyMbd/E1G65pNZgn5Sf b1OF/wcCLvqGBVed496hbK+N+CFfdNZ4JZw0IiPfzmbhKfxsKtp883W0HuTX2FzDeWjx JZSsIjyglVNdaNvJ3WZvh6J+5VfEfx62yEtWZK6+BjVfmRT6nG0lO1l/XWVKs6Yc2g3w +Wfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768808096; x=1769412896; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=obgH7PlnqGdGeYUnWO+UEMNNbg4JwP+SwHiXbmrV760=; b=n7/WtNd2njXmD6hIZ4Vu5c8YrXrS3l/7p1YSrtIsko8YPPuHP+bdJwvzKZgBR5RCJh 1wFBesJOu1WGaKXKyBDDn4erZRmoe8cN6hjWzc3+JfRqrB17CfnVlCZt8Z2pSmpy7y5n jkGh4wjZhGbjMmr56SkrkFDVsnLFiD0zuqliabkpXv4Vys4y4mT9rZigWbAUSiqdIS92 2Ezhh7dh7wI2JHUjtgT4hm/CgIgETKfbY2eXB5OZdVhA+WgAElO+uIsjBTBb5NPEUnmI o+xcYnuBstShcpfumvVaXlLzW/KmiOi8XOGNVOwmuWeFsGTjVGeOSPQ/0xrfOQTN+i7W 4C5Q== X-Forwarded-Encrypted: i=1; AJvYcCVJ4gAKHUbv/unj5L7ZN4jd/dezU/nppPmwvjBf7AMZCEl/Xp5aEG2EHH/YJKY64/46rdFG2CGWExSxNjI=@vger.kernel.org X-Gm-Message-State: AOJu0YxOoqhnYnTezvcQGvAO1EaiAL81kdcC57UMXEXSbsnfOIqbu96V aP9Q+sIZsRBR+JNzGbWxuMQc3oMUt/jIMulbFNXbsr7vH5sphFaaRZkpU3mEp9SobWLO+tXpfk3 R+fe2mlg= X-Gm-Gg: AY/fxX7IHWu4SUBFqvNKSO7jNUijIPYtmVPCyhV5IHYk3RJCob4DXaYEx0ZbC5f4KMP Sr3EBalGj891vNXpYx/o3/cvmyrpLSAmrCu2cq740WB2GdJIQIZqY7GHSEwhBRcFWrpc/hNurb+ kB0M8Y4xUqkQFrqFPn66ZaOynKAxB77+zJZvsFfCmInD45xTRTYJbkfA4V5uHsNEzyco+atOK1t Ef1yZ7vTR2J0IwnlQtXFoP8b96hykgGTGLtl2ESQqqyl2+pJ+SudCrw51HCiHRASS8dOedY4zWY 7wL2vAce7B3G0/zcBtSba1poIp26pMQBEqph8YEidAJpfh6fWhgLlhNWN/c70rBgOMd3W4Mzq2k R4wHyqExLYeGKMoqwfF5El+ps7aJHzhhEIQZrqDtYEu0NnDCuE23V32b7/z+bzLk+nibOSPosPM shOOFDqOxYDc9COI8t X-Received: by 2002:a5d:5f93:0:b0:431:f5:c36f with SMTP id ffacd0b85a97d-434df117609mr20139460f8f.31.1768808095597; Sun, 18 Jan 2026 23:34:55 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569921dedsm21291299f8f.9.2026.01.18.23.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 23:34:55 -0800 (PST) Date: Mon, 19 Jan 2026 10:34:52 +0300 From: Dan Carpenter To: Dominik Karol =?utf-8?Q?Pi=C4=85tkowski?= Cc: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] gpib: Unify *allocate_private Message-ID: References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> On Tue, Jan 13, 2026 at 07:08:37PM +0000, Dominik Karol Piątkowski wrote: > Recently, gpib driver got out of staging area. There is still a bit of work that > can be done to improve it. > > Return values for *allocate_private functions as well as calling code in > gpib driver are all over the place. Unify them by returning -errno if > something fails, zero otherwise. Use the returned value as early return > value in case of error. > > Untouched gpib files already use the proposed convention. > > Signed-off-by: Dominik Karol Piątkowski I don't see the point of the allocate_private() functions. Why not just open code it? regards, dan carpenter