From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 348CD3502BF for ; Mon, 19 Jan 2026 14:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768831568; cv=none; b=DkAaBhV64VOgk5JUn5/uw3onRfrO3yOV6visQcFemtM/ds1VsTSv5+uKRvr079SRQdSbQBrf7wuJYn/lp3tkJB2UcFh2d4CMoLRUUDK8ynvKGL8fVdQLh4cM0e011BeB/GqqPOfY7QtBbA6XtaeScxYH/q7kA4EnCYACF5faVOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768831568; c=relaxed/simple; bh=1TIFhdwSDZ6QD66CfltRG+PoG/0eTkIH/qqxll4+wsg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B+6hjh9NX2kMUquB/UKaCka9EeTHb8HZ53PG37ktgJ/ltS69tfhdCttxOmgVi9qPHwF/JyBNIlhOqc18il2bK3/KPzgGj6L21LeEhINkSHX2ERlJ3GKXlYapen8aTrHzXzNGWLSRv7/aqjhyDd0WAdsGLSllFWmX0tDWj2SyXP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dw7/xU0Q; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dw7/xU0Q" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a0bb2f093aso27964855ad.3 for ; Mon, 19 Jan 2026 06:06:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768831566; x=1769436366; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8C6NBmcQAZ3d3uBLMw27Ss27pXnAU6dnFwiydHhLyt0=; b=Dw7/xU0QHRTXvf0pLzdfXqMKHJohp8xnh7JVejJoBpE4Y7MTYU98SScGl/hBl7/xMu DG03tapbs4zcjY/3Ohsl5YhLAhupUZBw0UAln9u3Mxua+8Tbqbn2pxG9vtkvzIxeYZ1b MOUcxK8XbHqp6o2KruTZizvFKHdTMIVNKXtZkdl18Bc6ju3qV8Mk//wGnp2r3rYOrIqJ 2u59lds+4oN0iwNFJeioktKdX203c+W/TNe2IFV5g88VU6czr3irtPgLbKDzHS9uUUDR WIPlvBmCY9DaxIUDS+ga20DIuU5+CV4s/F5M4Oy6F8JWQnwRGWv45UbetFLeOga9HGuX DkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768831566; x=1769436366; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8C6NBmcQAZ3d3uBLMw27Ss27pXnAU6dnFwiydHhLyt0=; b=wy6Rd3wrZKS2SvqwaUh6lTsya0QRMFuudU89U4lE8uW9JAOCjb1syxqWfWnChEx44C TiD21MTmFaDTvJjdc2rrBdJ33J+iBMTHLm9Unjkovvm+JtXKxIwrh7dPpSU28Fbagk5L RKmg7hTkTQf03kryO7h7DZxgv98TA+/7DcPO3J16O0TTZ1sudCYXCI/Zbhpf8Z1PwBPX XVSlL1w+kDLoTTTLByMrLxh0CEVVJm8DOoWLJefh/W9mnVZfCL8vPKQiBuw+mVD9EIQ2 qQkw+18XLCOxfREi1ZzcshH6TtFc1E2b3+j1WhV41eOfTio4t75Je5POWufPPsOIh52O /xZA== X-Forwarded-Encrypted: i=1; AJvYcCUjc/JoNN6RZ+LwSs0N46OwG0fHmxGyaBRGk58DWgZbLhmPYl4RkF1RJVpRQ6ooFotfPKZSON68LPiuKMU=@vger.kernel.org X-Gm-Message-State: AOJu0YxDQzJN/HTQkqlixR1pemLk35BMErRM9Jgbev+fbgJmtXTbLiRG fTgIynM8WuVGIa/RA/SxZP+TFLLg2ogis/pan2kofzo41RaL62YvWInQ X-Gm-Gg: AZuq6aLAKn2ih/0+OxOCUXuBAyjD3UabZn+1F7vMtVyXFkJx9gfbL+u9gLZJ2ow8fkn 57VVxpFtqqqVMR3xHR3LqpSc/tnlsTUL3n8HZZc5uxEdAJd8Gx7E6DyQ2ehlJeiPS2BR+FLhJSj hfkh/SrzEHO8XA/4zLYr0MYPAdEV7gQZq2+CubJWneCvSn2+hGPGKHzeASaYIqqT+xlzvo2v7d9 B0qx9MDZ9QoKyP0oCUXLKAb9ZKcofTZaGwnLXXKOV4OLP0mjpHaRJzZPFvwtldR6jpVLE+FqZf5 x/ecKBcJNo8m+WsFZetNDbgIXxAJPMDYHzlIxOXC732M0k6NN0xwgUkUZ5OSaKW6hFCiV6onh3E RKL/C3RRg09ef2SrtaP0rpq9TzA1aYDGtlm2hKwHtoQW6fhwN2/aoXUF4GzNfDNRMKG7Y+Jtex7 jq1EmUCb5pzTvAnd1OBJFgu44= X-Received: by 2002:a17:902:c404:b0:2a1:e19:ff0 with SMTP id d9443c01a7336-2a7175a63a7mr122447545ad.39.1768831566448; Mon, 19 Jan 2026 06:06:06 -0800 (PST) Received: from google.com ([2402:7500:a01:13a2:be3b:dddf:aef:3f0e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190eeefasm95889925ad.43.2026.01.19.06.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 06:06:06 -0800 (PST) Date: Mon, 19 Jan 2026 22:06:02 +0800 From: Kuan-Wei Chiu To: Nick Huang Cc: Andrew Morton , kusogame68@gmail.com, paladin@ntub.edu.tw, n1136402@ntub.edu.tw, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/test_min_heap: fix incorrect module description Message-ID: References: <20260119113420.2819-1-sef1548@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Nick, On Mon, Jan 19, 2026 at 09:46:05PM +0800, Nick Huang wrote: > Kuan-Wei Chiu 於 2026年1月19日週一 下午9:26寫道： > > > Hi Nick, > > > > On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote: > > > The module description incorrectly mentions "min max heap", but the > > > test module is specifically designed for testing the min heap > > > implementation. Correct the metadata to match the code. > > > > Thanks for the patch, but I don't think this change is necessary. > > > > As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"), > > the implementation easily supports a max heap by simply inverting > > the comparison function. > > > > Since this module explicitly tests both min heap and max heap > > scenarios, the current description accurately reflects the test > > coverage. > > > > Regards, > > Kuan-Wei > > > > Hi Kuan-Wei > > Thanks for your clarification! > For future reference, please ensure your emails are plain text only, without html or base64 encoding. Regards, Kuan-Wei