From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC342368298 for ; Mon, 19 Jan 2026 13:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768829185; cv=none; b=sK+Y46s8v6TT9Ir9hIDuKSo9Ssz6v8srvU6SbPfJ5LXu6lIZE0bj6oY9cryIfIsYyRHLYPjWy7yJlLlzLORUVF9TppLlLhRmgIvi8k+wssy1L8alTi+EazSeFy/odFWgkRlY+BhKLkq/KG4j8+Z82IntnaGRyQXBFYDdWrl95yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768829185; c=relaxed/simple; bh=qE0zjz/FetJxO+4RB95uwVRi6MkaoXk5z2Ej8EoTTFE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hUa7UcWBtK8OJXNBwVhtKHU9WBhkhx/ap4GNbfU45YdteXQ+bSwlAp7NQ0ZQi5fmqnNoNUhGtMM8UTRGpZUdUazmyv9unGZGHyP19y+jcSkv0TOt16KrntsihlEtso+1xthUIvZmnmUek9ZK58h06AhgSaBtTrmjfyxOAh4Xbiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hM63XJhf; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hM63XJhf" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-81f223c70d8so3623925b3a.1 for ; Mon, 19 Jan 2026 05:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768829180; x=1769433980; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iz5QCAgQ6S812Sn1WTY5I/sVGc/9je6vBIs50QLiz1w=; b=hM63XJhfo6T44VgFMljxivKQAgwFlN5kNzuDUE6MDjBK1zXYeFKK/lJNNPPrlGY3Hb 4Tr4hauEdwh9n/aE24XaGxyTHEkeUKeSqujmtXq1EAuzpSmTsrFVdVR1UbTK74e2ay/R fJNG3TuicFT9bc2T3WsqtzXdN7ut9pVoWqmT4qWbF4pfSkzh+x4QlkZTYcrOmKVkxOmf qJ1BGrUdQbLEmeWG6NJS4iX4ihFQKteDX1Kn45wM9b3QuBDSiZyA9f2jP7b/QVPbUA9G 24ySf35A0Ww7kPYL3nexZcYIuuqFbaD7NGhtTRVpjQ74d9mw6L9wWBrwZCZJy6gtJEPp ddwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768829180; x=1769433980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iz5QCAgQ6S812Sn1WTY5I/sVGc/9je6vBIs50QLiz1w=; b=sbHVzhEajgJnj8W+8bMQ1RWDlogYfzZ/XRp6fAtJcnXFcm2Ja5aTbmzH/a1O0LRVoU 0t0O8DlF2PGRzDYUPWybXsvVrHX0dBxCz3AimlO0g53UqChejJ2Ct9hKIfuwo5G1Mtaw Z77L0WXqMYOsfXMxq3WLFzlVeJSShp6HsKQiDqEOEfn0v+qMV4fYhjLRMAEjD94noFMu YmqCQWgoQhY8lNEoXUfzPSISnlGpeZ24XvnY+xTZqA0fHX7oo+OVW7GT/+T40pDZRApe jxp4YJECcLbgbl25ptmrrOUH9XUFKHeuWcLCZQ90C0wV+6aocb9SnYZg/40ZLvos0vrF rgIw== X-Forwarded-Encrypted: i=1; AJvYcCUee8ezotcx3pM9CpUkDF8akmZ3ajvIf/a6E/fpSbMgoIyur5A5ctdx/kyMKmhKnC51NtcTbPRhLkW6Ca0=@vger.kernel.org X-Gm-Message-State: AOJu0YwMzjluAsYteGBkQH1SzkG9wp7xL6MNw+xllek1fzBJahMCBRhC rCUPwnv7tOehZvPFwS2aZxiC35I8zAKT2DeN0PXMhG3NFsGdpZdoWkjk X-Gm-Gg: AY/fxX6APWNXVN91r5x9EO8UAzo4GJIMBwrH1mO643dPep1nGpqVAZl/TUrY+hQWqqD KlUE6Cy33DpzxYF+Ii/HnWAjZ7jJuo1/Bgu0hYsof5/PQnCuh6Iu1dd7Mex8Pwmr8khE1R4rCVe eqqxPraHu3V0pZv3/kU0HApAVXQgBelUbl87GzejPvTpe5KjzsNzOevUD6i6Slyp236hYAE8K1U GVSqJ3kuOkA4zbf855EUiYxALaXQN1kguCOWiTGlsKtRG+dI9ooc2EN7n9fpbEzZutwNQaPv3n3 HtxJFQggsGjnJAkDFPYF8OPW44wy7H3Rm0VQqowBjNUGb3oLIilLthbHDN/aptjPQyGKTsN+dW0 Y/8hak60tXxHdN6BU+A1/h+93/py9cuBHj0/TP2GAANFGDXWs+QO3er/dz9AqIT9LJcxkVRBCOe oILplXhPkncfgvos4j2uCFopE= X-Received: by 2002:a05:6a20:939f:b0:372:18b8:49b5 with SMTP id adf61e73a8af0-38e00bf6c86mr10090304637.6.1768829179979; Mon, 19 Jan 2026 05:26:19 -0800 (PST) Received: from google.com ([2402:7500:a01:13a2:be3b:dddf:aef:3f0e]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf3791e5sm7857697a12.31.2026.01.19.05.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 05:26:19 -0800 (PST) Date: Mon, 19 Jan 2026 21:26:16 +0800 From: Kuan-Wei Chiu To: Nick Huang Cc: Andrew Morton , kusogame68@gmail.com, paladin@ntub.edu.tw, n1136402@ntub.edu.tw, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/test_min_heap: fix incorrect module description Message-ID: References: <20260119113420.2819-1-sef1548@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260119113420.2819-1-sef1548@gmail.com> Hi Nick, On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote: > The module description incorrectly mentions "min max heap", but the > test module is specifically designed for testing the min heap > implementation. Correct the metadata to match the code. Thanks for the patch, but I don't think this change is necessary. As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function. Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage. Regards, Kuan-Wei > > Signed-off-by: Nick Huang > --- > lib/test_min_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c > index a9c4a74d3..9e42a805b 100644 > --- a/lib/test_min_heap.c > +++ b/lib/test_min_heap.c > @@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void) > } > module_exit(test_min_heap_exit); > > -MODULE_DESCRIPTION("Test cases for the min max heap"); > +MODULE_DESCRIPTION("Test cases for the min heap"); > MODULE_LICENSE("GPL"); > -- > 2.43.0 >