From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23E1C231827 for ; Mon, 19 Jan 2026 14:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833574; cv=none; b=glzSpzvS9AaFgSj6sBHaCbQuZ2+bOqyR3PC1oeVWe0BMQN1eiwsC/eKCgZ1JpDcWahhlrMhClZZJmdjNvWQIwv47gxFRnE32wkt86Q+X8uqlZX0aqPvlUDMy6Sm3PQLXJ9C/rsrOGAyGNg9p4hUAYkNKWMTEDlA2ymSioX9vfT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833574; c=relaxed/simple; bh=2dJlh51NJrHUTf0lubg/WtQ1TdYnj9PHI5PYAn7cutk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Txp83Cp37rqUTDGFbrKcc0kGsuUU+7OMIFXoVfgeBsvFknlPdxWJ4rSJuJYGqSqh3/jwfr0lfCdFAa9LCtF5DmJrN0i92K8/Kw1scLxjRt/rSs5DUYc7EPChidYVPSp1Q9Ff4lCsjUeJrxdl7ARXQtrDPmQBaAZSpFbj0PEjNso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Vw298HYo; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Vw298HYo" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-480142406b3so21523865e9.1 for ; Mon, 19 Jan 2026 06:39:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1768833571; x=1769438371; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=C44Hzf/BGJ1hEivAUCRdCyF7sts8+63+SuDB5GtrMgM=; b=Vw298HYocLGGUOby2R/LVDj9JCdtP45KTgKBBxyc8IW0Ntie8X+YOKkmUPAuxP37Qr rHKszYQsmGc1hQJM5cnDRzDiM1ZgnGQDbE4nQf1VF5YAK0JOUPhGouf/cHaL50hOOvMp 8lc3agf1mw5WwaKKtKKpiIRdr2SGqKnBgpvauYpUqUvt6y8mgjOrOWKFSjhqyE3qQ5Rn ttQvuAboQ+UVyEyt4JjRsmhIYcvCXf+ff+sBc7BhlOIvccSTX8ds1srDQqh/v+n1S0Tl pRagfkoyhR7nmFvm+j6CBO3vqK+3Z+0eifieazA1rkWFRO3AzONxJgma/EeOUlVss8FZ e+tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768833571; x=1769438371; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C44Hzf/BGJ1hEivAUCRdCyF7sts8+63+SuDB5GtrMgM=; b=WkSopbuy0NQum+DRKNSL1lqbQqDZH0gNUjPD3tfSiiwfNNIvTZe8jwKd6nOKjHF6s4 edfROpSm+ZJEhMrTGGZUAeoQeaDXywWU46RvdDj6Zl4YhGvbkA4H3Vae8s/p7OAgid6x om+zlazKzaxfx+TCbBkCEwODcw2159Lp5xfHfYNgGc03p/ILFUJ4Wi3OMRxewsrH4lEk 5ecge125lWk3MB0YUSdNwsONvEImCQpGLUMesNLuHny0xZamNatZ2tz1pGpMi32ImHUC TXj6srvOAeRz2GbX1pS8xHY5EUVn+nDmyFxQM2jAPEtOr1SX4eV9KRlcgOCO7l6kbdVz lstw== X-Forwarded-Encrypted: i=1; AJvYcCWzE4Qc9G2xQg1BqyKAZJpvSwrmWMgIKhkNnUE35m6MGOIqQK8NyMefCq6GGtsEt+4R8XzIS0iX/u/67MU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9GQV7fFX1mkwYDj3hg5mFyBvnHRrwt5c/aolTPtJ+4aMeUv8Y 50KWWsjwxPzzltGa5DHpn/UxModRP+hxhVAsHUrWwfzsZJgCBlr3v4HCSjWu+J4AYYByxIuM1EX iCH8R X-Gm-Gg: AY/fxX4TSWK+msk14nVcnQALfhtKTLZZMzHIeEpmpfSspuLjY79EqRKbtWldHgPuVvU 7ldMfqqX+0ezDFsjgJ13Rrs6OMiLYsRWdau1W//KUUcXUDcnVqJJacphoJvyTRG8SMZwWXM1Of0 D34riqWLApHtx8yS0pPu1NA+dCbFhtzAqq3lXwscD6GipN13kkkO1sBkrIhv4IsjQLRBLSxWMkt YAc3o0RbsiQriWrp2DmhD1qI5TO1Z6Y3FeGzssGGiz5SAmENkp1z8BL7mgMSDj2HcQbsfkZNaAj XyiAXvtByyqMl1nc3QDAzcHk6650pp8Jr7Tzmrp4gOuOv9jjc7vfM2IkQGiAhW6+gIOO5TDuT0u x37cJvisNEbcY0YAOSB57MpTogVkYs+uViIY6aAtpXoEDvxVxeFJJcIikf/IyVsmC7TV2LJphXZ UkcFAl+gEoNT712dFIKsRp5OplAbojEWPyNrPdGlgK1rswtxoielTH6JPe6JdKM+bsYGp3TyEC2 7aEXZgVCVJjpQM61xCH1PDhG4j4iaR6liHdfehkHDe/hjXQlyIVj9twr3CojKjYi1bDQdh6 X-Received: by 2002:a05:600c:a305:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-4802521516emr95758905e9.24.1768833571562; Mon, 19 Jan 2026 06:39:31 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f429071a2sm249813135e9.11.2026.01.19.06.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 06:39:30 -0800 (PST) Date: Mon, 19 Jan 2026 14:39:28 +0000 From: Daniel Thompson To: Markus Elfring Cc: linux-trace-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Masami Hiramatsu , Mathieu Desnoyers , Steven Rostedt , LKML , Robin Murphy , Will Deacon Subject: Re: [PATCH] iommu: Fix NULL pointer deref when io_page_fault tracepoint fires Message-ID: References: <20260116-iommu-io_page_fault_null_fix-v1-1-6c20c2e62987@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 16, 2026 at 05:02:35PM +0100, Markus Elfring wrote: > … > > Fix this by adding logic to the tracepoint to safely propagate NULL. > > * How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? I could add a Fixes: f8f934c180f6 ("iommu/arm-smmu: Add support for driver IOMMU fault handlers") However, who do you think I neglected to Cc:? > * Would a summary phrase like “Prevent null pointer dereference for a tracepoint” > be a bit nicer? I don't understand what is wrong with the original phrasing. Can you explain why this change matters to you? Daniel.