From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D9BC25CC79 for ; Mon, 19 Jan 2026 20:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855606; cv=none; b=C2FU7q7NQGbsheJ4NH65uw+gK2sYFiYjgGONHVNnJi/892br7bfWsWqWb2hBHB1RWW7pVh+aL0C0565KGP1aG+kmVbHBBnN2ZrZk71WxwgCcpcr+AFiCA3H836yKWkC/T688PsXtFTE4pT0VLrnChCUcXp5RavgHcPLqdtCmOaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855606; c=relaxed/simple; bh=GThpleLyVlAzIlq7NuE8Ybc0GuZ4EhZQkax0YhHOBP4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=eV+pXEEd2rTawcT3wY8uk5VSMjTPZpHQjJOmHzkZQwSSpZGnp48zw0C48wD10csfoRls3vLewWcYhQQvGmVAtIWRsgaDmFlephRXE9t+z4OQRFcwhKKQygDLiKX9NzfPa9G7DwwsNw6u9+GQFfHvAnQMsLkUzkAQdF5OKI6GqLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu; spf=pass smtp.mailfrom=asu.edu; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b=VCU5/KOT; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=asu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b="VCU5/KOT" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2ae255ac8bdso8544375eec.0 for ; Mon, 19 Jan 2026 12:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1768855604; x=1769460404; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=GThpleLyVlAzIlq7NuE8Ybc0GuZ4EhZQkax0YhHOBP4=; b=VCU5/KOTLtwnzkNNi24bWWknbQiIG/v3iEMWWTpPeOBf6TZDdE3MJ/YSpYfEVNVtYI 2OR1gxWqpjfW9Vm/foo3mJkIFBH3xKNTo5wfbF7O0YjFpFzZLO3IUPTyofuzCxtVn+EK WCjb9IR3k3kAXmrgtBd2t0tItaFwxv9DCXZB1jHKY0yy8goSVSC4o0ITCgbP1HU9XdQR Ab7CtDh+0DvEcneczqnmRlCDH6X9hP+UlLQ8T18Ti7Ag5vi1MT9y03qvPyxiN5wW9kWJ UWta2dPYOArUXAbUUxTFtutI/Vmr6+9Lx/9vIPHzeRaKc8tN+xVWyBvYQKFj0FRcRASd UK4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768855604; x=1769460404; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GThpleLyVlAzIlq7NuE8Ybc0GuZ4EhZQkax0YhHOBP4=; b=hdx/OR8WySr1JYHXccJ6kAN/yBkbw3lxtHTlgmu6fZZXrwLunYGA3sVvOrZL0u7518 duDrQF0tg1cdLQEhXLpG7EpVDCoE2VhmBoRLjDe01OXhBBqY3DRIxvxCb8p7/XzFmAn+ 2tnETYRe4lRpz1H5fE97Xu1YZ5hiCVWsF6pEwhXhnbO1qI7Ik8fJXO4L7/Cqa0KwAkhy LuycgumyiTSljPWzpG7wKZDUhczgxYxmbtIRQ5S+y1mVq+T1IgIgrwkbN/fVWIo4+Ne3 aUgRjnGc+LUkK1uUb+wiFmiL++z0bJyTxPvNxkF3yEDByhVKaff4uW7nGjUfydwHQVWq cwSw== X-Forwarded-Encrypted: i=1; AJvYcCUqtFq5+JUHU+5GF0VkQIO20dUlnlWgrjbHuicNTJ3ZQxKaawzRcLvjPLeXIG8JOYBOgjqv2Mu9E0XzUak=@vger.kernel.org X-Gm-Message-State: AOJu0YwZ2fHWYTaoIt5n8dPI++cVW0n03gNd8gLSH/2MBaHpQx6UKVLH uhPOFQv0hxs8wizMg82ekvaxv5l0b1Z8dbb5TBOYR9Zubuy9wNwuJS1NheAPlbWVAg== X-Gm-Gg: AZuq6aJD4+gc9+e4yI+W3DqnYzJ6DKKpfdi9kM7hhAiA7mQEpFY0lCfGrVkt3aMHmzU 6xtZyltv0tW4Imk/abj8XVcuGNB0HIpk+nbXiPZ8ute3Vt8vA/vr7Nl52CoA0Nvj7cwQc2cAXF6 nSNCZEz6z4c7jTNGRqTCpHdx9P6SeLHgFC6onjKxUxAuxWpD7cSJXuhuEZKCqXUd1GinmCvDKLM VWfoH2VXwQoo313lQS66GOSYgnKnF0pcPrM6pHIxJGM0r94JJpbocyRp9X68Yt7dbqTLzApZzsi rctPmGnpzQ8AlYv0ZsYHc75v3PJFm+eNCVPSrTLk6czXOroYYPDVfDJjHD9rOhM7hMGzY1/wCVg GGoB5rkEPlWqpiAuPowTtiY1BuF5+9uYsv6naWQvb8wXfaZQiHotB6+k9mOrfpcibYZZf7lqvAE WHcfjI92J07/1n3PoaSoSMoQk8DyiZqgVYbmbFN70RkdY= X-Received: by 2002:a05:7301:4196:b0:2b4:7c92:3f81 with SMTP id 5a478bee46e88-2b6b381df3emr8278030eec.0.1768855602827; Mon, 19 Jan 2026 12:46:42 -0800 (PST) Received: from gmail.com (209-147-139-190.nat.asu.edu. [209.147.139.190]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b351e38bsm14264767eec.14.2026.01.19.12.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 12:46:42 -0800 (PST) Date: Mon, 19 Jan 2026 13:46:40 -0700 From: Will Rosenberg To: whrosenb@asu.edu Cc: Paul Moore , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Huw Davies , netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: ipv4: cipso potential BUG() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Previously, it was discussed that skb_cow() has a bug due to implicit integer casting that can lead to a BUG when headroom < -NET_SKB_PAD. We concluded that it was not worthwhile to fix the root cause and to instead fix the symptom found in calipso. The thread for this issue can be found here: https://lore.kernel.org/netdev/CAHC9VhQmR8A2vz0W-VrrhYNQ2wgCYxHbAmdgmM2yTL-uh4qiOg@mail.gmail.com/ I recently reviewed the use cases of skb_cow() throughout the kernel and found that cipso_v4_skbuff_setattr() comes very close to triggering the same BUG. However, I concluded this was not triggerable. Even though len_delta can become negative, leading to a negative headroom passed to skb_cow(), we do not satisfy the condition headroom < -NET_SKB_PAD. Nonetheless, I believe cipso is using skb_cow() dangerously, but since the issue is not triggerable, would it still make sense to patch it? I figured I would throw out a quick email. Please let me know and I can make a similar patch for cipso if necessary. -- Will Rosenberg